2016-07-23 08:13:33 +02:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
|
2017-11-03 13:38:49 +01:00
|
|
|
import ujson
|
2017-08-29 15:21:25 +02:00
|
|
|
import logging
|
2016-07-23 08:13:33 +02:00
|
|
|
import mock
|
2017-05-25 19:48:36 +02:00
|
|
|
import requests
|
2017-10-02 07:46:47 +02:00
|
|
|
|
|
|
|
from builtins import object
|
|
|
|
from django.test import override_settings
|
2017-05-26 16:37:45 +02:00
|
|
|
from requests import Response
|
2018-05-11 01:39:38 +02:00
|
|
|
from typing import Any, Dict, Tuple, Optional
|
2016-07-23 07:51:30 +02:00
|
|
|
|
2017-05-26 16:37:45 +02:00
|
|
|
from zerver.lib.outgoing_webhook import do_rest_call, OutgoingWebhookServiceInterface
|
2017-05-25 19:48:36 +02:00
|
|
|
from zerver.lib.test_classes import ZulipTestCase
|
2017-11-03 13:38:49 +01:00
|
|
|
from zerver.models import get_realm, get_user, UserProfile, get_display_recipient
|
2016-07-23 08:13:33 +02:00
|
|
|
|
2017-11-05 11:49:43 +01:00
|
|
|
class ResponseMock:
|
2017-11-05 10:51:25 +01:00
|
|
|
def __init__(self, status_code: int, content: Optional[Any]=None) -> None:
|
2016-07-23 08:13:33 +02:00
|
|
|
self.status_code = status_code
|
|
|
|
self.content = content
|
2017-11-03 13:38:49 +01:00
|
|
|
self.text = ujson.dumps(content)
|
2016-07-23 08:13:33 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def request_exception_error(http_method: Any, final_url: Any, data: Any, **request_kwargs: Any) -> Any:
|
2017-08-29 15:21:25 +02:00
|
|
|
raise requests.exceptions.RequestException("I'm a generic exception :(")
|
2016-07-23 08:13:33 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def timeout_error(http_method: Any, final_url: Any, data: Any, **request_kwargs: Any) -> Any:
|
2017-08-16 13:30:47 +02:00
|
|
|
raise requests.exceptions.Timeout("Time is up!")
|
2016-07-23 08:13:33 +02:00
|
|
|
|
2017-05-26 16:37:45 +02:00
|
|
|
class MockServiceHandler(OutgoingWebhookServiceInterface):
|
2018-10-10 13:16:42 +02:00
|
|
|
def process_success(self, response_json: Dict[str, Any], event: Dict[str, Any]) -> Optional[Dict[str, Any]]:
|
2018-10-09 16:12:32 +02:00
|
|
|
# Our tests don't really look at the content yet.
|
|
|
|
# They just ensure we use the "success" codepath.
|
|
|
|
success_data = dict(
|
2018-10-10 01:36:31 +02:00
|
|
|
content="whatever",
|
2018-10-09 16:12:32 +02:00
|
|
|
)
|
2018-10-09 17:12:57 +02:00
|
|
|
return success_data
|
2017-05-26 16:37:45 +02:00
|
|
|
|
|
|
|
service_handler = MockServiceHandler(None, None, None, None)
|
|
|
|
|
2016-07-23 08:13:33 +02:00
|
|
|
class DoRestCallTests(ZulipTestCase):
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2017-09-25 16:03:35 +02:00
|
|
|
realm = get_realm("zulip")
|
|
|
|
user_profile = get_user("outgoing-webhook@zulip.com", realm)
|
2017-08-29 15:21:25 +02:00
|
|
|
self.mock_event = {
|
|
|
|
# In the tests there is no active queue processor, so retries don't get processed.
|
|
|
|
# Therefore, we need to emulate `retry_event` in the last stage when the maximum
|
|
|
|
# retries have been exceeded.
|
|
|
|
'failed_tries': 3,
|
|
|
|
'message': {'display_recipient': 'Verona',
|
2018-02-15 21:02:47 +01:00
|
|
|
'stream_id': 999,
|
2017-08-29 15:21:25 +02:00
|
|
|
'subject': 'Foo',
|
|
|
|
'id': '',
|
|
|
|
'type': 'stream'},
|
|
|
|
'user_profile_id': user_profile.id,
|
|
|
|
'command': '',
|
|
|
|
'service_name': ''}
|
2017-09-25 16:03:35 +02:00
|
|
|
|
|
|
|
self.rest_operation = {'method': "POST",
|
|
|
|
'relative_url_path': "",
|
|
|
|
'request_kwargs': {},
|
|
|
|
'base_url': ""}
|
2017-08-29 15:21:25 +02:00
|
|
|
self.bot_user = self.example_user('outgoing_webhook_bot')
|
|
|
|
logging.disable(logging.WARNING)
|
2017-09-25 16:03:35 +02:00
|
|
|
|
2018-10-09 16:25:18 +02:00
|
|
|
@mock.patch('zerver.lib.outgoing_webhook.send_response_message')
|
|
|
|
def test_successful_request(self, mock_send: mock.Mock) -> None:
|
2017-11-03 13:12:59 +01:00
|
|
|
response = ResponseMock(200)
|
2016-07-23 08:13:33 +02:00
|
|
|
with mock.patch('requests.request', return_value=response):
|
2017-09-25 16:03:35 +02:00
|
|
|
do_rest_call(self.rest_operation, None, self.mock_event, service_handler, None)
|
2018-10-09 16:25:18 +02:00
|
|
|
self.assertTrue(mock_send.called)
|
2016-07-23 08:13:33 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_retry_request(self: mock.Mock) -> None:
|
2017-11-03 13:12:59 +01:00
|
|
|
response = ResponseMock(500)
|
2017-08-29 15:21:25 +02:00
|
|
|
|
|
|
|
self.mock_event['failed_tries'] = 3
|
2016-07-23 08:13:33 +02:00
|
|
|
with mock.patch('requests.request', return_value=response):
|
2017-09-25 16:03:35 +02:00
|
|
|
do_rest_call(self.rest_operation, None, self.mock_event, service_handler, None)
|
2017-08-29 15:21:25 +02:00
|
|
|
bot_owner_notification = self.get_last_message()
|
|
|
|
self.assertEqual(bot_owner_notification.content,
|
2018-02-15 21:02:47 +01:00
|
|
|
'''[A message](http://zulip.testserver/#narrow/stream/999-Verona/subject/Foo/near/) triggered an outgoing webhook.
|
2017-08-16 13:30:47 +02:00
|
|
|
The webhook got a response with status code *500*.''')
|
2017-08-29 15:21:25 +02:00
|
|
|
self.assertEqual(bot_owner_notification.recipient_id, self.bot_user.bot_owner.id)
|
|
|
|
self.mock_event['failed_tries'] = 0
|
2016-07-23 08:13:33 +02:00
|
|
|
|
|
|
|
@mock.patch('zerver.lib.outgoing_webhook.fail_with_message')
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_fail_request(self, mock_fail_with_message: mock.Mock) -> None:
|
2017-11-03 13:12:59 +01:00
|
|
|
response = ResponseMock(400)
|
2016-07-23 08:13:33 +02:00
|
|
|
with mock.patch('requests.request', return_value=response):
|
2017-09-25 16:03:35 +02:00
|
|
|
do_rest_call(self.rest_operation, None, self.mock_event, service_handler, None)
|
2017-08-29 15:21:25 +02:00
|
|
|
bot_owner_notification = self.get_last_message()
|
2016-07-23 08:13:33 +02:00
|
|
|
self.assertTrue(mock_fail_with_message.called)
|
2017-08-29 15:21:25 +02:00
|
|
|
self.assertEqual(bot_owner_notification.content,
|
2018-02-15 21:02:47 +01:00
|
|
|
'''[A message](http://zulip.testserver/#narrow/stream/999-Verona/subject/Foo/near/) triggered an outgoing webhook.
|
2017-08-29 15:21:25 +02:00
|
|
|
The webhook got a response with status code *400*.''')
|
|
|
|
self.assertEqual(bot_owner_notification.recipient_id, self.bot_user.bot_owner.id)
|
2016-07-23 08:13:33 +02:00
|
|
|
|
|
|
|
@mock.patch('logging.info')
|
|
|
|
@mock.patch('requests.request', side_effect=timeout_error)
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_timeout_request(self, mock_requests_request: mock.Mock, mock_logger: mock.Mock) -> None:
|
2017-09-25 16:03:35 +02:00
|
|
|
do_rest_call(self.rest_operation, None, self.mock_event, service_handler, None)
|
2017-08-29 15:21:25 +02:00
|
|
|
bot_owner_notification = self.get_last_message()
|
|
|
|
self.assertEqual(bot_owner_notification.content,
|
2018-02-15 21:02:47 +01:00
|
|
|
'''[A message](http://zulip.testserver/#narrow/stream/999-Verona/subject/Foo/near/) triggered an outgoing webhook.
|
2017-11-09 16:26:38 +01:00
|
|
|
When trying to send a request to the webhook service, an exception of type Timeout occurred:
|
2017-08-16 13:30:47 +02:00
|
|
|
```
|
|
|
|
Time is up!
|
|
|
|
```''')
|
2017-08-29 15:21:25 +02:00
|
|
|
self.assertEqual(bot_owner_notification.recipient_id, self.bot_user.bot_owner.id)
|
2016-07-23 08:13:33 +02:00
|
|
|
|
|
|
|
@mock.patch('logging.exception')
|
|
|
|
@mock.patch('requests.request', side_effect=request_exception_error)
|
|
|
|
@mock.patch('zerver.lib.outgoing_webhook.fail_with_message')
|
2017-11-17 07:00:53 +01:00
|
|
|
def test_request_exception(self, mock_fail_with_message: mock.Mock,
|
|
|
|
mock_requests_request: mock.Mock, mock_logger: mock.Mock) -> None:
|
2017-09-25 16:03:35 +02:00
|
|
|
do_rest_call(self.rest_operation, None, self.mock_event, service_handler, None)
|
2017-08-29 15:21:25 +02:00
|
|
|
bot_owner_notification = self.get_last_message()
|
2016-07-23 08:13:33 +02:00
|
|
|
self.assertTrue(mock_fail_with_message.called)
|
2017-08-29 15:21:25 +02:00
|
|
|
self.assertEqual(bot_owner_notification.content,
|
2018-02-15 21:02:47 +01:00
|
|
|
'''[A message](http://zulip.testserver/#narrow/stream/999-Verona/subject/Foo/near/) triggered an outgoing webhook.
|
2017-11-09 16:26:38 +01:00
|
|
|
When trying to send a request to the webhook service, an exception of type RequestException occurred:
|
2017-08-29 15:21:25 +02:00
|
|
|
```
|
|
|
|
I'm a generic exception :(
|
|
|
|
```''')
|
|
|
|
self.assertEqual(bot_owner_notification.recipient_id, self.bot_user.bot_owner.id)
|
2017-11-03 13:38:49 +01:00
|
|
|
|
|
|
|
class TestOutgoingWebhookMessaging(ZulipTestCase):
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2017-11-03 13:38:49 +01:00
|
|
|
self.user_profile = self.example_user("othello")
|
2018-01-30 17:05:14 +01:00
|
|
|
self.bot_profile = self.create_test_bot('outgoing-webhook', self.user_profile,
|
|
|
|
full_name='Outgoing Webhook bot',
|
|
|
|
bot_type=UserProfile.OUTGOING_WEBHOOK_BOT,
|
|
|
|
service_name='foo-service')
|
2017-11-03 13:38:49 +01:00
|
|
|
|
|
|
|
@mock.patch('requests.request', return_value=ResponseMock(200, {"response_string": "Hidley ho, I'm a webhook responding!"}))
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_pm_to_outgoing_webhook_bot(self, mock_requests_request: mock.Mock) -> None:
|
2017-11-03 13:38:49 +01:00
|
|
|
self.send_personal_message(self.user_profile.email, self.bot_profile.email,
|
|
|
|
content="foo")
|
|
|
|
last_message = self.get_last_message()
|
2018-10-10 01:36:31 +02:00
|
|
|
self.assertEqual(last_message.content, "Hidley ho, I'm a webhook responding!")
|
2017-11-03 13:38:49 +01:00
|
|
|
self.assertEqual(last_message.sender_id, self.bot_profile.id)
|
|
|
|
display_recipient = get_display_recipient(last_message.recipient)
|
2018-05-11 01:39:38 +02:00
|
|
|
# The next two lines error on mypy because the display_recipient is of type Union[str, List[Dict[str, Any]]].
|
2017-11-03 13:38:49 +01:00
|
|
|
# In this case, we know that display_recipient will be of type List[Dict[str, Any]].
|
|
|
|
# Otherwise this test will error, which is wanted behavior anyway.
|
|
|
|
self.assert_length(display_recipient, 1) # type: ignore
|
|
|
|
self.assertEqual(display_recipient[0]['email'], self.user_profile.email) # type: ignore
|
|
|
|
|
|
|
|
@mock.patch('requests.request', return_value=ResponseMock(200, {"response_string": "Hidley ho, I'm a webhook responding!"}))
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_stream_message_to_outgoing_webhook_bot(self, mock_requests_request: mock.Mock) -> None:
|
2017-11-03 13:38:49 +01:00
|
|
|
self.send_stream_message(self.user_profile.email, "Denmark",
|
|
|
|
content="@**{}** foo".format(self.bot_profile.full_name),
|
|
|
|
topic_name="bar")
|
|
|
|
last_message = self.get_last_message()
|
2018-10-10 01:36:31 +02:00
|
|
|
self.assertEqual(last_message.content, "Hidley ho, I'm a webhook responding!")
|
2017-11-03 13:38:49 +01:00
|
|
|
self.assertEqual(last_message.sender_id, self.bot_profile.id)
|
|
|
|
self.assertEqual(last_message.subject, "bar")
|
|
|
|
display_recipient = get_display_recipient(last_message.recipient)
|
|
|
|
self.assertEqual(display_recipient, "Denmark")
|