Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/navbar.hbs

58 lines
3.4 KiB
Handlebars
Raw Normal View History

Switch to fixed sidebar layout and remove bootstrap layout hooks. (imported from commit 060340a2febb7b8df6477a3419e7588a8503e377)
2013-08-13 12:52:26 +02:00
<div class="header">
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
<nav class="header-main rightside-userlist" id="top_navbar">
<div class="column-left">
<a class="brand no-style" href="#">
logo: Compute realm-logo url in frontend only. This commit fixes the bug of always showing day-mode realm logo when color scheme display setting is set to automatic but the OS setting is dark theme. This is because we cannot check the OS setting on backend and we need to set the logo url accordingly in frontend only. So, we remove the logo url computation from backend completely and instead compute it in the frontend only. Fixes #18778.
2021-06-27 13:25:55 +02:00
<img id="realm-logo" src="" alt="" class="nav-logo no-drag"/>
Modify crumbbar style to look like an arrowbar Also: * Change fixed element positioning and fix bugs * Move settings dropdown back to the right and add left padding to left sidebar (imported from commit fcf903b59617687f94618a01ce7544b69f408130)
2014-01-09 16:58:51 +01:00
</a>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
</div>
<div class="column-middle" id="navbar-middle">
<div class="column-middle-inner">
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
<div id="streamlist-toggle" {{#if embedded}}class="hide-streamlist-toggle-visibility"{{/if}} title="{{t 'Stream list' }} (q)">
js: Avoid href="#" for buttons with a JavaScript click handler. As seen in https://chat.zulip.org/#narrow/stream/9-issues/topic/edit.20history.20bug/near/1320430, clicking such a link takes you to the user's default view if the click handler throws an exception before doing preventDefault(). There hrefs also have the negative effect of having your browser claim that clicking the link will navigate you to the default view, which it won't. Comes with a linter rule to prevent future instances, since it seems there are some recently added ones, though they are likely the result of copy/paste.
2022-02-09 02:38:12 +01:00
<a id="streamlist-toggle-button" role="button"><i class="fa fa-reorder" aria-hidden="true"></i>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
<span id="streamlist-toggle-unreadcount">0</span>
</a>
</div>
navbar: Improve structure & styling for top navbar. This updates the logged-in top navbar to display the stream/message name, number of users, and description. It also replaces the search bar with a search icon that expands into a full-width search bar. Co-authored-by: Max Nussenbaum <max@maxnuss.com> Fixes: #164. Fixes: #5198.
2020-02-03 17:01:11 +01:00
<div class="top-navbar-border top-navbar-container">
navbar: Rename tab_bar to message_view_header. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. We purged tab_list in 1267caf5009118875f47fdafe312880af08024e1. This commit purges tab_bar, it includes: - A blanket search and replace of tab_bar with message_view_header. - Splitting a single line comment in tab_bar.js / message_view_header.js. - The renaming of tab_bar.js to message_view_header.js. - The renaming of tab_bar.hbs to message_view_header.hbs. - A blanket search and replace of tab_data with message_view_header_data. - Replacing the single occurrence of tabbar with message_view_header (it was within a comment.)
2020-07-08 23:44:01 +02:00
<div id="message_view_header" class="notdisplayed">
navbar: Extract tab_bar anchor out of the search divs. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. This commit pushes us towards that goal. Previously, this element was part of both searchbox and searchbox_legacy of which, only one would render based on the flag on search pills. This wasn't great because: * it made it likely that someone would change only one of the two and unintentionally introduce regressions. * it meant that search_icon selectors within the searchbox would mess with the search_icon elements within the tab_bar, leading us to rely on messy CSS overriding. Since there doesn't seem to be a strong reason to have this be the way it previously was, this commit extracts "#tab_bar". It's worth keeping in mind that we use the "#tab_bar" element as an anchor to append the #tab_list onto.
2020-06-25 21:27:02 +02:00
</div>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
{{#if search_pills_enabled }}
navbar: Extract navbar border into outer div. This is a prep commit for the new navbar, since the new navbar switches between a search bar and stream descriptions, it's easier to have the border defined in an outer div. Due to the way the changesets is generated, this may seem like a large diff, however, the only change to navbar.html is to add an opening div with the ".top-navbar-border" class and a corrseponding closing div to wrap around "#search_box" and "#search_box_legacy". Apart from this, a few styles have been edited in zulip.scss and night_mode.scss.
2020-02-21 20:02:49 +01:00
<div id="searchbox">
<form id="searchbox_form" class="form-search navbar-search">
<div id="search_arrows" class="pill-container input-append">
navbar: Refactor `#searchbox`. Along with various style fixes for the search pills enabled case, this de-duplicates the css.
2020-05-15 13:13:50 +02:00
<span class="search_icon search_open" ><i class="fa fa-search" aria-hidden="true"></i></span>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
<div contenteditable="true" class="input search-query input-block-level" id="search_query" type="text" placeholder="{{t 'Search' }}"
templates: Prevent dangling end tags. In cases where an opening tag is so long that we stretch it to 2+ lines of code, we should try to use block-style formatting in the template code. Unfortunately, we have lots of legacy code that violates this concept, so this is a timid fix. There are also legit use cases like textarea where we probably need to keep the ugly template syntax for things to render properly.
2021-11-21 16:17:01 +01:00
autocomplete="off" aria-label="{{t 'Search' }}" title="{{t 'Search' }} (/)">
</div>
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
<button class="btn search_button" type="button" id="search_exit" aria-label="{{t 'Exit search' }}">
<i class="fa fa-remove" aria-hidden="true"></i>
</button>
navbar: Extract navbar border into outer div. This is a prep commit for the new navbar, since the new navbar switches between a search bar and stream descriptions, it's easier to have the border defined in an outer div. Due to the way the changesets is generated, this may seem like a large diff, however, the only change to navbar.html is to add an opening div with the ".top-navbar-border" class and a corrseponding closing div to wrap around "#search_box" and "#search_box_legacy". Apart from this, a few styles have been edited in zulip.scss and night_mode.scss.
2020-02-21 20:02:49 +01:00
</div>
</form>
search: Duplicate HTML template content for search area. This is preparation for being able to work on the search pills feature without making any user-facing changes until we're ready to enable it.
2018-07-14 11:39:33 +02:00
</div>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
{{else}}
navbar: Extract navbar border into outer div. This is a prep commit for the new navbar, since the new navbar switches between a search bar and stream descriptions, it's easier to have the border defined in an outer div. Due to the way the changesets is generated, this may seem like a large diff, however, the only change to navbar.html is to add an opening div with the ".top-navbar-border" class and a corrseponding closing div to wrap around "#search_box" and "#search_box_legacy". Apart from this, a few styles have been edited in zulip.scss and night_mode.scss.
2020-02-21 20:02:49 +01:00
<div id="searchbox_legacy">
<form id="searchbox_form" class="form-search navbar-search">
<div id="search_arrows" class="input-append">
navbar: Refactor `#searchbox`. Along with various style fixes for the search pills enabled case, this de-duplicates the css.
2020-05-15 13:13:50 +02:00
<span class="search_icon search_open" ><i class="fa fa-search" aria-hidden="true"></i></span>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
<input class="search-query input-block-level home-page-input" id="search_query" type="text" placeholder="{{t 'Search' }}"
autocomplete="off" aria-label="{{t 'Search' }}" title="{{t 'Search' }} (/)"/>
<button class="btn search_button" type="button" id="search_exit" aria-label="{{t 'Exit search' }}"><i class="fa fa-remove" aria-hidden="true"></i></button>
navbar: Extract navbar border into outer div. This is a prep commit for the new navbar, since the new navbar switches between a search bar and stream descriptions, it's easier to have the border defined in an outer div. Due to the way the changesets is generated, this may seem like a large diff, however, the only change to navbar.html is to add an opening div with the ".top-navbar-border" class and a corrseponding closing div to wrap around "#search_box" and "#search_box_legacy". Apart from this, a few styles have been edited in zulip.scss and night_mode.scss.
2020-02-21 20:02:49 +01:00
</div>
</form>
</div>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
{{/if}}
search: Duplicate HTML template content for search area. This is preparation for being able to work on the search pills feature without making any user-facing changes until we're ready to enable it.
2018-07-14 11:39:33 +02:00
</div>
Modify crumbbar style to look like an arrowbar Also: * Change fixed element positioning and fix bugs * Move settings dropdown back to the right and add left padding to left sidebar (imported from commit fcf903b59617687f94618a01ce7544b69f408130)
2014-01-09 16:58:51 +01:00
</div>
</div>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
<div class="column-right">
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
<div id="userlist-toggle" title="{{t 'User list' }} (w)">
js: Avoid href="#" for buttons with a JavaScript click handler. As seen in https://chat.zulip.org/#narrow/stream/9-issues/topic/edit.20history.20bug/near/1320430, clicking such a link takes you to the user's default view if the click handler throws an exception before doing preventDefault(). There hrefs also have the negative effect of having your browser claim that clicking the link will navigate you to the default view, which it won't. Comes with a linter rule to prevent future instances, since it seems there are some recently added ones, though they are likely the result of copy/paste.
2022-02-09 02:38:12 +01:00
<a id="userlist-toggle-button" role="button"><i class="fa fa-group" aria-hidden="true"></i>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
<span id="userlist-toggle-unreadcount">0</span>
Move navbar code into its own "navbar.html". (imported from commit 4fa1c5d5ffa0af0ae8d608fad762470bf737205c)
2013-01-31 22:32:29 +01:00
</a>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
</div>
navbar: Migrate to handlebars. This commit migrates the `navbar.html` Django template to handlebars by creating a new file as `navbar.hbs` within `/static/templates` which is then rendered using `ui_init` module. As a part of migration, we also remove the `search_pills_enabled` and `embedded` parameters from the context attribute as they are no longer needed now. Fixes part of #18792.
2021-06-30 16:20:43 +02:00
<div id="navbar-buttons" {{#if embedded}}class="hide-navbar-buttons-visibility"{{/if}}>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
</div>
Move navbar code into its own "navbar.html". (imported from commit 4fa1c5d5ffa0af0ae8d608fad762470bf737205c)
2013-01-31 22:32:29 +01:00
</div>
zerver/navbar.html: Clean up to use 4 space indentation.
2018-01-27 18:33:41 +01:00
</nav>
Switch to fixed sidebar layout and remove bootstrap layout hooks. (imported from commit 060340a2febb7b8df6477a3419e7588a8503e377)
2013-08-13 12:52:26 +02:00
</div>