Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests/pm_conversations.js

57 lines
1.5 KiB
JavaScript
Raw Normal View History

js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const pmc = zrequire('pm_conversations');
typeahead: Add pm_conversations module. In pm_conversations.js, added function to make a user a PM partner and another function to check if a user is a PM partner. A PM partner is someone with whom the user has been in a PM with.
2017-06-01 07:46:23 +02:00
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
run_test('partners', () => {
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const user1_id = 1;
const user2_id = 2;
const user3_id = 3;
typeahead: Add pm_conversations module. In pm_conversations.js, added function to make a user a PM partner and another function to check if a user is a PM partner. A PM partner is someone with whom the user has been in a PM with.
2017-06-01 07:46:23 +02:00
pmc.set_partner(user1_id);
pmc.set_partner(user3_id);
assert.equal(pmc.is_partner(user1_id), true);
assert.equal(pmc.is_partner(user2_id), false);
assert.equal(pmc.is_partner(user3_id), true);
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
});
refactor: Extract pm_conversations.recent. This is a pretty pure code move, where we moved stuff from message_store to pm_conversations: insert_recent_private_message() -> recent.insert() recent_private_messages -> recent.get() The object message_store.recent_private_messages was not encapsulated in a function before this change. Now it is hidden in the scope of pm_conversations.recent. Both of the modules touched here maintain 100% line coverage.
2018-02-09 18:10:39 +01:00
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
zrequire("people");
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
run_test('insert_recent_private_message', () => {
ui_init: Pass params to pm_conversations.recent. This is follow up to da79fd206aa75adfdcad8d1a8d0d2b1583f6aab7 I accidentally skipped over pm_conversations. Same ideas as the bigger previous commit--we pass in params to the initialize function and do the delete cleanup within ui_init.
2020-02-26 23:36:38 +01:00
const params = {
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
recent_private_conversations: [
tests: Use tricky server data in unit tests. The server may send us ids in the order [11, 2], instead of [2, 11]. We don't want to rely on server behavior, regardless, for the sort. Our tests now show we process that data. The current code is is still buggy and causes us to show the same huddle two different times for situations where the lexical sort doesn't match the numerical sort. This happens on czo often, where Tim is user 7, and his id sorts lexically after ids like 58, 622, 4444, etc.
2020-01-01 15:26:25 +01:00
{user_ids: [11, 2],
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
max_message_id: 150,
},
{user_ids: [1],
max_message_id: 111,
},
{user_ids: [],
max_message_id: 7,
},
],
ui_init: Pass params to pm_conversations.recent. This is follow up to da79fd206aa75adfdcad8d1a8d0d2b1583f6aab7 I accidentally skipped over pm_conversations. Same ideas as the bigger previous commit--we pass in params to the initialize function and do the delete cleanup within ui_init.
2020-02-26 23:36:38 +01:00
};
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
people.initialize_current_user(15);
ui_init: Pass params to pm_conversations.recent. This is follow up to da79fd206aa75adfdcad8d1a8d0d2b1583f6aab7 I accidentally skipped over pm_conversations. Same ideas as the bigger previous commit--we pass in params to the initialize function and do the delete cleanup within ui_init.
2020-02-26 23:36:38 +01:00
pmc.recent.initialize(params);
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
assert.deepEqual(pmc.recent.get(), [
bug fix: Fix huddles in "Private Messages". If two user_ids in a recent huddle have ids that sort lexically differently than numerically, such as 7 and 66, then we were creating two different buckets in pm_conversations. This regression was introduced in 263ac0eb456ca972b5c845c9a74fdded6914ae22 on November 21, 2019.
2020-01-01 15:55:36 +01:00
{user_ids_string: '2,11', max_message_id: 150},
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
{user_ids_string: '1', max_message_id: 111},
{user_ids_string: '15', max_message_id: 7},
]);
refactor: Have pm_conversations take user_ids. Instead of having our callers pass in a possibly non-canonical version of a user_ids_string, just have them pass in a list. The next commit will canonicalize the sort.
2020-01-01 15:42:46 +01:00
pmc.recent.insert([1], 1001);
pmc.recent.insert([2], 2001);
pmc.recent.insert([1], 3001);
refactor: Extract pm_conversations.recent. This is a pretty pure code move, where we moved stuff from message_store to pm_conversations: insert_recent_private_message() -> recent.insert() recent_private_messages -> recent.get() The object message_store.recent_private_messages was not encapsulated in a function before this change. Now it is hidden in the scope of pm_conversations.recent. Both of the modules touched here maintain 100% line coverage.
2018-02-09 18:10:39 +01:00
pm_conversations: Refactor to sort by message ID. message_id, rather than timestamps, is our standard way to sort by time. And this refactor is important because we're about to start using data from the server to populate this data structure.
2019-11-21 20:47:14 +01:00
// try to backdate user1's latest message
refactor: Have pm_conversations take user_ids. Instead of having our callers pass in a possibly non-canonical version of a user_ids_string, just have them pass in a list. The next commit will canonicalize the sort.
2020-01-01 15:42:46 +01:00
pmc.recent.insert([1], 555);
refactor: Extract pm_conversations.recent. This is a pretty pure code move, where we moved stuff from message_store to pm_conversations: insert_recent_private_message() -> recent.insert() recent_private_messages -> recent.get() The object message_store.recent_private_messages was not encapsulated in a function before this change. Now it is hidden in the scope of pm_conversations.recent. Both of the modules touched here maintain 100% line coverage.
2018-02-09 18:10:39 +01:00
assert.deepEqual(pmc.recent.get(), [
pm_conversations: Refactor to sort by message ID. message_id, rather than timestamps, is our standard way to sort by time. And this refactor is important because we're about to start using data from the server to populate this data structure.
2019-11-21 20:47:14 +01:00
{user_ids_string: '1', max_message_id: 3001},
{user_ids_string: '2', max_message_id: 2001},
bug fix: Fix huddles in "Private Messages". If two user_ids in a recent huddle have ids that sort lexically differently than numerically, such as 7 and 66, then we were creating two different buckets in pm_conversations. This regression was introduced in 263ac0eb456ca972b5c845c9a74fdded6914ae22 on November 21, 2019.
2020-01-01 15:55:36 +01:00
{user_ids_string: '2,11', max_message_id: 150},
pm_conversations: Initialize using server data. This simple change switches us to take advantage of the server-maintained data for the pm_conversations system we implemented originally for mobile use. This should make it a lot more convenient to find historical private message conversations, since one can effectively scroll infinitely into the history. We'll need to do some profiling of the backend after this is deployed in production; it's possible we'll need to add some database indexes, denormalization, or other optimizations to avoid making loading the Zulip app significantly slower. Fixes #12502.
2019-11-21 21:01:15 +01:00
{user_ids_string: '15', max_message_id: 7},
refactor: Extract pm_conversations.recent. This is a pretty pure code move, where we moved stuff from message_store to pm_conversations: insert_recent_private_message() -> recent.insert() recent_private_messages -> recent.get() The object message_store.recent_private_messages was not encapsulated in a function before this change. Now it is hidden in the scope of pm_conversations.recent. Both of the modules touched here maintain 100% line coverage.
2018-02-09 18:10:39 +01:00
]);
Add pm_conversations.recent.get_strings(). We will use this method for hotkey navigation through recent pms.
2018-02-09 21:13:38 +01:00
bug fix: Fix huddles in "Private Messages". If two user_ids in a recent huddle have ids that sort lexically differently than numerically, such as 7 and 66, then we were creating two different buckets in pm_conversations. This regression was introduced in 263ac0eb456ca972b5c845c9a74fdded6914ae22 on November 21, 2019.
2020-01-01 15:55:36 +01:00
assert.deepEqual(pmc.recent.get_strings(), ['1', '2', '2,11', '15']);
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
});