Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/casper_tests/12-custom-profile.js

73 lines
2.4 KiB
JavaScript
Raw Normal View History

js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"use strict";
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
var common = require("../casper_lib/common.js");
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
common.start_and_log_in();
common.manage_organization();
// Test custom profile fields
casper.test.info("Testing custom profile fields");
casper.thenClick("li[data-section='profile-field-settings']");
casper.then(function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitUntilVisible(".admin-profile-field-form", function () {
casper.fill("form.admin-profile-field-form", {
name: "Teams",
field_type: "1",
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
casper.click("form.admin-profile-field-form button[type='submit']");
});
});
casper.then(function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitUntilVisible("#admin-add-profile-field-status img", function () {
casper.test.assertSelectorHasText("div#admin-add-profile-field-status", "Saved");
common.wait_for_text(".profile-field-row span.profile_field_name", "Teams", function () {
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
casper.test.assertSelectorHasText(
".profile-field-row span.profile_field_name",
"Teams"
);
casper.test.assertSelectorHasText(
".profile-field-row span.profile_field_type",
"Short text"
);
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.click(".profile-field-row button.open-edit-form");
casper: Use wait_for_text in custom profile test. This should avoid some test flakes.
2020-04-10 13:24:37 +02:00
});
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
});
casper.then(function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitUntilVisible("tr.profile-field-form form", function () {
casper.fill("tr.profile-field-form form.name-setting", {
name: "team",
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.click("tr.profile-field-form button.submit");
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
});
casper.then(function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitUntilVisible("#admin-profile-field-status img", function () {
casper.test.assertSelectorHasText("div#admin-profile-field-status", "Saved");
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitForSelectorTextChange(".profile-field-row span.profile_field_name", function () {
casper.test.assertSelectorHasText(".profile-field-row span.profile_field_name", "team");
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
casper.test.assertSelectorHasText(
".profile-field-row span.profile_field_type",
"Short text"
);
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.click(".profile-field-row button.delete");
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
});
casper.then(function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
casper.waitUntilVisible("#admin-profile-field-status img", function () {
casper.test.assertSelectorHasText("div#admin-profile-field-status", "Saved");
casper: Extract 12-custom-profile. Breaking the Casper tests into smaller tests will make it a lot easier in the future to hone in on test flakes. Having small tests adds little overhead--most of the slowness comes from starting the server. The only extra steps here are logging in and entering "Manage Organization", which is two lines of code. We split out the custom profile test first, since the code for custom profiles has the annoying property that it can only run once before failing, as it has the side effect of creating a field name that can't be reused. We only need to run loops to test flakes, so this isn't an immediate blocker.
2020-04-10 12:48:09 +02:00
});
});
common.then_log_out();
casper.run(function () {
casper.test.done();
});