Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/message_edit_form.hbs

84 lines
4.6 KiB
Handlebars
Raw Normal View History

Fix comment to describe the file it's in rather than a file it may have been copied from. (imported from commit 889b5d421c43c62d17a108ae112eff4b7807539f)
2013-06-11 16:31:02 +02:00
{{! Client-side Mustache template for rendering the message edit form. }}
Add user interface frontend for editing messages. The only known outstanding bug with this is that it doesn't properly handle the updating of a message's highlighting/presence in a narrowed view (e.g. in theory, a message should disappear if it is edited such that its subject doesn't match your narrow or it no longer matches your search). I think I'll just open a trac ticket about that once this is merged, since it's a little hairy to deal with and kinda a marginal use case. Also it's not pretty, but that should be easy to tweak once we get the framework merged. Conflicts: tools/jslint/check-all.js (imported from commit 2d0e3a440bcd885546bd8e28aff97bf379649950)
2013-05-15 00:22:16 +02:00
message_edit_form: Convert from `id` to `class`. Since we can have multiple instances of `message_edit_form`, it makes sense to have it as a class. We track the message_edit_form by setting an id to `form` element dependent on message_id.
2021-04-21 16:20:16 +02:00
<form id="edit_form_{{message_id}}" class="form-horizontal new-style">
message edit: Allow uploading files. Fixes: #198.
2017-11-28 22:36:58 +01:00
<div class="alert" id="message-edit-send-status-{{message_id}}">
<span class="send-status-close">&times;</span>
<span class="error-msg"></span>
</div>
Clean message_edit_form.handlebars to use 4 space indents.
2017-04-15 04:05:55 +02:00
{{#if is_stream}}
Fix message topic edit CSS. This fixes the overflowing issues, the broken styling of the topic edit input box, and makes it somewhat more responsive. Fixes: #1270.
2016-08-26 21:36:10 +02:00
<div class="control-group no-margin">
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
<div class="controls edit-controls">
message_edit: Show stream color bar alongside stream select. * Stream bar color logic is borrwoed from compose stream bar. * Use flex containers to align elements and automatically set their height to be same, them automatically filling the stream color bar height to be the height of the select box. * Use flex-wrap to wrap the propagate selector when out of space. * To make sure stream select box and stream color box are closest possible, select box has been moved under stream color box.
2020-05-12 11:02:13 +02:00
<div class="message_edit_header">
message_edit: Rename show_edit_stream to is_stream_editable. This commit renames show_edit_stream to is_stream_editable for more clarity.
2021-06-03 19:22:23 +02:00
<div class="stream_header_colorblock" {{#unless is_stream_editable}}style="display:none"{{/unless}}></div>
message_edit: Refactor message_edit to use dropdown_list_widget. Implemented dropdown_list_widget in message_edit UI which enables the functionality to search for streams while moving a particular message across streams. This matches the UI we have in the "move topic" widget. Fixes #18416.
2021-05-12 21:41:14 +02:00
<div class="select_stream_dropdown" {{#unless is_stream_editable}}style="display:none"{{/unless}}>
{{> settings/dropdown_list_widget
widget_name=select_move_stream_widget_name
list_placeholder=(t 'Filter streams')}}
</div>
message_edit: Rename show_edit_stream to is_stream_editable. This commit renames show_edit_stream to is_stream_editable for more clarity.
2021-06-03 19:22:23 +02:00
<i class="fa fa-angle-right" aria-hidden="true" {{#unless is_stream_editable}}style="display:none"{{/unless}}></i>
message-editing: Add autocomplete suggestions for topic editing. We extends composebox_typeahead to support autocompletion suggestions on editing the topic of a message from message edit form as well as from recipient bar. Tweaked by tabbott to have correct keyboard interaction without needing to patch Bootstrap. Fixes: #16368.
2021-07-07 22:56:58 +02:00
<input type="text" placeholder="{{topic}}" value="{{topic}}" class="message_edit_topic" id="message_edit_topic" autocomplete="off" />
move_topic_to_stream: Add option to disable breadcrumb messages. Option to disable breadcrumb messages were given in both message edit form and topic edit stream popover. User now has the option to select which stream to send the notification of stream edit of a topic via checkboxes in the UI.
2020-06-03 16:44:57 +02:00
<div class="message_edit_breadcrumb_messages" style='display:none;'>
message_edit: Replace checkboxes with settings_checkbox partial. This commits replaces the custom `send_notification` message_edit checkboxes with our `settings_checkbox` partial. The main intention is to also support the feature of selecting a checkbox by clicking over its corresponding label as we have in the case of the organization settings checkboxes. Due to above change, this commit also removes the redundant `break-row` HTML class along with it styles.
2021-07-21 15:41:25 +02:00
{{> settings/settings_checkbox
setting_name="send_notification_to_new_thread"
prefix="id_"
is_checked=notify_new_thread
label=(t 'Send notification to new topic')}}
{{> settings/settings_checkbox
setting_name="send_notification_to_old_thread"
prefix="id_"
is_checked=notify_old_thread
label=(t 'Send notification to old topic')}}
move_topic_to_stream: Add option to disable breadcrumb messages. Option to disable breadcrumb messages were given in both message edit form and topic edit stream popover. User now has the option to select which stream to send the notification of stream edit of a topic via checkboxes in the UI.
2020-06-03 16:44:57 +02:00
</div>
message_edit: Show stream color bar alongside stream select. * Stream bar color logic is borrwoed from compose stream bar. * Use flex containers to align elements and automatically set their height to be same, them automatically filling the stream color bar height to be the height of the select box. * Use flex-wrap to wrap the propagate selector when out of space. * To make sure stream select box and stream color box are closest possible, select box has been moved under stream color box.
2020-05-12 11:02:13 +02:00
<select class='message_edit_topic_propagate' style='display:none;'>
<option selected="selected" value="change_later"> {{t "Change later messages to this topic" }}</option>
<option value="change_one"> {{t "Change only this message topic" }}</option>
<option value="change_all"> {{t "Change previous and following messages to this topic" }}</option>
</select>
</div>
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
</div>
</div>
Clean message_edit_form.handlebars to use 4 space indents.
2017-04-15 04:05:55 +02:00
{{/if}}
Show markdown help in message editing UI. Fixes #2578.
2016-12-14 05:38:59 +01:00
<div class="control-group no-margin">
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
<div class="controls edit-controls">
templates: Extract and tweak copy_message_button from message_edit_form. Small tweak in the extracted text which adds aria-lable to the button.
2020-08-28 04:51:31 +02:00
{{> copy_message_button message_id=this.message_id}}
compose: Use `class` to find `markdown_preview` related elements. We convert the following elements to use a class instead of id for accessing them across the codebase: * markdown_preview * undo_markdown_preview * markdown_preview_spinner * message_edit_content * preview_content Converted them together since changes to one impacted the other in some modules like click_handlers. Also, added a function in rows to get `message_row`.
2021-04-20 19:50:01 +02:00
<textarea class="message_edit_content" maxlength="10000">{{content}}</textarea>
message edit: Add "preview" option to edit UI. This add the "Preview" option to message edit controls similar to that in compose UI. Fixes #11438.
2019-02-05 15:27:17 +01:00
<div class="scrolling_list preview_message_area" id="preview_message_area_{{message_id}}" style="display:none;">
compose: Use `class` to find `markdown_preview` related elements. We convert the following elements to use a class instead of id for accessing them across the codebase: * markdown_preview * undo_markdown_preview * markdown_preview_spinner * message_edit_content * preview_content Converted them together since changes to one impacted the other in some modules like click_handlers. Also, added a function in rows to get `message_row`.
2021-04-20 19:50:01 +02:00
<div class="markdown_preview_spinner"></div>
<div class="preview_content rendered_markdown"></div>
message edit: Add "preview" option to edit UI. This add the "Preview" option to message edit controls similar to that in compose UI. Fixes #11438.
2019-02-05 15:27:17 +01:00
</div>
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
</div>
</div>
Fix the position of the edit message label. This fixes the position of the "Topic" label to be above the input and adds a "Content" label to improve consistency.
2017-01-31 22:01:49 +01:00
<div class="control-group action-buttons">
ui: Add loading indicator for message edits. This commit hides the "Save" and "Cancel" buttons after the first click and shows a spinner until a successful / failed response is received. We do not allow sending any other message edit requests during this time frame, similar to how our inline topic edit ui works. Fixes #16143.
2020-08-21 07:34:21 +02:00
<div class="message_edit_spinner"></div>
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
<div class="controls edit-controls">
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
{{#if is_editable}}
message_edit: Show loading indicator inside the button. We now show loading indicator inside the 'save' button instead of hiding the buttons to show the loading indicator. Both the save and clear buttons are disabled when the request is processing. We do not change color of the buttons just change the cursor to indicate that button are disabled and nothing happens on clicking them. The reason for disabling the cancel button is that it is actually not possible to cancel the action once loading has started, so it is actually better to disable it only such that users are not confused. This commit adds a wrapper div element around the button because we wanted to add two css properties to the button- 'pointer-events: none' such that nothing happens on click and 'cursor: not-allowed' to indicate that buttons are disabled. But these boht styles cannot be added to same element because 'pointer-events: none' overrides the 'cursor: not-allowed' style and normal cursor is visible. That's why we add a wrapper to add 'cursor: not-allowed' style to it and add 'pointer-events: none' to the button.
2021-07-03 19:18:57 +02:00
<div class="btn-wrapper inline-block">
<button type="button" class="button small rounded sea-green message_edit_save">
loading: Use img tag for loading indicator instead of object tag. We use img tag for showing the loading spinner in message edit form and dialog-widget submit button, instead of object tag because using object tag gives the following error- "Refused to display 'https://chat.zulip.org/' in a frame because it set 'X-Frame-Options' to 'deny'." in the browser console. As mentioned by Anders in czo, this is probably because we’re loading the SVG using an <object> tag as if it’s totally-not-an-IE3-ActiveX- control. We also need to add a new svg file similar to loader.svg with the change that the retangles are filled with black color. This needs to be done because we cannot get access to the svg document if we use img tag and so we cannot change the color of rectangles using jquery as we were doing before to show the spinner depending on day/night mode. So, now we just set the src attribute of img tag to the correct svg file depending on day/night mode. Discussed in #issues > loading tail-spin.svg denied by X-Frame-Options.
2021-07-16 08:45:23 +02:00
<img class="loader" alt="" src="" />
message_edit: Show loading indicator inside the button. We now show loading indicator inside the 'save' button instead of hiding the buttons to show the loading indicator. Both the save and clear buttons are disabled when the request is processing. We do not change color of the buttons just change the cursor to indicate that button are disabled and nothing happens on clicking them. The reason for disabling the cancel button is that it is actually not possible to cancel the action once loading has started, so it is actually better to disable it only such that users are not confused. This commit adds a wrapper div element around the button because we wanted to add two css properties to the button- 'pointer-events: none' such that nothing happens on click and 'cursor: not-allowed' to indicate that buttons are disabled. But these boht styles cannot be added to same element because 'pointer-events: none' overrides the 'cursor: not-allowed' style and normal cursor is visible. That's why we add a wrapper to add 'cursor: not-allowed' style to it and add 'pointer-events: none' to the button.
2021-07-03 19:18:57 +02:00
<span>{{t "Save" }}</span>
</button>
</div>
<div class="btn-wrapper inline-block">
<button type="button" class="button small rounded message_edit_cancel">{{t "Cancel" }}</button>
</div>
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
{{#if is_content_editable}}
<div class="message-edit-feature-group">
message_edit: Deduplicate control buttons. Deduplicate control buttons by re-using the compose_control_buttons. A link to `help` overlay was added to `message_edit_form` as a part of this process. This fixes a bug that when video provider is set to `Jitsi` from `none` in organization settings while message_edit_form is open, the video icon is not displayed since it was not present in the message_edit_form DOM even if compose.update_video_chat_button_display tries to display it. It is fixed since the `.video_link` element is always present in DOM of `message_edit_form` now.
2021-04-20 23:39:08 +02:00
{{> compose_control_buttons }}
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
</div>
{{/if}}
message_edit: Fix content editing icons appearing in "view source". These icons was misplaced during a recent refactoring, resulting in the compose icons appearing even for non-editable messages. Fixes part of #11666.
2019-02-24 20:24:50 +01:00
{{else}}
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
<button type="button" class="button small rounded message_edit_close">{{t "Close" }}</button>
message_edit: Fix content editing icons appearing in "view source". These icons was misplaced during a recent refactoring, resulting in the compose icons appearing even for non-editable messages. Fixes part of #11666.
2019-02-24 20:24:50 +01:00
{{/if}}
{{#if has_been_editable}}
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
<div class="message-edit-timer-control-group">
<span class="message_edit_countdown_timer"></span>
widgets: Prevent edits to widgets. As of now, editing a widget doesn't update the rendered content. It's important to ensure that existing votes or options added later on don't get deleted when rendered. This seems more complex than it's worth. For now, we just prevent edits to widgets. This commit makes the UI clearer that editing widgets isn't allowed. See also: https://github.com/zulip/zulip/issues/14229 https://github.com/zulip/zulip/issues/14799 Fixes #17156
2021-01-31 18:23:48 +01:00
<span><i id="message_edit_tooltip" class="tippy-zulip-tooltip message_edit_tooltip fa fa-question-circle" aria-hidden="true"
{{#if is_widget_message}} data-tippy-content="{{#tr}}Widgets cannot be edited.{{/tr}}" {{else}} data-tippy-content="{{#tr}}This organization is configured to restrict editing of message content to {minutes_to_edit} minutes after it is sent.{{/tr}}" {{/if}}></i>
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
</span>
</div>
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
{{/if}}
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
</div>
</div>
Allow anyone to edit a "no topic" message This change would allow anyone in the realm to set a topic for a "no topic" message. As soon as the message topic is set, only the sender can change it again. (imported from commit 0a91a93b8fd14549965cedc79f45ffd869d82307)
2013-08-16 23:45:13 +02:00
<div class="alert alert-error edit_error hide"></div>
Add user interface frontend for editing messages. The only known outstanding bug with this is that it doesn't properly handle the updating of a message's highlighting/presence in a narrowed view (e.g. in theory, a message should disappear if it is edited such that its subject doesn't match your narrow or it no longer matches your search). I think I'll just open a trac ticket about that once this is merged, since it's a little hairy to deal with and kinda a marginal use case. Also it's not pretty, but that should be easy to tweak once we get the framework merged. Conflicts: tools/jslint/check-all.js (imported from commit 2d0e3a440bcd885546bd8e28aff97bf379649950)
2013-05-15 00:22:16 +02:00
</form>