2022-04-14 23:49:26 +02:00
|
|
|
import datetime
|
2022-08-27 18:42:10 +02:00
|
|
|
from typing import Iterable, Optional, Union
|
2022-04-14 23:49:26 +02:00
|
|
|
|
2022-08-24 21:42:44 +02:00
|
|
|
from django.conf import settings
|
2022-04-14 23:49:26 +02:00
|
|
|
from django.db import transaction
|
|
|
|
from django.db.models import F
|
|
|
|
from django.utils.timezone import now as timezone_now
|
|
|
|
|
|
|
|
from confirmation.models import Confirmation, create_confirmation_link
|
2023-11-28 18:25:06 +01:00
|
|
|
from confirmation.settings import STATUS_REVOKED
|
2022-08-24 21:42:44 +02:00
|
|
|
from zerver.actions.presence import do_update_user_presence
|
2022-04-14 23:49:26 +02:00
|
|
|
from zerver.lib.avatar import avatar_url
|
|
|
|
from zerver.lib.cache import (
|
|
|
|
cache_delete,
|
|
|
|
delete_user_profile_caches,
|
2021-10-26 09:15:16 +02:00
|
|
|
flush_user_profile,
|
2022-04-14 23:49:26 +02:00
|
|
|
user_profile_by_api_key_cache_key,
|
|
|
|
)
|
2021-10-26 09:15:16 +02:00
|
|
|
from zerver.lib.create_user import get_display_email_address
|
2022-04-14 23:49:26 +02:00
|
|
|
from zerver.lib.i18n import get_language_name
|
|
|
|
from zerver.lib.queue import queue_json_publish
|
|
|
|
from zerver.lib.send_email import FromAddress, clear_scheduled_emails, send_email
|
|
|
|
from zerver.lib.timezone import canonicalize_timezone
|
|
|
|
from zerver.lib.upload import delete_avatar_image
|
2022-05-25 13:13:31 +02:00
|
|
|
from zerver.lib.users import (
|
|
|
|
can_access_delivery_email,
|
|
|
|
check_bot_name_available,
|
|
|
|
check_full_name,
|
2023-10-11 09:34:26 +02:00
|
|
|
get_user_ids_who_can_access_user,
|
2022-05-25 13:13:31 +02:00
|
|
|
get_users_with_access_to_real_email,
|
2023-10-11 09:34:26 +02:00
|
|
|
user_access_restricted_in_realm,
|
2022-05-25 13:13:31 +02:00
|
|
|
)
|
2022-04-14 23:49:26 +02:00
|
|
|
from zerver.lib.utils import generate_api_key
|
|
|
|
from zerver.models import (
|
|
|
|
Draft,
|
|
|
|
EmailChangeStatus,
|
|
|
|
RealmAuditLog,
|
|
|
|
ScheduledEmail,
|
|
|
|
ScheduledMessageNotificationEmail,
|
2022-08-24 21:42:44 +02:00
|
|
|
UserPresence,
|
2022-04-14 23:49:26 +02:00
|
|
|
UserProfile,
|
|
|
|
bot_owner_user_ids,
|
2022-08-24 21:42:44 +02:00
|
|
|
get_client,
|
2022-03-27 22:40:21 +02:00
|
|
|
get_user_profile_by_id,
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
from zerver.tornado.django_api import send_event, send_event_on_commit
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
|
|
|
|
def send_user_email_update_event(user_profile: UserProfile) -> None:
|
|
|
|
payload = dict(user_id=user_profile.id, new_email=user_profile.email)
|
|
|
|
event = dict(type="realm_user", op="update", person=payload)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
event,
|
2023-10-11 09:34:26 +02:00
|
|
|
get_user_ids_who_can_access_user(user_profile),
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
|
2022-05-25 13:13:31 +02:00
|
|
|
def send_delivery_email_update_events(
|
|
|
|
user_profile: UserProfile, old_visibility_setting: int, visibility_setting: int
|
|
|
|
) -> None:
|
2023-10-11 09:34:26 +02:00
|
|
|
if not user_access_restricted_in_realm(user_profile):
|
|
|
|
active_users = user_profile.realm.get_active_users()
|
|
|
|
else:
|
|
|
|
# The get_user_ids_who_can_access_user returns user IDs and not
|
|
|
|
# user objects and we instead do one more query for UserProfile
|
|
|
|
# objects. We need complete UserProfile objects only for a couple
|
|
|
|
# of cases and it is not worth to query the whole UserProfile
|
|
|
|
# objects in all the cases and it is fine to do the extra query
|
|
|
|
# wherever needed.
|
|
|
|
user_ids_who_can_access_user = get_user_ids_who_can_access_user(user_profile)
|
|
|
|
active_users = UserProfile.objects.filter(
|
|
|
|
id__in=user_ids_who_can_access_user, is_active=True
|
|
|
|
)
|
|
|
|
|
2022-05-25 13:13:31 +02:00
|
|
|
delivery_email_now_visible_user_ids = []
|
|
|
|
delivery_email_now_invisible_user_ids = []
|
|
|
|
|
|
|
|
for active_user in active_users:
|
|
|
|
could_access_delivery_email_previously = can_access_delivery_email(
|
2021-10-26 09:15:16 +02:00
|
|
|
active_user, user_profile.id, old_visibility_setting
|
2022-05-25 13:13:31 +02:00
|
|
|
)
|
|
|
|
can_access_delivery_email_now = can_access_delivery_email(
|
2021-10-26 09:15:16 +02:00
|
|
|
active_user, user_profile.id, visibility_setting
|
2022-05-25 13:13:31 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
if could_access_delivery_email_previously != can_access_delivery_email_now:
|
|
|
|
if can_access_delivery_email_now:
|
|
|
|
delivery_email_now_visible_user_ids.append(active_user.id)
|
|
|
|
else:
|
|
|
|
delivery_email_now_invisible_user_ids.append(active_user.id)
|
|
|
|
|
|
|
|
if delivery_email_now_visible_user_ids:
|
|
|
|
person = dict(user_id=user_profile.id, delivery_email=user_profile.delivery_email)
|
|
|
|
event = dict(type="realm_user", op="update", person=person)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
event,
|
|
|
|
delivery_email_now_visible_user_ids,
|
2022-05-25 13:13:31 +02:00
|
|
|
)
|
|
|
|
if delivery_email_now_invisible_user_ids:
|
|
|
|
person = dict(user_id=user_profile.id, delivery_email=None)
|
|
|
|
event = dict(type="realm_user", op="update", person=person)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
event,
|
|
|
|
delivery_email_now_invisible_user_ids,
|
2022-05-25 13:13:31 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
@transaction.atomic(savepoint=False)
|
|
|
|
def do_change_user_delivery_email(user_profile: UserProfile, new_email: str) -> None:
|
2023-07-13 13:02:12 +02:00
|
|
|
delete_user_profile_caches([user_profile], user_profile.realm)
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
user_profile.delivery_email = new_email
|
|
|
|
if user_profile.email_address_is_realm_public():
|
|
|
|
user_profile.email = new_email
|
|
|
|
user_profile.save(update_fields=["email", "delivery_email"])
|
|
|
|
else:
|
|
|
|
user_profile.save(update_fields=["delivery_email"])
|
|
|
|
|
2022-05-25 13:13:31 +02:00
|
|
|
# We notify all the users who have access to delivery email.
|
2022-04-14 23:49:26 +02:00
|
|
|
payload = dict(user_id=user_profile.id, delivery_email=new_email)
|
|
|
|
event = dict(type="realm_user", op="update", person=payload)
|
2022-05-25 13:13:31 +02:00
|
|
|
delivery_email_visible_user_ids = get_users_with_access_to_real_email(user_profile)
|
|
|
|
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(user_profile.realm, event, delivery_email_visible_user_ids)
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
if user_profile.avatar_source == UserProfile.AVATAR_FROM_GRAVATAR:
|
|
|
|
# If the user is using Gravatar to manage their email address,
|
|
|
|
# their Gravatar just changed, and we need to notify other
|
|
|
|
# clients.
|
|
|
|
notify_avatar_url_change(user_profile)
|
|
|
|
|
|
|
|
if user_profile.email_address_is_realm_public():
|
|
|
|
# Additionally, if we're also changing the publicly visible
|
|
|
|
# email, we send a new_email event as well.
|
|
|
|
send_user_email_update_event(user_profile)
|
|
|
|
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
acting_user=user_profile,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_EMAIL_CHANGED,
|
|
|
|
event_time=event_time,
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def do_start_email_change_process(user_profile: UserProfile, new_email: str) -> None:
|
|
|
|
old_email = user_profile.delivery_email
|
|
|
|
obj = EmailChangeStatus.objects.create(
|
|
|
|
new_email=new_email,
|
|
|
|
old_email=old_email,
|
|
|
|
user_profile=user_profile,
|
|
|
|
realm=user_profile.realm,
|
|
|
|
)
|
|
|
|
|
2023-11-28 18:25:06 +01:00
|
|
|
# Deactivate existing email change requests
|
|
|
|
EmailChangeStatus.objects.filter(realm=user_profile.realm, user_profile=user_profile).exclude(
|
|
|
|
id=obj.id,
|
|
|
|
).update(status=STATUS_REVOKED)
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
activation_url = create_confirmation_link(obj, Confirmation.EMAIL_CHANGE)
|
|
|
|
from zerver.context_processors import common_context
|
|
|
|
|
|
|
|
context = common_context(user_profile)
|
|
|
|
context.update(
|
|
|
|
old_email=old_email,
|
|
|
|
new_email=new_email,
|
|
|
|
activate_url=activation_url,
|
2023-07-25 15:26:02 +02:00
|
|
|
organization_host=user_profile.realm.host,
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
language = user_profile.default_language
|
2023-07-20 21:05:37 +02:00
|
|
|
|
|
|
|
email_template = "zerver/emails/confirm_new_email"
|
|
|
|
|
|
|
|
if old_email == "":
|
|
|
|
# The assertions here are to help document the only circumstance under which
|
|
|
|
# this condition should be possible.
|
|
|
|
assert (
|
|
|
|
user_profile.realm.demo_organization_scheduled_deletion_date is not None
|
|
|
|
and user_profile.is_realm_owner
|
|
|
|
)
|
|
|
|
email_template = "zerver/emails/confirm_demo_organization_email"
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
send_email(
|
2023-07-20 21:05:37 +02:00
|
|
|
template_prefix=email_template,
|
2022-04-14 23:49:26 +02:00
|
|
|
to_emails=[new_email],
|
|
|
|
from_name=FromAddress.security_email_from_name(language=language),
|
|
|
|
from_address=FromAddress.tokenized_no_reply_address(),
|
|
|
|
language=language,
|
|
|
|
context=context,
|
|
|
|
realm=user_profile.realm,
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def do_change_password(user_profile: UserProfile, password: str, commit: bool = True) -> None:
|
|
|
|
user_profile.set_password(password)
|
|
|
|
if commit:
|
|
|
|
user_profile.save(update_fields=["password"])
|
|
|
|
|
|
|
|
# Imported here to prevent import cycles
|
|
|
|
from zproject.backends import RateLimitedAuthenticationByUsername
|
|
|
|
|
|
|
|
RateLimitedAuthenticationByUsername(user_profile.delivery_email).clear_history()
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
acting_user=user_profile,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_PASSWORD_CHANGED,
|
|
|
|
event_time=event_time,
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def do_change_full_name(
|
|
|
|
user_profile: UserProfile, full_name: str, acting_user: Optional[UserProfile]
|
|
|
|
) -> None:
|
|
|
|
old_name = user_profile.full_name
|
|
|
|
user_profile.full_name = full_name
|
|
|
|
user_profile.save(update_fields=["full_name"])
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
acting_user=acting_user,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_FULL_NAME_CHANGED,
|
|
|
|
event_time=event_time,
|
2023-07-13 19:46:06 +02:00
|
|
|
extra_data={RealmAuditLog.OLD_VALUE: old_name, RealmAuditLog.NEW_VALUE: full_name},
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
payload = dict(user_id=user_profile.id, full_name=user_profile.full_name)
|
|
|
|
send_event(
|
|
|
|
user_profile.realm,
|
|
|
|
dict(type="realm_user", op="update", person=payload),
|
2023-10-11 09:34:26 +02:00
|
|
|
get_user_ids_who_can_access_user(user_profile),
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
if user_profile.is_bot:
|
|
|
|
send_event(
|
|
|
|
user_profile.realm,
|
|
|
|
dict(type="realm_bot", op="update", bot=payload),
|
|
|
|
bot_owner_user_ids(user_profile),
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def check_change_full_name(
|
|
|
|
user_profile: UserProfile, full_name_raw: str, acting_user: Optional[UserProfile]
|
|
|
|
) -> str:
|
|
|
|
"""Verifies that the user's proposed full name is valid. The caller
|
|
|
|
is responsible for checking check permissions. Returns the new
|
|
|
|
full name, which may differ from what was passed in (because this
|
|
|
|
function strips whitespace)."""
|
|
|
|
new_full_name = check_full_name(full_name_raw)
|
|
|
|
do_change_full_name(user_profile, new_full_name, acting_user)
|
|
|
|
return new_full_name
|
|
|
|
|
|
|
|
|
|
|
|
def check_change_bot_full_name(
|
|
|
|
user_profile: UserProfile, full_name_raw: str, acting_user: UserProfile
|
|
|
|
) -> None:
|
|
|
|
new_full_name = check_full_name(full_name_raw)
|
|
|
|
|
|
|
|
if new_full_name == user_profile.full_name:
|
|
|
|
# Our web app will try to patch full_name even if the user didn't
|
|
|
|
# modify the name in the form. We just silently ignore those
|
|
|
|
# situations.
|
|
|
|
return
|
|
|
|
|
|
|
|
check_bot_name_available(
|
|
|
|
realm_id=user_profile.realm_id,
|
|
|
|
full_name=new_full_name,
|
|
|
|
)
|
|
|
|
do_change_full_name(user_profile, new_full_name, acting_user)
|
|
|
|
|
|
|
|
|
|
|
|
@transaction.atomic(durable=True)
|
2023-04-24 16:51:02 +02:00
|
|
|
def do_change_tos_version(user_profile: UserProfile, tos_version: Optional[str]) -> None:
|
2022-04-14 23:49:26 +02:00
|
|
|
user_profile.tos_version = tos_version
|
|
|
|
user_profile.save(update_fields=["tos_version"])
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
acting_user=user_profile,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_TERMS_OF_SERVICE_VERSION_CHANGED,
|
|
|
|
event_time=event_time,
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def do_regenerate_api_key(user_profile: UserProfile, acting_user: UserProfile) -> str:
|
|
|
|
old_api_key = user_profile.api_key
|
|
|
|
new_api_key = generate_api_key()
|
|
|
|
user_profile.api_key = new_api_key
|
|
|
|
user_profile.save(update_fields=["api_key"])
|
|
|
|
|
|
|
|
# We need to explicitly delete the old API key from our caches,
|
|
|
|
# because the on-save handler for flushing the UserProfile object
|
|
|
|
# in zerver/lib/cache.py only has access to the new API key.
|
|
|
|
cache_delete(user_profile_by_api_key_cache_key(old_api_key))
|
|
|
|
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
acting_user=acting_user,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_API_KEY_CHANGED,
|
|
|
|
event_time=event_time,
|
|
|
|
)
|
|
|
|
|
|
|
|
if user_profile.is_bot:
|
|
|
|
send_event(
|
|
|
|
user_profile.realm,
|
|
|
|
dict(
|
|
|
|
type="realm_bot",
|
|
|
|
op="update",
|
|
|
|
bot=dict(
|
|
|
|
user_id=user_profile.id,
|
|
|
|
api_key=new_api_key,
|
|
|
|
),
|
|
|
|
),
|
|
|
|
bot_owner_user_ids(user_profile),
|
|
|
|
)
|
|
|
|
|
|
|
|
event = {"type": "clear_push_device_tokens", "user_profile_id": user_profile.id}
|
|
|
|
queue_json_publish("deferred_work", event)
|
|
|
|
|
|
|
|
return new_api_key
|
|
|
|
|
|
|
|
|
2022-08-27 18:42:10 +02:00
|
|
|
def bulk_regenerate_api_keys(user_profile_ids: Iterable[int]) -> None:
|
2022-03-27 22:40:21 +02:00
|
|
|
for user_profile_id in user_profile_ids:
|
|
|
|
user_profile = get_user_profile_by_id(user_profile_id)
|
|
|
|
do_regenerate_api_key(user_profile, user_profile)
|
|
|
|
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
def notify_avatar_url_change(user_profile: UserProfile) -> None:
|
|
|
|
if user_profile.is_bot:
|
|
|
|
bot_event = dict(
|
|
|
|
type="realm_bot",
|
|
|
|
op="update",
|
|
|
|
bot=dict(
|
|
|
|
user_id=user_profile.id,
|
|
|
|
avatar_url=avatar_url(user_profile),
|
|
|
|
),
|
|
|
|
)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
bot_event,
|
|
|
|
bot_owner_user_ids(user_profile),
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
payload = dict(
|
|
|
|
avatar_source=user_profile.avatar_source,
|
|
|
|
avatar_url=avatar_url(user_profile),
|
|
|
|
avatar_url_medium=avatar_url(user_profile, medium=True),
|
|
|
|
avatar_version=user_profile.avatar_version,
|
|
|
|
# Even clients using client_gravatar don't need the email,
|
|
|
|
# since we're sending the URL anyway.
|
|
|
|
user_id=user_profile.id,
|
|
|
|
)
|
|
|
|
|
|
|
|
event = dict(type="realm_user", op="update", person=payload)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
event,
|
2023-10-11 09:34:26 +02:00
|
|
|
get_user_ids_who_can_access_user(user_profile),
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
@transaction.atomic(savepoint=False)
|
|
|
|
def do_change_avatar_fields(
|
|
|
|
user_profile: UserProfile,
|
|
|
|
avatar_source: str,
|
|
|
|
skip_notify: bool = False,
|
|
|
|
*,
|
|
|
|
acting_user: Optional[UserProfile],
|
|
|
|
) -> None:
|
|
|
|
user_profile.avatar_source = avatar_source
|
|
|
|
user_profile.avatar_version += 1
|
|
|
|
user_profile.save(update_fields=["avatar_source", "avatar_version"])
|
|
|
|
event_time = timezone_now()
|
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
modified_user=user_profile,
|
|
|
|
event_type=RealmAuditLog.USER_AVATAR_SOURCE_CHANGED,
|
2023-07-13 19:46:06 +02:00
|
|
|
extra_data={"avatar_source": avatar_source},
|
2022-04-14 23:49:26 +02:00
|
|
|
event_time=event_time,
|
|
|
|
acting_user=acting_user,
|
|
|
|
)
|
|
|
|
|
|
|
|
if not skip_notify:
|
|
|
|
notify_avatar_url_change(user_profile)
|
|
|
|
|
|
|
|
|
|
|
|
def do_delete_avatar_image(user: UserProfile, *, acting_user: Optional[UserProfile]) -> None:
|
|
|
|
do_change_avatar_fields(user, UserProfile.AVATAR_FROM_GRAVATAR, acting_user=acting_user)
|
|
|
|
delete_avatar_image(user)
|
|
|
|
|
|
|
|
|
|
|
|
def update_scheduled_email_notifications_time(
|
|
|
|
user_profile: UserProfile, old_batching_period: int, new_batching_period: int
|
|
|
|
) -> None:
|
|
|
|
existing_scheduled_emails = ScheduledMessageNotificationEmail.objects.filter(
|
|
|
|
user_profile=user_profile
|
|
|
|
)
|
|
|
|
|
|
|
|
scheduled_timestamp_change = datetime.timedelta(
|
|
|
|
seconds=new_batching_period
|
|
|
|
) - datetime.timedelta(seconds=old_batching_period)
|
|
|
|
|
|
|
|
existing_scheduled_emails.update(
|
|
|
|
scheduled_timestamp=F("scheduled_timestamp") + scheduled_timestamp_change
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
@transaction.atomic(durable=True)
|
|
|
|
def do_change_user_setting(
|
|
|
|
user_profile: UserProfile,
|
|
|
|
setting_name: str,
|
|
|
|
setting_value: Union[bool, str, int],
|
|
|
|
*,
|
|
|
|
acting_user: Optional[UserProfile],
|
|
|
|
) -> None:
|
|
|
|
old_value = getattr(user_profile, setting_name)
|
|
|
|
event_time = timezone_now()
|
|
|
|
|
|
|
|
if setting_name == "timezone":
|
|
|
|
assert isinstance(setting_value, str)
|
|
|
|
setting_value = canonicalize_timezone(setting_value)
|
|
|
|
else:
|
|
|
|
property_type = UserProfile.property_types[setting_name]
|
|
|
|
assert isinstance(setting_value, property_type)
|
|
|
|
setattr(user_profile, setting_name, setting_value)
|
|
|
|
|
|
|
|
# TODO: Move these database actions into a transaction.atomic block.
|
|
|
|
user_profile.save(update_fields=[setting_name])
|
|
|
|
|
2023-03-23 13:36:02 +01:00
|
|
|
RealmAuditLog.objects.create(
|
|
|
|
realm=user_profile.realm,
|
|
|
|
event_type=RealmAuditLog.USER_SETTING_CHANGED,
|
|
|
|
event_time=event_time,
|
|
|
|
acting_user=acting_user,
|
|
|
|
modified_user=user_profile,
|
2023-07-13 19:46:06 +02:00
|
|
|
extra_data={
|
|
|
|
RealmAuditLog.OLD_VALUE: old_value,
|
|
|
|
RealmAuditLog.NEW_VALUE: setting_value,
|
|
|
|
"property": setting_name,
|
|
|
|
},
|
2023-03-23 13:36:02 +01:00
|
|
|
)
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
# Disabling digest emails should clear a user's email queue
|
|
|
|
if setting_name == "enable_digest_emails" and not setting_value:
|
|
|
|
clear_scheduled_emails(user_profile.id, ScheduledEmail.DIGEST)
|
|
|
|
|
|
|
|
if setting_name == "email_notifications_batching_period_seconds":
|
|
|
|
assert isinstance(old_value, int)
|
|
|
|
assert isinstance(setting_value, int)
|
|
|
|
update_scheduled_email_notifications_time(user_profile, old_value, setting_value)
|
|
|
|
|
|
|
|
event = {
|
|
|
|
"type": "user_settings",
|
|
|
|
"op": "update",
|
|
|
|
"property": setting_name,
|
|
|
|
"value": setting_value,
|
|
|
|
}
|
|
|
|
if setting_name == "default_language":
|
|
|
|
assert isinstance(setting_value, str)
|
|
|
|
event["language_name"] = get_language_name(setting_value)
|
|
|
|
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(user_profile.realm, event, [user_profile.id])
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
if setting_name in UserProfile.notification_settings_legacy:
|
|
|
|
# This legacy event format is for backwards-compatibility with
|
|
|
|
# clients that don't support the new user_settings event type.
|
|
|
|
# We only send this for settings added before Feature level 89.
|
|
|
|
legacy_event = {
|
|
|
|
"type": "update_global_notifications",
|
|
|
|
"user": user_profile.email,
|
|
|
|
"notification_name": setting_name,
|
|
|
|
"setting": setting_value,
|
|
|
|
}
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(user_profile.realm, legacy_event, [user_profile.id])
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
if setting_name in UserProfile.display_settings_legacy or setting_name == "timezone":
|
|
|
|
# This legacy event format is for backwards-compatibility with
|
|
|
|
# clients that don't support the new user_settings event type.
|
|
|
|
# We only send this for settings added before Feature level 89.
|
|
|
|
legacy_event = {
|
|
|
|
"type": "update_display_settings",
|
|
|
|
"user": user_profile.email,
|
|
|
|
"setting_name": setting_name,
|
|
|
|
"setting": setting_value,
|
|
|
|
}
|
|
|
|
if setting_name == "default_language":
|
|
|
|
assert isinstance(setting_value, str)
|
|
|
|
legacy_event["language_name"] = get_language_name(setting_value)
|
|
|
|
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(user_profile.realm, legacy_event, [user_profile.id])
|
2022-04-14 23:49:26 +02:00
|
|
|
|
|
|
|
# Updates to the time zone display setting are sent to all users
|
|
|
|
if setting_name == "timezone":
|
|
|
|
payload = dict(
|
|
|
|
email=user_profile.email,
|
|
|
|
user_id=user_profile.id,
|
|
|
|
timezone=canonicalize_timezone(user_profile.timezone),
|
|
|
|
)
|
|
|
|
timezone_event = dict(type="realm_user", op="update", person=payload)
|
django_api: Extract send_event_on_commit helper.
django-stubs 4.2.1 gives transaction.on_commit a more accurate type
annotation, but this exposed that mypy can’t handle the lambda default
parameters that we use to recapture loop variables such as
for stream_id in public_stream_ids:
peer_user_ids = …
event = …
transaction.on_commit(
lambda event=event, peer_user_ids=peer_user_ids: send_event(
realm, event, peer_user_ids
)
)
https://github.com/python/mypy/issues/15459
A workaround that mypy accepts is
transaction.on_commit(
(
lambda event, peer_user_ids: lambda: send_event(
realm, event, peer_user_ids
)
)(event, peer_user_ids)
)
But that’s kind of ugly and potentially error-prone, so let’s make a
helper function for this very common pattern.
send_event_on_commit(realm, event, peer_user_ids)
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-06-17 20:53:07 +02:00
|
|
|
send_event_on_commit(
|
|
|
|
user_profile.realm,
|
|
|
|
timezone_event,
|
2023-10-11 09:34:26 +02:00
|
|
|
get_user_ids_who_can_access_user(user_profile),
|
2022-04-14 23:49:26 +02:00
|
|
|
)
|
|
|
|
|
2021-10-26 09:15:16 +02:00
|
|
|
if setting_name == "email_address_visibility":
|
|
|
|
send_delivery_email_update_events(
|
|
|
|
user_profile, old_value, user_profile.email_address_visibility
|
|
|
|
)
|
|
|
|
|
|
|
|
if UserProfile.EMAIL_ADDRESS_VISIBILITY_EVERYONE not in [old_value, setting_value]:
|
|
|
|
# We use real email addresses on UserProfile.email only if
|
|
|
|
# EMAIL_ADDRESS_VISIBILITY_EVERYONE is configured, so
|
|
|
|
# changes between values that will not require changing
|
|
|
|
# that field, so we can save work and return here.
|
|
|
|
return
|
|
|
|
|
|
|
|
user_profile.email = get_display_email_address(user_profile)
|
|
|
|
user_profile.save(update_fields=["email"])
|
|
|
|
|
|
|
|
transaction.on_commit(lambda: flush_user_profile(sender=UserProfile, instance=user_profile))
|
|
|
|
|
|
|
|
send_user_email_update_event(user_profile)
|
|
|
|
notify_avatar_url_change(user_profile)
|
|
|
|
|
2022-04-14 23:49:26 +02:00
|
|
|
if setting_name == "enable_drafts_synchronization" and setting_value is False:
|
|
|
|
# Delete all of the drafts from the backend but don't send delete events
|
|
|
|
# for them since all that's happened is that we stopped syncing changes,
|
|
|
|
# not deleted every previously synced draft - to do that use the DELETE
|
|
|
|
# endpoint.
|
|
|
|
Draft.objects.filter(user_profile=user_profile).delete()
|
2022-08-24 21:42:44 +02:00
|
|
|
|
|
|
|
if setting_name == "presence_enabled":
|
|
|
|
# The presence_enabled setting's primary function is to stop
|
|
|
|
# doing presence updates for the user altogether.
|
|
|
|
#
|
|
|
|
# When a user toggles the presence_enabled setting, we
|
|
|
|
# immediately trigger a presence update, so all users see the
|
|
|
|
# user's current presence state as consistent with the new
|
|
|
|
# setting; not doing so can make it look like the settings
|
|
|
|
# change didn't have any effect.
|
|
|
|
if setting_value:
|
2020-06-11 16:03:47 +02:00
|
|
|
status = UserPresence.LEGACY_STATUS_ACTIVE_INT
|
2022-08-24 21:42:44 +02:00
|
|
|
presence_time = timezone_now()
|
|
|
|
else:
|
|
|
|
# HACK: Remove existing presence data for the current user
|
|
|
|
# when disabling presence. This hack will go away when we
|
|
|
|
# replace our presence data structure with a simpler model
|
|
|
|
# that doesn't separate individual clients.
|
|
|
|
UserPresence.objects.filter(user_profile_id=user_profile.id).delete()
|
|
|
|
|
|
|
|
# We create a single presence entry for the user, old
|
|
|
|
# enough to be guaranteed to be treated as offline by
|
|
|
|
# correct clients, such that the user will, for as long as
|
|
|
|
# presence remains disabled, appear to have been last
|
|
|
|
# online a few minutes before they disabled presence.
|
|
|
|
#
|
|
|
|
# We add a small additional offset as a fudge factor in
|
|
|
|
# case of clock skew.
|
2020-06-11 16:03:47 +02:00
|
|
|
status = UserPresence.LEGACY_STATUS_IDLE_INT
|
2022-08-24 21:42:44 +02:00
|
|
|
presence_time = timezone_now() - datetime.timedelta(
|
|
|
|
seconds=settings.OFFLINE_THRESHOLD_SECS + 120
|
|
|
|
)
|
|
|
|
|
|
|
|
do_update_user_presence(
|
|
|
|
user_profile,
|
|
|
|
get_client("website"),
|
|
|
|
presence_time,
|
|
|
|
status,
|
|
|
|
force_send_update=True,
|
|
|
|
)
|