2017-10-25 17:18:43 +02:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
|
2017-11-03 22:38:43 +01:00
|
|
|
from unittest import mock
|
2018-02-08 15:51:38 +01:00
|
|
|
from mock import patch
|
2018-05-10 19:00:29 +02:00
|
|
|
from typing import Any, Dict, Tuple, Optional
|
2017-10-25 17:18:43 +02:00
|
|
|
|
2018-02-25 20:25:48 +01:00
|
|
|
from zerver.lib.bot_lib import EmbeddedBotQuitException, EmbeddedBotHandler
|
2017-10-25 17:18:43 +02:00
|
|
|
from zerver.lib.test_classes import ZulipTestCase
|
2018-02-25 19:33:49 +01:00
|
|
|
from zerver.models import (
|
|
|
|
UserProfile, Recipient, get_display_recipient,
|
|
|
|
get_service_profile, get_user, get_realm
|
|
|
|
)
|
2017-10-25 17:18:43 +02:00
|
|
|
|
2018-01-30 17:05:14 +01:00
|
|
|
import ujson
|
|
|
|
|
2017-10-25 17:18:43 +02:00
|
|
|
class TestEmbeddedBotMessaging(ZulipTestCase):
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2017-10-25 17:18:43 +02:00
|
|
|
self.user_profile = self.example_user("othello")
|
2018-01-30 17:05:14 +01:00
|
|
|
self.bot_profile = self.create_test_bot('embedded', self.user_profile,
|
|
|
|
full_name='Embedded bot',
|
|
|
|
bot_type=UserProfile.EMBEDDED_BOT,
|
|
|
|
service_name='helloworld',
|
|
|
|
config_data=ujson.dumps({'foo': 'bar'}))
|
2017-10-25 17:18:43 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_pm_to_embedded_bot(self) -> None:
|
2017-10-28 16:31:02 +02:00
|
|
|
self.send_personal_message(self.user_profile.email, self.bot_profile.email,
|
|
|
|
content="help")
|
2017-10-25 17:18:43 +02:00
|
|
|
last_message = self.get_last_message()
|
|
|
|
self.assertEqual(last_message.content, "beep boop")
|
|
|
|
self.assertEqual(last_message.sender_id, self.bot_profile.id)
|
|
|
|
display_recipient = get_display_recipient(last_message.recipient)
|
2018-05-10 19:00:29 +02:00
|
|
|
# The next two lines error on mypy because the display_recipient is of type Union[str, List[Dict[str, Any]]].
|
2017-10-25 17:18:43 +02:00
|
|
|
# In this case, we know that display_recipient will be of type List[Dict[str, Any]].
|
|
|
|
# Otherwise this test will error, which is wanted behavior anyway.
|
|
|
|
self.assert_length(display_recipient, 1) # type: ignore
|
|
|
|
self.assertEqual(display_recipient[0]['email'], self.user_profile.email) # type: ignore
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_stream_message_to_embedded_bot(self) -> None:
|
2017-10-28 16:31:02 +02:00
|
|
|
self.send_stream_message(self.user_profile.email, "Denmark",
|
|
|
|
content="@**{}** foo".format(self.bot_profile.full_name),
|
|
|
|
topic_name="bar")
|
2017-10-25 17:18:43 +02:00
|
|
|
last_message = self.get_last_message()
|
|
|
|
self.assertEqual(last_message.content, "beep boop")
|
|
|
|
self.assertEqual(last_message.sender_id, self.bot_profile.id)
|
|
|
|
self.assertEqual(last_message.subject, "bar")
|
|
|
|
display_recipient = get_display_recipient(last_message.recipient)
|
|
|
|
self.assertEqual(display_recipient, "Denmark")
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_stream_message_not_to_embedded_bot(self) -> None:
|
2017-10-28 16:31:02 +02:00
|
|
|
self.send_stream_message(self.user_profile.email, "Denmark",
|
|
|
|
content="foo", topic_name="bar")
|
2017-10-25 17:18:43 +02:00
|
|
|
last_message = self.get_last_message()
|
|
|
|
self.assertEqual(last_message.content, "foo")
|
2017-11-03 21:08:34 +01:00
|
|
|
|
2018-02-25 20:25:48 +01:00
|
|
|
def test_message_to_embedded_bot_with_initialize(self) -> None:
|
|
|
|
with patch('zulip_bots.bots.helloworld.helloworld.HelloWorldHandler.initialize',
|
|
|
|
create=True) as mock_initialize:
|
|
|
|
self.send_stream_message(self.user_profile.email, "Denmark",
|
|
|
|
content="@**{}** foo".format(self.bot_profile.full_name),
|
|
|
|
topic_name="bar")
|
|
|
|
mock_initialize.assert_called_once()
|
|
|
|
|
2018-02-08 15:51:38 +01:00
|
|
|
def test_embedded_bot_quit_exception(self) -> None:
|
|
|
|
with patch('zulip_bots.bots.helloworld.helloworld.HelloWorldHandler.handle_message',
|
|
|
|
side_effect=EmbeddedBotQuitException("I'm quitting!")):
|
|
|
|
with patch('logging.warning') as mock_logging:
|
|
|
|
self.send_stream_message(self.user_profile.email, "Denmark",
|
|
|
|
content="@**{}** foo".format(self.bot_profile.full_name),
|
|
|
|
topic_name="bar")
|
|
|
|
mock_logging.assert_called_once_with("I'm quitting!")
|
|
|
|
|
2017-11-03 21:08:34 +01:00
|
|
|
class TestEmbeddedBotFailures(ZulipTestCase):
|
2018-02-25 19:33:49 +01:00
|
|
|
def test_message_embedded_bot_with_invalid_service(self) -> None:
|
2017-11-03 21:08:34 +01:00
|
|
|
user_profile = self.example_user("othello")
|
2018-01-30 17:05:14 +01:00
|
|
|
self.create_test_bot(short_name='embedded', user_profile=user_profile,
|
|
|
|
bot_type=UserProfile.EMBEDDED_BOT,
|
2018-02-25 19:33:49 +01:00
|
|
|
service_name='helloworld')
|
|
|
|
bot_profile = get_user("embedded-bot@zulip.testserver",
|
|
|
|
get_realm('zulip'))
|
|
|
|
service_profile = get_service_profile(bot_profile.id, 'helloworld')
|
|
|
|
service_profile.name = 'invalid'
|
|
|
|
service_profile.save()
|
|
|
|
with patch('logging.error') as logging_error_mock:
|
|
|
|
self.send_stream_message(user_profile.email, "Denmark",
|
|
|
|
content="@**{}** foo".format(bot_profile.full_name),
|
|
|
|
topic_name="bar")
|
|
|
|
logging_error_mock.assert_called_once_with(
|
|
|
|
"Error: User {} has bot with invalid embedded bot service invalid".format(bot_profile.id))
|