Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/.eslintrc.json

353 lines
13 KiB
JSON
Raw Normal View History

Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
{
"env": {
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
"node": true,
"es6": true
},
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"extends": [
eslint: Disable syntax rules handled by Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:09:31 +02:00
"eslint:recommended",
"prettier"
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
],
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
"parserOptions": {
people: Use Unicode normalization for diacritic removal. Fixes #13481. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-12-07 02:51:48 +01:00
"ecmaVersion": 2019,
eslint: Turn off warning from eslint about using unsupported typescript. We are mostly fine using newer versions of typescript since they work fine; eslint just warns since it doesn't test against it.
2019-06-04 02:49:59 +02:00
"warnOnUnsupportedTypeScriptVersion": false,
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
"sourceType": "module"
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
},
lint: Replace 'return undefined;' with 'return;'. Also adds a custom rule to eslint. Since the recommended way of extending eslint is to create plugins as standalone npm packages, the separate rule is published as 'eslint-plugins-empty-returns'. Fixes #8669.
2018-03-13 13:04:16 +01:00
"plugins": [
"eslint-plugin-empty-returns"
],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"rules": {
eslint: change array-callback-return from warning to error.
2016-12-05 07:53:36 +01:00
"array-callback-return": "error",
eslint: Enable arrow-body-style. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:41:40 +02:00
"arrow-body-style": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"block-scoped-var": "error",
"curly": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"dot-notation": "error",
lint: Replace 'return undefined;' with 'return;'. Also adds a custom rule to eslint. Since the recommended way of extending eslint is to create plugins as standalone npm packages, the separate rule is published as 'eslint-plugins-empty-returns'. Fixes #8669.
2018-03-13 13:04:16 +01:00
"empty-returns/main": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"eqeqeq": "error",
"guard-for-in": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"new-cap": [ "error",
{
"capIsNew": false
}
],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-alert": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-array-constructor": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-bitwise": "error",
"no-caller": "error",
"no-catch-shadow": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"no-constant-condition": ["error", {"checkLoops": false}],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-div-regex": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-duplicate-imports": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-else-return": "error",
"no-eq-null": "error",
"no-eval": "error",
"no-implied-eval": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"no-inner-declarations": "off",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-iterator": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-label-var": "error",
"no-labels": "error",
"no-loop-func": "error",
"no-multi-str": "error",
"no-native-reassign": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-new-func": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-new-object": "error",
"no-new-wrappers": "error",
"no-octal-escape": "error",
"no-plusplus": "error",
"no-proto": "error",
"no-return-assign": "error",
"no-script-url": "error",
"no-self-compare": "error",
"no-sync": "error",
"no-undef-init": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-unneeded-ternary": [ "error", { "defaultAssignment": false } ],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-unused-expressions": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-unused-vars": [ "error",
{
"vars": "local",
"varsIgnorePattern": "print_elapsed_time|check_duplicate_ids"
}
],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-use-before-define": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-useless-constructor": "error",
js: Automatically convert var to let and const in remaining files. This commit was automatically generated by `tools/lint --only=eslint --fix`, except for the `.eslintrc.json` change itself. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
"no-var": "error",
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
"object-shorthand": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"one-var": [ "error", "never" ],
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
"prefer-arrow-callback": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"prefer-const": [ "error",
{
"ignoreReadBeforeAssign": true
}
],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"radix": "error",
eslint: Enable sort-imports rule. I figure we should enable this before we have lots of imports. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-10-30 20:13:53 +01:00
"sort-imports": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"spaced-comment": "off",
"strict": "off",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"valid-typeof": [ "error", { "requireStringLiterals": true } ],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"yoda": "error"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
},
"overrides": [
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
{
"files": [
"frontend_tests/**/*.{js,ts}",
"static/js/**/*.{js,ts}"
],
"globals": {
"$": false,
"ClipboardJS": false,
"FetchStatus": false,
"Filter": false,
"Handlebars": false,
"LightboxCanvas": false,
"MessageListData": false,
"MessageListView": false,
"Plotly": false,
"Sortable": false,
"WinChan": false,
"XDate": false,
"_": false,
"activity": false,
"admin": false,
"alert_words": false,
"alert_words_ui": false,
"attachments_ui": false,
"avatar": false,
"billing": false,
"blueslip": false,
"bot_data": false,
"bridge": false,
"buddy_data": false,
"buddy_list": false,
"channel": false,
"click_handlers": false,
"color_data": false,
"colorspace": false,
"common": false,
"components": false,
"compose": false,
"compose_actions": false,
"compose_fade": false,
"compose_pm_pill": false,
"compose_state": false,
"compose_ui": false,
"composebox_typeahead": false,
"condense": false,
"confirm_dialog": false,
"copy_and_paste": false,
"csrf_token": false,
"current_msg_list": true,
"drafts": false,
list-widget: Rename settings_list_widget => dropdown_list_widget. We want to use this widget outside of the settings panels as well.
2020-05-12 20:44:05 +02:00
"dropdown_list_widget": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"echo": false,
"emoji": false,
"emoji_picker": false,
"favicon": false,
"feature_flags": false,
"feedback_widget": false,
"fenced_code": false,
"flatpickr": false,
"floating_recipient_bar": false,
"gear_menu": false,
"hash_util": false,
"hashchange": false,
"helpers": false,
"history": false,
"home_msg_list": false,
"hotspots": false,
"i18n": false,
"info_overlay": false,
"input_pill": false,
"invite": false,
"jQuery": false,
"katex": false,
"keydown_util": false,
"lightbox": false,
"list_cursor": false,
"list_render": false,
"list_util": false,
"loading": false,
"localStorage": false,
"local_message": false,
"localstorage": false,
"location": false,
"markdown": false,
"marked": false,
"md5": false,
"message_edit": false,
js: Extract message_edit_history.js.
2020-06-07 04:50:31 +02:00
"message_edit_history": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"message_events": false,
"message_fetch": false,
"message_flags": false,
"message_list": false,
"message_live_update": false,
"message_scroll": false,
"message_store": false,
"message_util": false,
"message_viewport": false,
"moment": false,
"muting": false,
"muting_ui": false,
"narrow": false,
"narrow_state": false,
"navigate": false,
"night_mode": false,
"notifications": false,
"overlays": false,
"padded_widget": false,
"page_params": false,
"panels": false,
"people": false,
"pm_conversations": false,
"pm_list": false,
"pm_list_dom": false,
"pointer": false,
"popovers": false,
"presence": false,
"reactions": false,
"realm_icon": false,
"realm_logo": false,
"realm_night_logo": false,
"recent_senders": false,
recent-topics: Add module. Add methods to extract recent topics from received messages. Process new messages as they are received. Use new messages received from the server to extract recent_topics. Node tests added.
2020-03-21 14:42:10 +01:00
"recent_topics": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"reload": false,
"reload_state": false,
"reminder": false,
"resize": false,
"rows": false,
"rtl": false,
"run_test": false,
"schema": false,
"scroll_bar": false,
"scroll_util": false,
"search": false,
"search_pill": false,
"search_pill_widget": false,
"search_suggestion": false,
"search_util": false,
"sent_messages": false,
"server_events": false,
"server_events_dispatch": false,
"settings": false,
"settings_account": false,
"settings_bots": false,
"settings_display": false,
"settings_emoji": false,
"settings_exports": false,
"settings_linkifiers": false,
"settings_invites": false,
"settings_muting": false,
"settings_notifications": false,
"settings_org": false,
"settings_panel_menu": false,
"settings_profile_fields": false,
"settings_sections": false,
"settings_streams": false,
"settings_toggle": false,
"settings_ui": false,
"settings_user_groups": false,
"settings_users": false,
markdown: Add support for spoilers. This adds support for a "spoiler" syntax in Zulip's markdown, which can be used to hide content that one doesn't want to be immediately visible without a click. We use our own spoiler block syntax inspired by Zulip's existing quote and math block markdown extensions, rather than requiring a token on every line, as is present in some other markdown spoiler implementations. Fixes #5802. Co-authored-by: Dylan Nugent <dylnuge@gmail.com>
2020-04-04 22:14:34 +02:00
"spoilers": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"starred_messages": false,
"stream_color": false,
"stream_create": false,
"stream_data": false,
"stream_edit": false,
"stream_events": false,
topic_data: Rename `topic_data` module to `stream_topic_history`. `stream_topic_history` is a more appropriate name as this module will contain information about last message of a stream in upcoming commits. Function and variable names are changed accordingly like: * topic_history() -> per_stream_history() * get_recent_names() -> get_recent_topic_names() * name -> topic_name
2020-03-22 18:40:05 +01:00
"stream_topic_history": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"stream_list": false,
"stream_muting": false,
"stream_popover": false,
"stream_sort": false,
"stream_ui_updates": false,
"StripeCheckout": false,
"submessage": false,
"subs": false,
"tab_bar": false,
"templates": false,
"tictactoe_widget": false,
"timerender": false,
"todo_widget": false,
"top_left_corner": false,
"topic_generator": false,
"topic_list": false,
"topic_zoom": false,
"transmit": false,
"tutorial": false,
"typeahead_helper": false,
"typing": false,
"typing_data": false,
"typing_events": false,
"ui": false,
"ui_init": false,
"ui_report": false,
"ui_util": false,
"unread": false,
"unread_ops": false,
"unread_ui": false,
"upgrade": false,
"upload": false,
"upload_widget": false,
"user_events": false,
"user_groups": false,
"user_pill": false,
"user_search": false,
"user_status": false,
"user_status_ui": false,
"poll_widget": false,
"vdom": false,
"widgetize": false,
"zcommand": false,
"zform": false,
"zxcvbn": false
}
},
js: Automatically convert var to let and const in remaining files. This commit was automatically generated by `tools/lint --only=eslint --fix`, except for the `.eslintrc.json` change itself. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
{
"files": [
"frontend_tests/casper_tests/*.js",
"frontend_tests/casper_lib/*.js"
],
"rules": {
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
// Don’t require ES features that PhantomJS doesn’t support
"no-var": "off",
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
"object-shorthand": "off",
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
"prefer-arrow-callback": "off"
js: Automatically convert var to let and const in remaining files. This commit was automatically generated by `tools/lint --only=eslint --fix`, except for the `.eslintrc.json` change itself. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
}
},
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
{
"files": ["**/*.ts"],
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"extends": [
eslint: Disable syntax rules handled by Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:09:31 +02:00
"plugin:@typescript-eslint/recommended",
"prettier/@typescript-eslint"
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
],
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
"parserOptions": {
tsconfig: Move to top level. This way, webpack.config.ts is type checked. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-04 23:37:32 +01:00
"project": "tsconfig.json"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
},
"rules": {
dependencies: Upgrade @typescript-eslint/eslint-plugin to 1.9.0. Updated .eslintrc with new rules.
2019-05-31 07:15:00 +02:00
// Disable base rule to avoid conflict
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"empty-returns/main": "off",
"no-unused-vars": "off",
blueslip: Make stack trace more readable. The stack trace popup is now sourcemapped and each stackframe have a expandable code context window. [anders@zulipchat.com: Rebased and simplified.]
2019-06-20 11:59:55 +02:00
"no-useless-constructor": "off",
ESLint: Modify recommended typescript rules to fit our use case.
2019-03-25 15:35:44 +01:00
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/array-type": "error",
"@typescript-eslint/await-thenable": "error",
dependencies: Upgrade eslint from 6.0.1 to 6.6.0. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-09 02:48:01 +01:00
"@typescript-eslint/consistent-type-assertions": "error",
dependencies: Upgrade @typescript-eslint/eslint-plugin to 1.9.0. Updated .eslintrc with new rules.
2019-05-31 07:15:00 +02:00
"@typescript-eslint/explicit-function-return-type": ["error", { "allowExpressions": true }],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/member-ordering": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"@typescript-eslint/no-explicit-any": "off",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-extraneous-class": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"@typescript-eslint/no-non-null-assertion": "off",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-parameter-properties": "error",
"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
eslint: Allow unused variables with _ prefix in typescript.
2019-06-03 06:18:20 +02:00
"@typescript-eslint/no-unused-vars": ["error", { "varsIgnorePattern": "^_" } ],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-use-before-define": "error",
"@typescript-eslint/no-useless-constructor": "error",
"@typescript-eslint/prefer-includes": "error",
"@typescript-eslint/prefer-regexp-exec": "error",
"@typescript-eslint/prefer-string-starts-ends-with": "error",
"@typescript-eslint/promise-function-async": "error",
"@typescript-eslint/unified-signatures": "error"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
}
}
]
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
}