Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/edit_bot.handlebars

37 lines
2.0 KiB
Handlebars
Raw Normal View History

static/templates/edit_bot.handlebars: Fix undefined bot_id. Template was rendering undefined value of `bot_id` instead of `user_id`. Fix this by replacing `bot_id` with `user_id` and changing template data variable to `data-user-id` to avoid future confusion.
2018-05-15 15:30:13 +02:00
<form class="edit_bot_form form-horizontal" data-target="edit-bot" data-title="{{t 'Edit bot' }}" data-user-id="{{bot.user_id}}"
linter: Enforce 2 space indents on tags spread over multiple lines. We make some specific cases of tags use 2 space indents. The case description: * A tag with opening tag spread over multiple lines and closing tag on the same line as of the closing angle bracket of the opening tag. * A tag with opening tag spread over multiple lines and closing tag not on the same line as of the closing angle bracket of the opening tag. Example: Case 1: Not linted: <button type="button" class="btn btn-primary btn-small">{{t "Yes" }}</button> After linting: <button type="button" class="btn btn-primary btn-small">{{t "Yes" }}</button> Case 2: Before linting: <div class = "foo" id = "bar" role = "whatever"> {{ bla }} </div> After linting: <div class = "foo" id = "bar" role = "whatever"> {{ bla }} </div>
2018-04-05 08:38:46 +02:00
data-email="{{bot.email}}" data-type="{{bot.bot_type}}">
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
<div class="bot_edit_errors alert alert-error hide"></div>
<div class="">
<label>{{t "Bot email" }}</label>
settings_bots.js: Clean up bot edit event handler. This is done by rewriting JS manipulations of the DOM tree in the bot-settings.handlebars template. Dead code involving the affected JS variables is removed.
2018-02-07 12:37:05 +01:00
<div class="edit_bot_email">{{bot.email}}</div>
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
</div>
<div class="edit-bot-form-box">
<div class="">
<label for="edit_bot_name">{{t "Full name" }}</label>
settings_bots.js: Clean up bot edit event handler. This is done by rewriting JS manipulations of the DOM tree in the bot-settings.handlebars template. Dead code involving the affected JS variables is removed.
2018-02-07 12:37:05 +01:00
<input id="edit_bot_name" type="text" name="bot_name" class="edit_bot_name required" value="{{bot.full_name}}" maxlength=50 />
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
<div><label for="edit_bot_name" generated="true" class="text-error"></label></div>
</div>
<div class="edit-bot-owner">
<label for="bot_owner_select">{{t "Owner" }}</label>
settings-bots.js: Fully generate bot owner list in handlebars.
2018-02-07 15:58:53 +01:00
<div class="select-form">
{{partial "bot_owner_select" }}
</div>
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
</div>
<div id="service_data">
</div>
<div class="avatar-section">
<label for="bot_avatar_file_input">Avatar</label>
settings: Rename "user avatar" to "profile picture" This renames references to user avatars, bot avatars, or organization icons to profile pictures. The string in the UI are updated, in addition to the help files, comments, and documentation. Actual variable/function names, changelog entries, routes, and s3 buckets are left as-is in order to avoid introducing bugs. Fixes #11824.
2019-03-09 17:43:48 +01:00
<input type="file" name="bot_avatar_file_input" class="notvisible edit_bot_avatar_file_input" value="{{t 'Upload profile picture' }}" />
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
<div class="edit_bot_avatar_file"></div>
<button type="button" class="btn btn-default edit_bot_avatar_upload_button">{{t "Choose avatar" }}</button>
css: Remove `display-none` class css entirely. All the elements to which `display-none` class is applied, are handled with `.show()`/`.hide()` functions instead of `.addClass('display-none')` and `.removeClass('display-none')`. Therefore, we should use apply `display: none;` to elements with `style` attribute. This commits removes all usage of `display-none`.
2019-05-08 07:44:37 +02:00
<button type="button" class="btn btn-default edit_bot_avatar_clear_button" style="display: none;">{{t "Clear profile picture" }}</button>
settings sidebar: Extract bot edit form. This is the first step in cleaning up the bot edit code. Since the bot edit form appears dynamically, we remove it from the static HTML scaffold, of which settings_sidebar is a part of.
2018-02-07 10:34:52 +01:00
<div><label for="edit_bot_avatar_file" generated="true" class="edit_bot_avatar_error text-error"></label></div>
</div>
<div class="buttons">
<input type="submit" class="btn btn-primary edit_bot_button" value="{{t 'Save' }}" />
<button type="button" class="btn btn-default reset_edit_bot" data-sidebar-form-close>{{t 'Cancel' }}</button>
<div class="edit_bot_spinner"></div>
</div>
</div>
</form>