Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/stream_settings/stream_privacy_setting_moda...

17 lines
911 B
Handlebars
Raw Normal View History

streams: Improve 'is-announcement-only' checkbox.
2018-05-31 19:27:33 +02:00
<div id="stream_privacy_modal" class="modal modal-bg hide fade new-style" tabindex="-1" role="dialog" aria-labelledby="stream_privacy_modal_label" aria-hidden="true">
subscriptions: Add a modal for changing stream privacy. Change the remaining "Admin settings" with a button, namely changing a stream's privacy, to instead be a "[Change]" link opening a confirmation modal. Fixes: #3493.
2017-02-24 00:46:42 +01:00
<div class="modal-header">
stream_edit: Rename class of cancel btn in stream-privacy modal. This commit renames the class of both cancel button and the cross icon to close-modal-btn. This change is a prep commit for enabling background events on 'hidden.bs.modal' event. As we would enable background events in furhter commit using the 'hidden.bs.modal' event, we would need to remove the 'hide.bs.modal' event of deactivation_stream_modal which removes the modal element from DOM. When we remove this we would need a e.stopPropagation call to avoid unexpected closing of subscription settings, which was not a problem before as the element was removed from DOM before the actual closing of modal. So instead of adding a separate `e.stopPropagation' call, we can use the same handler that is being used for stream privacy modal and this is the reason the class name of cancel button of privacy modal is being changed.
2021-03-27 19:51:03 +01:00
<button type="button" class="close close-modal-btn" data-dismiss="modal" aria-label="{{t 'Close' }}"><span aria-hidden="true">&times;</span></button>
i18n: Fix translation tags in subscription_stream_privacy modal.
2021-06-17 22:07:32 +02:00
<h3 id="stream_privacy_modal_label">{{#tr}}Change stream permissions for #{stream_name}{{/tr}}<span class="email"></span></h3>
subscriptions: Add a modal for changing stream privacy. Change the remaining "Admin settings" with a button, namely changing a stream's privacy, to instead be a "[Change]" link opening a confirmation modal. Fixes: #3493.
2017-02-24 00:46:42 +01:00
</div>
streams: Use consistent settings HTML structure in stream types modal. We had our input elements for stream settings inside li tags and their alignment was managed using CSS. We move away from this HTML structure to have inputs and labels inside divs for two reasons. First is that if we want to later refactor the HTML to have some different design, then having them inside `ul` requires complex changes to CSS and eventually we would have to move away from using `li`s for the part that is changed to have a different design. Second `li`s are generally not used to organize input elements. Above is an explanation of why this change is a preparatory commit for shifting to have a tabbed design in the stream edit page. So following changes are done to have a more consistent HTML structure in stream types modal: * Added modal-body and removed the non-standard usage of the unordered list for settings header and inputs. * Updated relevant CSS rules to have the same design during refactor. Co-authored-by: Pragati Agrawal <pragati22066@gmail.com>
2021-06-17 21:25:47 +02:00
<div class="modal-body">
stream settings: Move stream_types.hbs to stream_settings folder.
2021-07-19 06:14:30 +02:00
{{> stream_types }}
streams: Use consistent settings HTML structure in stream types modal. We had our input elements for stream settings inside li tags and their alignment was managed using CSS. We move away from this HTML structure to have inputs and labels inside divs for two reasons. First is that if we want to later refactor the HTML to have some different design, then having them inside `ul` requires complex changes to CSS and eventually we would have to move away from using `li`s for the part that is changed to have a different design. Second `li`s are generally not used to organize input elements. Above is an explanation of why this change is a preparatory commit for shifting to have a tabbed design in the stream edit page. So following changes are done to have a more consistent HTML structure in stream types modal: * Added modal-body and removed the non-standard usage of the unordered list for settings header and inputs. * Updated relevant CSS rules to have the same design during refactor. Co-authored-by: Pragati Agrawal <pragati22066@gmail.com>
2021-06-17 21:25:47 +02:00
</div>
subscriptions: Add a modal for changing stream privacy. Change the remaining "Admin settings" with a button, namely changing a stream's privacy, to instead be a "[Change]" link opening a confirmation modal. Fixes: #3493.
2017-02-24 00:46:42 +01:00
<div class="modal-footer">
stream_edit: Rename class of cancel btn in stream-privacy modal. This commit renames the class of both cancel button and the cross icon to close-modal-btn. This change is a prep commit for enabling background events on 'hidden.bs.modal' event. As we would enable background events in furhter commit using the 'hidden.bs.modal' event, we would need to remove the 'hide.bs.modal' event of deactivation_stream_modal which removes the modal element from DOM. When we remove this we would need a e.stopPropagation call to avoid unexpected closing of subscription settings, which was not a problem before as the element was removed from DOM before the actual closing of modal. So instead of adding a separate `e.stopPropagation' call, we can use the same handler that is being used for stream privacy modal and this is the reason the class name of cancel button of privacy modal is being changed.
2021-03-27 19:51:03 +01:00
<button class="button rounded close-modal-btn" data-dismiss="modal">{{t "Cancel" }}</button>
streams: Improve 'is-announcement-only' checkbox.
2018-05-31 19:27:33 +02:00
<button class="button rounded btn-danger" id="change-stream-privacy-button"
linter: Enforce 2 space indents on tags spread over multiple lines. We make some specific cases of tags use 2 space indents. The case description: * A tag with opening tag spread over multiple lines and closing tag on the same line as of the closing angle bracket of the opening tag. * A tag with opening tag spread over multiple lines and closing tag not on the same line as of the closing angle bracket of the opening tag. Example: Case 1: Not linted: <button type="button" class="btn btn-primary btn-small">{{t "Yes" }}</button> After linting: <button type="button" class="btn btn-primary btn-small">{{t "Yes" }}</button> Case 2: Before linting: <div class = "foo" id = "bar" role = "whatever"> {{ bla }} </div> After linting: <div class = "foo" id = "bar" role = "whatever"> {{ bla }} </div>
2018-04-05 08:38:46 +02:00
tabindex="-1" data-stream-id="{{stream_id}}">
streams: Change stream-privacy-model save button text to `Save changes`.
2018-05-30 21:51:55 +02:00
{{t "Save changes"}}
subscriptions: Add a modal for changing stream privacy. Change the remaining "Admin settings" with a button, namely changing a stream's privacy, to instead be a "[Change]" link opening a confirmation modal. Fixes: #3493.
2017-02-24 00:46:42 +01:00
</button>
</div>
</div>