2013-07-30 23:02:10 +02:00
|
|
|
// Unit test the search_suggestion.js module.
|
2013-07-28 23:05:01 +02:00
|
|
|
//
|
|
|
|
// These tests are framework-free and run sequentially; they are invoked
|
|
|
|
// immediately after being defined. The contract here is that tests should
|
|
|
|
// clean up after themselves, and they should explicitly stub all
|
|
|
|
// dependencies.
|
|
|
|
|
2013-08-21 20:27:14 +02:00
|
|
|
add_dependencies({
|
|
|
|
util: 'js/util.js',
|
|
|
|
Handlebars: 'handlebars',
|
|
|
|
Filter: 'js/filter.js',
|
|
|
|
typeahead_helper: 'js/typeahead_helper.js',
|
|
|
|
stream_data: 'js/stream_data.js',
|
|
|
|
narrow: 'js/narrow.js'
|
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-22 00:01:14 +02:00
|
|
|
var search = require('js/search_suggestion.js');
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2014-03-04 22:52:13 +01:00
|
|
|
set_global('feature_flags', {
|
|
|
|
negated_search: true
|
|
|
|
});
|
2013-08-22 00:01:14 +02:00
|
|
|
set_global('page_params', {
|
|
|
|
email: 'bob@zulip.com'
|
|
|
|
});
|
|
|
|
set_global('recent_subjects', new global.Dict({fold_case: true}));
|
2013-08-20 18:45:09 +02:00
|
|
|
|
2013-08-22 00:01:14 +02:00
|
|
|
var stream_data = require('js/stream_data.js');
|
|
|
|
set_global('stream_data', {
|
|
|
|
get_name: stream_data.get_name
|
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-22 01:29:28 +02:00
|
|
|
set_global('narrow', {});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
|
|
|
(function test_basic_get_suggestions() {
|
|
|
|
var query = 'fred';
|
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return 'office';
|
|
|
|
};
|
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
2013-08-05 18:35:46 +02:00
|
|
|
'fred'
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-28 23:05:01 +02:00
|
|
|
}());
|
|
|
|
|
2013-08-28 01:23:42 +02:00
|
|
|
(function test_subset_suggestions() {
|
|
|
|
var query = 'stream:Denmark topic:Hamlet shakespeare';
|
|
|
|
|
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return undefined;
|
|
|
|
};
|
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
|
|
|
"stream:Denmark topic:Hamlet shakespeare",
|
|
|
|
"stream:Denmark topic:Hamlet",
|
|
|
|
"stream:Denmark"
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
}());
|
|
|
|
|
2013-08-28 01:45:39 +02:00
|
|
|
(function test_private_suggestions() {
|
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return undefined;
|
|
|
|
};
|
|
|
|
|
|
|
|
global.page_params.people_list = [
|
|
|
|
{
|
|
|
|
email: 'ted@zulip.com',
|
|
|
|
full_name: 'Ted Smith'
|
|
|
|
},
|
|
|
|
{
|
|
|
|
email: 'alice@zulip.com',
|
|
|
|
full_name: 'Alice Ignore'
|
|
|
|
}
|
|
|
|
];
|
|
|
|
|
|
|
|
var query = 'is:private';
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
var expected = [
|
|
|
|
"is:private",
|
|
|
|
"pm-with:alice@zulip.com",
|
|
|
|
"pm-with:ted@zulip.com"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2014-01-21 20:53:52 +01:00
|
|
|
query = 'is:private al';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"is:private al",
|
|
|
|
"pm-with:alice@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'pm-with:t';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"pm-with:t",
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2014-03-04 23:22:15 +01:00
|
|
|
query = '-pm-with:t';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"-pm-with:t",
|
|
|
|
"is:private -pm-with:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-08-28 01:45:39 +02:00
|
|
|
query = 'pm-with:ted@zulip.com';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'sender:ted';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"sender:ted",
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'sender:te';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"sender:te",
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2014-03-04 23:22:15 +01:00
|
|
|
query = '-sender:te';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"-sender:te",
|
|
|
|
"is:private -sender:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'sender:ted@zulip.com';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-08-28 01:45:39 +02:00
|
|
|
// Users can enter bizarre queries, and if they do, we want to
|
|
|
|
// be conservative with suggestions.
|
|
|
|
query = 'is:private near:3';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"is:private near:3",
|
|
|
|
"is:private"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'pm-with:ted@zulip.com near:3';
|
|
|
|
suggestions = search.get_suggestions(query);
|
|
|
|
expected = [
|
|
|
|
"pm-with:ted@zulip.com near:3",
|
|
|
|
"pm-with:ted@zulip.com"
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
global.page_params.people_list = [];
|
|
|
|
}());
|
|
|
|
|
2013-07-28 23:05:01 +02:00
|
|
|
(function test_empty_query_suggestions() {
|
|
|
|
var query = '';
|
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return ['devel', 'office'];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return undefined;
|
|
|
|
};
|
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
|
|
|
"",
|
|
|
|
"in:all",
|
|
|
|
"is:private",
|
|
|
|
"is:starred",
|
|
|
|
"is:mentioned",
|
2013-08-30 21:15:01 +02:00
|
|
|
"is:alerted",
|
2013-07-28 23:05:01 +02:00
|
|
|
"sender:bob@zulip.com",
|
|
|
|
"stream:devel",
|
|
|
|
"stream:office"
|
|
|
|
];
|
|
|
|
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-30 22:39:32 +02:00
|
|
|
|
|
|
|
function describe(q) {
|
|
|
|
return suggestions.lookup_table[q].description;
|
|
|
|
}
|
|
|
|
assert.equal(describe('in:all'), 'All messages');
|
|
|
|
assert.equal(describe('is:private'), 'Private messages');
|
|
|
|
assert.equal(describe('is:starred'), 'Starred messages');
|
|
|
|
assert.equal(describe('is:mentioned'), '@-mentions');
|
2013-08-30 21:15:01 +02:00
|
|
|
assert.equal(describe('is:alerted'), 'Alerted messages');
|
2013-07-30 22:39:32 +02:00
|
|
|
assert.equal(describe('sender:bob@zulip.com'), 'Sent by me');
|
|
|
|
assert.equal(describe('stream:devel'), 'Narrow to stream <strong>devel</strong>');
|
2013-07-28 23:05:01 +02:00
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_topic_suggestions() {
|
2014-02-20 17:29:14 +01:00
|
|
|
var suggestions;
|
|
|
|
var expected;
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return ['office'];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return 'office';
|
|
|
|
};
|
|
|
|
|
2013-08-19 20:46:27 +02:00
|
|
|
global.recent_subjects = new global.Dict.from({
|
2014-02-20 17:29:14 +01:00
|
|
|
'devel': [
|
|
|
|
{subject: 'REXX'}
|
|
|
|
],
|
|
|
|
'office': [
|
2013-07-28 23:05:01 +02:00
|
|
|
{subject: 'team'},
|
|
|
|
{subject: 'ignore'},
|
|
|
|
{subject: 'test'}
|
|
|
|
]
|
2013-08-19 21:17:10 +02:00
|
|
|
}, {fold_case: true});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2014-02-20 17:29:14 +01:00
|
|
|
suggestions = search.get_suggestions('te');
|
|
|
|
expected = [
|
2013-07-28 23:05:01 +02:00
|
|
|
"te",
|
|
|
|
"stream:office topic:team",
|
2013-08-05 18:35:46 +02:00
|
|
|
"stream:office topic:test"
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-30 22:39:32 +02:00
|
|
|
|
|
|
|
function describe(q) {
|
|
|
|
return suggestions.lookup_table[q].description;
|
|
|
|
}
|
|
|
|
assert.equal(describe('te'), "Search for te");
|
|
|
|
assert.equal(describe('stream:office topic:team'), "Narrow to office > team");
|
|
|
|
|
2014-02-20 17:29:14 +01:00
|
|
|
suggestions = search.get_suggestions('topic:staplers stream:office');
|
|
|
|
expected = [
|
|
|
|
'topic:staplers stream:office',
|
|
|
|
'topic:staplers'
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
suggestions = search.get_suggestions('stream:devel topic:');
|
|
|
|
expected = [
|
|
|
|
'stream:devel topic:',
|
|
|
|
'stream:devel topic:REXX',
|
|
|
|
'stream:devel'
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2014-03-04 22:52:13 +01:00
|
|
|
|
|
|
|
suggestions = search.get_suggestions('stream:devel -topic:');
|
|
|
|
expected = [
|
|
|
|
'stream:devel -topic:',
|
|
|
|
'stream:devel -topic:REXX',
|
|
|
|
'stream:devel'
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
suggestions = search.get_suggestions('-topic:te');
|
|
|
|
expected = [
|
|
|
|
'-topic:te',
|
|
|
|
'stream:office -topic:team',
|
|
|
|
'stream:office -topic:test'
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-28 23:05:01 +02:00
|
|
|
}());
|
|
|
|
|
2013-08-06 19:08:39 +02:00
|
|
|
(function test_whitespace_glitch() {
|
|
|
|
var query = 'stream:office '; // note trailing space
|
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-08-06 19:08:39 +02:00
|
|
|
return ['office'];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2013-08-19 21:17:10 +02:00
|
|
|
global.recent_subjects = new global.Dict({fold_case: true});
|
2013-08-06 19:08:39 +02:00
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
|
|
|
"stream:office"
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
}());
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2014-02-20 16:28:52 +01:00
|
|
|
(function test_stream_completion() {
|
|
|
|
var query = 'stream:of';
|
|
|
|
|
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return ['office'];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
|
|
|
global.recent_subjects = new global.Dict({fold_case: true});
|
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
|
|
|
"stream:of",
|
|
|
|
"stream:office"
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
}());
|
|
|
|
|
2013-07-28 23:05:01 +02:00
|
|
|
(function test_people_suggestions() {
|
|
|
|
var query = 'te';
|
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
|
|
|
global.page_params.people_list = [
|
|
|
|
{
|
|
|
|
email: 'ted@zulip.com',
|
|
|
|
full_name: 'Ted Smith'
|
|
|
|
},
|
2014-02-20 16:47:29 +01:00
|
|
|
{
|
|
|
|
email: 'bob@zulip.com',
|
|
|
|
full_name: 'Bob Terry'
|
|
|
|
},
|
2013-07-28 23:05:01 +02:00
|
|
|
{
|
|
|
|
email: 'alice@zulip.com',
|
|
|
|
full_name: 'Alice Ignore'
|
|
|
|
}
|
|
|
|
];
|
|
|
|
|
2013-08-19 20:46:27 +02:00
|
|
|
global.recent_subjects = new global.Dict.from({
|
2013-07-28 23:05:01 +02:00
|
|
|
office: [
|
|
|
|
{subject: 'team'},
|
|
|
|
{subject: 'ignore'},
|
|
|
|
{subject: 'test'}
|
|
|
|
]
|
2013-08-19 21:17:10 +02:00
|
|
|
}, {fold_case: true});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
|
|
|
var suggestions = search.get_suggestions(query);
|
|
|
|
|
|
|
|
var expected = [
|
|
|
|
"te",
|
2014-02-20 16:47:29 +01:00
|
|
|
"pm-with:bob@zulip.com", // bob TErry
|
2013-07-28 23:05:01 +02:00
|
|
|
"pm-with:ted@zulip.com",
|
2014-02-20 16:47:29 +01:00
|
|
|
"sender:bob@zulip.com",
|
2013-08-05 18:35:46 +02:00
|
|
|
"sender:ted@zulip.com"
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
|
|
|
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-30 22:39:32 +02:00
|
|
|
function describe(q) {
|
|
|
|
return suggestions.lookup_table[q].description;
|
|
|
|
}
|
|
|
|
assert.equal(describe('pm-with:ted@zulip.com'),
|
|
|
|
"Narrow to private messages with <strong>Te</strong>d Smith <<strong>te</strong>d@zulip.com>");
|
|
|
|
assert.equal(describe('sender:ted@zulip.com'),
|
|
|
|
"Narrow to messages sent by <strong>Te</strong>d Smith <<strong>te</strong>d@zulip.com>");
|
|
|
|
|
2013-08-07 15:40:47 +02:00
|
|
|
suggestions = search.get_suggestions('Ted '); // note space
|
|
|
|
|
|
|
|
expected = [
|
|
|
|
"Ted",
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
"sender:ted@zulip.com"
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-28 23:05:01 +02:00
|
|
|
}());
|