Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/appveyor/tests.py

36 lines
1.5 KiB
Python
Raw Normal View History

integration: Add AppVeyor webhook.
2018-09-10 19:03:23 +02:00
from zerver.lib.test_classes import WebhookTestCase
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
integration: Add AppVeyor webhook.
2018-09-10 19:03:23 +02:00
class AppveyorHookTests(WebhookTestCase):
STREAM_NAME = 'appveyor'
URL_TEMPLATE = "/api/v1/external/appveyor?api_key={api_key}&stream={stream}"
FIXTURE_DIR_NAME = 'appveyor'
def test_appveyor_build_success_message(self) -> None:
"""
Tests if appveyor build success notification is handled correctly
"""
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "Hubot-DSC-Resource"
webhooks/appveyor: Improve message formatting and punctuation.
2019-04-10 06:07:51 +02:00
expected_message = """
[Build Hubot-DSC-Resource 2.0.59 completed](https://ci.appveyor.com/project/joebloggs/hubot-dsc-resource/build/2.0.59):
* **Commit**: [c06e208b47: Increment version number.](https://github.com/joebloggs/Hubot-DSC-Resource/commit/c06e208b47) by Joe Bloggs
* **Started**: 9/9/2018 7:04 PM
* **Finished**: 9/9/2018 7:06 PM
""".strip()
integration: Add AppVeyor webhook.
2018-09-10 19:03:23 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("appveyor_build_success", expected_topic, expected_message)
integration: Add AppVeyor webhook.
2018-09-10 19:03:23 +02:00
def test_appveyor_build_failure_message(self) -> None:
"""
Tests if appveyor build failure notification is handled correctly
"""
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "Hubot-DSC-Resource"
webhooks/appveyor: Improve message formatting and punctuation.
2019-04-10 06:07:51 +02:00
expected_message = """
[Build Hubot-DSC-Resource 2.0.59 failed](https://ci.appveyor.com/project/joebloggs/hubot-dsc-resource/build/2.0.59):
* **Commit**: [c06e208b47: Increment version number.](https://github.com/joebloggs/Hubot-DSC-Resource/commit/c06e208b47) by Joe Bloggs
* **Started**: 9/9/2018 7:04 PM
* **Finished**: 9/9/2018 7:06 PM
""".strip()
integration: Add AppVeyor webhook.
2018-09-10 19:03:23 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("appveyor_build_failure", expected_topic, expected_message)