2018-07-14 12:46:02 +02:00
|
|
|
set_global('page_params', {
|
|
|
|
search_pills_enabled: true,
|
|
|
|
});
|
2020-01-02 15:17:10 +01:00
|
|
|
|
|
|
|
set_global('message_store', {
|
|
|
|
user_ids: () => [],
|
|
|
|
});
|
|
|
|
|
2020-02-25 12:46:14 +01:00
|
|
|
const settings_config = zrequire('settings_config');
|
|
|
|
page_params.realm_email_address_visibility =
|
|
|
|
settings_config.email_address_visibility_values.admins_only.code;
|
|
|
|
|
2017-11-08 18:43:27 +01:00
|
|
|
zrequire('typeahead_helper');
|
2019-07-12 02:03:55 +02:00
|
|
|
set_global('Handlebars', global.make_handlebars());
|
2017-11-08 18:43:27 +01:00
|
|
|
zrequire('Filter', 'js/filter');
|
|
|
|
zrequire('narrow_state');
|
|
|
|
zrequire('stream_data');
|
|
|
|
zrequire('topic_data');
|
|
|
|
zrequire('people');
|
2018-05-13 12:17:00 +02:00
|
|
|
zrequire('unread');
|
2018-06-25 17:14:45 +02:00
|
|
|
zrequire('common');
|
2019-11-02 00:06:25 +01:00
|
|
|
const search = zrequire('search_suggestion');
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2020-01-07 14:21:35 +01:00
|
|
|
search.max_num_of_search_results = 15;
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const bob = {
|
2016-12-03 23:17:57 +01:00
|
|
|
email: 'bob@zulip.com',
|
2017-01-20 19:22:25 +01:00
|
|
|
full_name: 'Bob Roberts',
|
|
|
|
user_id: 42,
|
|
|
|
};
|
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
const noop = () => {};
|
2017-01-20 19:22:25 +01:00
|
|
|
|
|
|
|
function init() {
|
|
|
|
people.init();
|
|
|
|
people.add(bob);
|
2017-01-20 23:16:28 +01:00
|
|
|
people.initialize_current_user(bob.user_id);
|
2017-01-20 19:22:25 +01:00
|
|
|
}
|
|
|
|
init();
|
2013-08-20 18:45:09 +02:00
|
|
|
|
2020-02-25 12:46:14 +01:00
|
|
|
page_params.is_admin = true;
|
2013-08-22 01:29:28 +02:00
|
|
|
set_global('narrow', {});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2016-10-28 18:26:30 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
function get_suggestions(base_query, query) {
|
|
|
|
return search.get_suggestions(base_query, query);
|
|
|
|
}
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('basic_get_suggestions', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const query = 'fred';
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return 'office';
|
|
|
|
};
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
const suggestions = get_suggestions('', query);
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const expected = [
|
2016-12-03 23:17:57 +01:00
|
|
|
'fred',
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('subset_suggestions', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const query = 'shakespeare';
|
|
|
|
const base_query = 'stream:Denmark topic:Hamlet';
|
2013-08-28 01:23:42 +02:00
|
|
|
|
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2018-03-13 13:04:16 +01:00
|
|
|
return;
|
2013-08-28 01:23:42 +02:00
|
|
|
};
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
const suggestions = get_suggestions(base_query, query);
|
2013-08-28 01:23:42 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"shakespeare",
|
2013-08-28 01:23:42 +02:00
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-08-28 01:23:42 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('private_suggestions', () => {
|
2013-08-28 01:45:39 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2018-03-13 13:04:16 +01:00
|
|
|
return;
|
2013-08-28 01:45:39 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const ted =
|
2016-11-01 19:37:19 +01:00
|
|
|
{
|
|
|
|
email: 'ted@zulip.com',
|
|
|
|
user_id: 101,
|
2016-12-03 23:17:57 +01:00
|
|
|
full_name: 'Ted Smith',
|
2016-11-01 19:37:19 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice =
|
2016-11-01 19:37:19 +01:00
|
|
|
{
|
|
|
|
email: 'alice@zulip.com',
|
2016-10-31 15:56:57 +01:00
|
|
|
user_id: 102,
|
2016-12-03 23:17:57 +01:00
|
|
|
full_name: 'Alice Ignore',
|
2016-11-01 19:37:19 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
people.add(ted);
|
|
|
|
people.add(alice);
|
2013-08-28 01:45:39 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'is:private';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2013-08-28 01:45:39 +02:00
|
|
|
"is:private",
|
|
|
|
"pm-with:alice@zulip.com",
|
2017-01-20 19:22:25 +01:00
|
|
|
"pm-with:bob@zulip.com",
|
2016-12-03 23:17:57 +01:00
|
|
|
"pm-with:ted@zulip.com",
|
2013-08-28 01:45:39 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'al';
|
2019-11-02 00:06:25 +01:00
|
|
|
let base_query = 'is:private';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2014-01-21 20:53:52 +01:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"al",
|
|
|
|
"is:alerted",
|
|
|
|
"sender:alice@zulip.com",
|
|
|
|
"pm-with:alice@zulip.com",
|
|
|
|
"group-pm-with:alice@zulip.com",
|
2014-01-21 20:53:52 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'pm-with:t';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2013-10-07 20:48:25 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:t",
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2014-03-04 23:22:15 +01:00
|
|
|
query = '-pm-with:t';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2014-03-04 23:22:15 +01:00
|
|
|
expected = [
|
|
|
|
"-pm-with:t",
|
|
|
|
"is:private -pm-with:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-08-28 01:45:39 +02:00
|
|
|
query = 'pm-with:ted@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2013-08-28 01:45:39 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'sender:ted';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2013-10-07 20:48:25 +02:00
|
|
|
expected = [
|
|
|
|
"sender:ted",
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'sender:te';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2013-10-07 20:48:25 +02:00
|
|
|
expected = [
|
|
|
|
"sender:te",
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2014-03-04 23:22:15 +01:00
|
|
|
query = '-sender:te';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2014-03-04 23:22:15 +01:00
|
|
|
expected = [
|
|
|
|
"-sender:te",
|
2017-06-03 09:19:57 +02:00
|
|
|
"-sender:ted@zulip.com",
|
2014-03-04 23:22:15 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-10-07 20:48:25 +02:00
|
|
|
query = 'sender:ted@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2013-10-07 20:48:25 +02:00
|
|
|
expected = [
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'from:ted';
|
|
|
|
base_query = 'is:unread';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-01-11 19:13:13 +01:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"from:ted",
|
|
|
|
"from:ted@zulip.com",
|
2017-01-11 19:13:13 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2013-08-28 01:45:39 +02:00
|
|
|
// Users can enter bizarre queries, and if they do, we want to
|
|
|
|
// be conservative with suggestions.
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'near:3';
|
|
|
|
base_query = 'is:private';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2013-08-28 01:45:39 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"near:3",
|
2013-08-28 01:45:39 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'near:3';
|
|
|
|
base_query = 'pm-with:ted@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2013-08-28 01:45:39 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"near:3",
|
2013-08-28 01:45:39 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-06-03 09:19:57 +02:00
|
|
|
|
|
|
|
// Make sure suggestions still work if preceding tokens
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'sender:ted@zulip.com';
|
|
|
|
base_query = 'is:alerted';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"sender:ted@zulip.com",
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'al';
|
|
|
|
base_query = 'is:starred has:link is:private';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"al",
|
|
|
|
"is:alerted",
|
|
|
|
"sender:alice@zulip.com",
|
|
|
|
"pm-with:alice@zulip.com",
|
|
|
|
"group-pm-with:alice@zulip.com",
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// Make sure it handles past context correctly
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'pm-with:';
|
|
|
|
base_query = 'stream:Denmark';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'pm-with:',
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'sender:';
|
|
|
|
base_query = 'sender:ted@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'sender:',
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-08-28 01:45:39 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('group_suggestions', () => {
|
2017-02-05 22:11:18 +01:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2018-03-13 13:04:16 +01:00
|
|
|
return;
|
2017-02-05 22:11:18 +01:00
|
|
|
};
|
|
|
|
|
2017-07-05 02:58:05 +02:00
|
|
|
set_global('activity', {
|
2018-05-07 03:30:13 +02:00
|
|
|
get_huddles: function () {
|
|
|
|
return [];
|
|
|
|
},
|
2017-07-05 02:58:05 +02:00
|
|
|
});
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const ted =
|
2017-02-05 22:11:18 +01:00
|
|
|
{
|
|
|
|
email: 'ted@zulip.com',
|
|
|
|
user_id: 101,
|
|
|
|
full_name: 'Ted Smith',
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice =
|
2017-02-05 22:11:18 +01:00
|
|
|
{
|
|
|
|
email: 'alice@zulip.com',
|
|
|
|
user_id: 102,
|
|
|
|
full_name: 'Alice Ignore',
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const jeff =
|
2017-07-05 02:58:05 +02:00
|
|
|
{
|
|
|
|
email: 'jeff@zulip.com',
|
|
|
|
user_id: 103,
|
|
|
|
full_name: 'Jeff Zoolipson',
|
|
|
|
};
|
|
|
|
|
2017-02-05 22:11:18 +01:00
|
|
|
people.add(ted);
|
|
|
|
people.add(alice);
|
2017-07-05 02:58:05 +02:00
|
|
|
people.add(jeff);
|
2017-02-05 22:11:18 +01:00
|
|
|
|
|
|
|
// Entering a comma in a pm-with query should immediately generate
|
|
|
|
// suggestions for the next person.
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'pm-with:bob@zulip.com,';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2017-02-05 22:11:18 +01:00
|
|
|
"pm-with:bob@zulip.com,",
|
|
|
|
"pm-with:bob@zulip.com,alice@zulip.com",
|
2017-07-05 02:58:05 +02:00
|
|
|
"pm-with:bob@zulip.com,jeff@zulip.com",
|
2017-02-05 22:11:18 +01:00
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// Only the last part of a comma-separated pm-with query should be used to
|
|
|
|
// generate suggestions.
|
|
|
|
query = 'pm-with:bob@zulip.com,t';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"pm-with:bob@zulip.com,t",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// Smit should also generate ted@zulip.com (Ted Smith) as a suggestion.
|
|
|
|
query = 'pm-with:bob@zulip.com,Smit';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"pm-with:bob@zulip.com,Smit",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-07-04 22:14:42 +02:00
|
|
|
// Do not suggest "bob@zulip.com" (the name of the current user)
|
|
|
|
query = 'pm-with:ted@zulip.com,bo';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-04 22:14:42 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:ted@zulip.com,bo",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-02-05 22:11:18 +01:00
|
|
|
// No superfluous suggestions should be generated.
|
|
|
|
query = 'pm-with:bob@zulip.com,red';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"pm-with:bob@zulip.com,red",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// is:private should be properly prepended to each suggestion if the pm-with
|
|
|
|
// operator is negated.
|
|
|
|
|
|
|
|
query = '-pm-with:bob@zulip.com,';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"-pm-with:bob@zulip.com,",
|
|
|
|
"is:private -pm-with:bob@zulip.com,alice@zulip.com",
|
2017-07-05 02:58:05 +02:00
|
|
|
"is:private -pm-with:bob@zulip.com,jeff@zulip.com",
|
2017-02-05 22:11:18 +01:00
|
|
|
"is:private -pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '-pm-with:bob@zulip.com,t';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"-pm-with:bob@zulip.com,t",
|
|
|
|
"is:private -pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '-pm-with:bob@zulip.com,Smit';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"-pm-with:bob@zulip.com,Smit",
|
|
|
|
"is:private -pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '-pm-with:bob@zulip.com,red';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-02-05 22:11:18 +01:00
|
|
|
expected = [
|
|
|
|
"-pm-with:bob@zulip.com,red",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-06-03 09:19:57 +02:00
|
|
|
|
|
|
|
// Test multiple operators
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'pm-with:bob@zulip.com,Smit';
|
2019-11-02 00:06:25 +01:00
|
|
|
let base_query = 'is:starred has:link';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"pm-with:bob@zulip.com,Smit",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com",
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'pm-with:bob@zulip.com,Smit';
|
|
|
|
base_query = 'stream:Denmark has:link';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 09:19:57 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"pm-with:bob@zulip.com,Smit",
|
2017-06-03 09:19:57 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-07-05 02:58:05 +02:00
|
|
|
|
|
|
|
set_global('activity', {
|
2018-05-07 03:30:13 +02:00
|
|
|
get_huddles: function () {
|
|
|
|
return ['101,42', '101,103,42'];
|
|
|
|
},
|
2017-07-05 02:58:05 +02:00
|
|
|
});
|
|
|
|
|
|
|
|
// Simulate a past huddle which should now prioritize ted over alice
|
|
|
|
query = 'pm-with:bob@zulip.com,';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-05 02:58:05 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:bob@zulip.com,",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com",
|
|
|
|
"pm-with:bob@zulip.com,alice@zulip.com",
|
|
|
|
"pm-with:bob@zulip.com,jeff@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// bob,ted,jeff is already an existing huddle, so prioritize this one
|
|
|
|
query = 'pm-with:bob@zulip.com,ted@zulip.com,';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-05 02:58:05 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com,",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com,jeff@zulip.com",
|
|
|
|
"pm-with:bob@zulip.com,ted@zulip.com,alice@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// bob,ted,jeff is already an existing huddle, but if we start with just bob,
|
|
|
|
// then don't prioritize ted over alice because it doesn't complete the full huddle.
|
|
|
|
query = 'pm-with:jeff@zulip.com,';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-05 02:58:05 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:jeff@zulip.com,",
|
|
|
|
"pm-with:jeff@zulip.com,alice@zulip.com",
|
|
|
|
"pm-with:jeff@zulip.com,ted@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2019-06-27 19:16:55 +02:00
|
|
|
|
|
|
|
query = "pm-with:jeff@zulip.com,ted@zulip.com hi";
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions("", query);
|
2019-06-27 19:16:55 +02:00
|
|
|
expected = [
|
|
|
|
"pm-with:jeff@zulip.com,ted@zulip.com hi",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-02-05 22:11:18 +01:00
|
|
|
|
2017-01-20 19:22:25 +01:00
|
|
|
init();
|
2016-12-15 22:18:59 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('empty_query_suggestions', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const query = '';
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return ['devel', 'office'];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2018-03-13 13:04:16 +01:00
|
|
|
return;
|
2013-07-28 23:05:01 +02:00
|
|
|
};
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
const suggestions = get_suggestions('', query);
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const expected = [
|
2013-07-28 23:05:01 +02:00
|
|
|
"",
|
2019-08-13 20:20:36 +02:00
|
|
|
"streams:public",
|
2013-07-28 23:05:01 +02:00
|
|
|
"is:private",
|
|
|
|
"is:starred",
|
|
|
|
"is:mentioned",
|
2013-08-30 21:15:01 +02:00
|
|
|
"is:alerted",
|
2017-06-19 00:33:24 +02:00
|
|
|
"is:unread",
|
2013-07-28 23:05:01 +02:00
|
|
|
"sender:bob@zulip.com",
|
|
|
|
"stream:devel",
|
2016-12-03 23:17:57 +01:00
|
|
|
"stream:office",
|
2018-05-18 10:10:49 +02:00
|
|
|
'has:link',
|
|
|
|
'has:image',
|
|
|
|
'has:attachment',
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
|
|
|
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-30 22:39:32 +02:00
|
|
|
|
|
|
|
function describe(q) {
|
2020-02-12 06:58:20 +01:00
|
|
|
return suggestions.lookup_table.get(q).description;
|
2013-07-30 22:39:32 +02:00
|
|
|
}
|
|
|
|
assert.equal(describe('is:private'), 'Private messages');
|
|
|
|
assert.equal(describe('is:starred'), 'Starred messages');
|
|
|
|
assert.equal(describe('is:mentioned'), '@-mentions');
|
2013-08-30 21:15:01 +02:00
|
|
|
assert.equal(describe('is:alerted'), 'Alerted messages');
|
2017-06-19 00:33:24 +02:00
|
|
|
assert.equal(describe('is:unread'), 'Unread messages');
|
2013-07-30 22:39:32 +02:00
|
|
|
assert.equal(describe('sender:bob@zulip.com'), 'Sent by me');
|
2018-05-18 10:10:49 +02:00
|
|
|
assert.equal(describe('has:link'), 'Messages with one or more link');
|
|
|
|
assert.equal(describe('has:image'), 'Messages with one or more image');
|
|
|
|
assert.equal(describe('has:attachment'), 'Messages with one or more attachment');
|
|
|
|
});
|
|
|
|
|
2018-05-20 16:38:28 +02:00
|
|
|
run_test('has_suggestions', () => {
|
2018-05-18 10:10:49 +02:00
|
|
|
// Checks that category wise suggestions are displayed instead of a single
|
|
|
|
// default suggestion when suggesting `has` operator.
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'h';
|
2018-05-18 10:10:49 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return ['devel', 'office'];
|
|
|
|
};
|
|
|
|
global.narrow_state.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2018-05-18 10:10:49 +02:00
|
|
|
"h",
|
|
|
|
'has:link',
|
|
|
|
'has:image',
|
|
|
|
'has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
function describe(q) {
|
2020-02-12 06:58:20 +01:00
|
|
|
return suggestions.lookup_table.get(q).description;
|
2018-05-18 10:10:49 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
assert.equal(describe('has:link'), 'Messages with one or more link');
|
|
|
|
assert.equal(describe('has:image'), 'Messages with one or more image');
|
|
|
|
assert.equal(describe('has:attachment'), 'Messages with one or more attachment');
|
2018-05-20 16:30:06 +02:00
|
|
|
|
|
|
|
query = '-h';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-20 16:30:06 +02:00
|
|
|
expected = [
|
|
|
|
"-h",
|
|
|
|
'-has:link',
|
|
|
|
'-has:image',
|
|
|
|
'-has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
assert.equal(describe('-has:link'), 'Exclude messages with one or more link');
|
|
|
|
assert.equal(describe('-has:image'), 'Exclude messages with one or more image');
|
|
|
|
assert.equal(describe('-has:attachment'), 'Exclude messages with one or more attachment');
|
2018-05-20 16:38:28 +02:00
|
|
|
|
|
|
|
// operand suggestions follow.
|
|
|
|
|
|
|
|
query = 'has:';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-20 16:38:28 +02:00
|
|
|
expected = [
|
|
|
|
'has:link',
|
|
|
|
'has:image',
|
|
|
|
'has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'has:im';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-20 16:38:28 +02:00
|
|
|
expected = [
|
|
|
|
'has:image',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '-has:im';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-20 16:38:28 +02:00
|
|
|
expected = [
|
|
|
|
'-has:image',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'att';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-20 16:38:28 +02:00
|
|
|
expected = [
|
|
|
|
'att',
|
|
|
|
'has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'has:lin';
|
2019-11-02 00:06:25 +01:00
|
|
|
const base_query = 'stream:Denmark is:alerted';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-05-20 16:38:28 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'has:link',
|
2018-05-20 16:38:28 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2018-05-22 14:37:51 +02:00
|
|
|
run_test('check_is_suggestions', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'i';
|
2018-05-22 14:37:51 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return ['devel', 'office'];
|
|
|
|
};
|
|
|
|
global.narrow_state.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2018-05-22 14:37:51 +02:00
|
|
|
'i',
|
|
|
|
'is:private',
|
|
|
|
'is:starred',
|
|
|
|
'is:mentioned',
|
|
|
|
'is:alerted',
|
|
|
|
'is:unread',
|
|
|
|
'has:image',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
function describe(q) {
|
2020-02-12 06:58:20 +01:00
|
|
|
return suggestions.lookup_table.get(q).description;
|
2018-05-22 14:37:51 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
assert.equal(describe('is:private'), 'Private messages');
|
|
|
|
assert.equal(describe('is:starred'), 'Starred messages');
|
|
|
|
assert.equal(describe('is:mentioned'), '@-mentions');
|
|
|
|
assert.equal(describe('is:alerted'), 'Alerted messages');
|
|
|
|
assert.equal(describe('is:unread'), 'Unread messages');
|
|
|
|
|
|
|
|
query = '-i';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
|
|
|
'-i',
|
|
|
|
'-is:private',
|
|
|
|
'-is:starred',
|
|
|
|
'-is:mentioned',
|
|
|
|
'-is:alerted',
|
|
|
|
'-is:unread',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
assert.equal(describe('-is:private'), 'Exclude private messages');
|
|
|
|
assert.equal(describe('-is:starred'), 'Exclude starred messages');
|
|
|
|
assert.equal(describe('-is:mentioned'), 'Exclude @-mentions');
|
|
|
|
assert.equal(describe('-is:alerted'), 'Exclude alerted messages');
|
|
|
|
assert.equal(describe('-is:unread'), 'Exclude unread messages');
|
|
|
|
|
2018-07-04 01:48:10 +02:00
|
|
|
query = '';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-07-04 01:48:10 +02:00
|
|
|
expected = [
|
|
|
|
'',
|
2019-08-13 20:20:36 +02:00
|
|
|
'streams:public',
|
2018-07-04 01:48:10 +02:00
|
|
|
'is:private',
|
|
|
|
'is:starred',
|
|
|
|
'is:mentioned',
|
|
|
|
'is:alerted',
|
|
|
|
'is:unread',
|
|
|
|
'sender:bob@zulip.com',
|
|
|
|
'stream:devel',
|
|
|
|
'stream:office',
|
|
|
|
'has:link',
|
|
|
|
'has:image',
|
|
|
|
'has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '';
|
2019-11-02 00:06:25 +01:00
|
|
|
let base_query = 'is:private';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-07-04 01:48:10 +02:00
|
|
|
expected = [
|
|
|
|
'is:starred',
|
|
|
|
'is:mentioned',
|
|
|
|
'is:alerted',
|
|
|
|
'is:unread',
|
|
|
|
'sender:bob@zulip.com',
|
|
|
|
'has:link',
|
|
|
|
'has:image',
|
|
|
|
'has:attachment',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-05-22 14:37:51 +02:00
|
|
|
// operand suggestions follow.
|
|
|
|
|
|
|
|
query = 'is:';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
|
|
|
'is:private',
|
|
|
|
'is:starred',
|
|
|
|
'is:mentioned',
|
|
|
|
'is:alerted',
|
|
|
|
'is:unread',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'is:st';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
|
|
|
'is:starred',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = '-is:st';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
|
|
|
'-is:starred',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'st';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
|
|
|
'st',
|
2019-08-13 20:20:36 +02:00
|
|
|
'streams:public',
|
2018-05-22 14:37:51 +02:00
|
|
|
'is:starred',
|
|
|
|
'stream:',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'is:sta';
|
2018-07-04 01:48:10 +02:00
|
|
|
base_query = 'stream:Denmark has:link';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-05-22 14:37:51 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'is:starred',
|
2018-05-22 14:37:51 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
});
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('sent_by_me_suggestions', () => {
|
2017-01-11 19:20:31 +01:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2018-03-13 13:04:16 +01:00
|
|
|
return;
|
2017-01-11 19:20:31 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = '';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
js: Convert a.indexOf(…) !== -1 to a.includes(…).
Babel polyfills this for us for Internet Explorer.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitBinaryExpression(path) {
const { operator, left, right } = path.node;
if (
n.CallExpression.check(left) &&
n.MemberExpression.check(left.callee) &&
!left.callee.computed &&
n.Identifier.check(left.callee.property) &&
left.callee.property.name === "indexOf" &&
left.arguments.length === 1 &&
checkExpression(left.arguments[0]) &&
((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
n.UnaryExpression.check(right) &&
right.operator == "-" &&
n.Literal.check(right.argument) &&
right.argument.value === 1) ||
([">=", "<"].includes(operator) &&
n.Literal.check(right) &&
right.value === 0))
) {
const test = b.callExpression(
b.memberExpression(left.callee.object, b.identifier("includes")),
[left.arguments[0]]
);
path.replace(
["!==", "!=", ">", ">="].includes(operator)
? test
: b.unaryExpression("!", test)
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 04:55:06 +01:00
|
|
|
assert(suggestions.strings.includes('sender:bob@zulip.com'));
|
2020-02-12 06:58:20 +01:00
|
|
|
assert.equal(suggestions.lookup_table.get('sender:bob@zulip.com').description,
|
2017-01-11 19:20:31 +01:00
|
|
|
'Sent by me');
|
|
|
|
|
|
|
|
query = 'sender';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2017-01-11 19:20:31 +01:00
|
|
|
"sender",
|
|
|
|
"sender:bob@zulip.com",
|
2017-06-15 09:07:12 +02:00
|
|
|
"sender:",
|
2017-01-11 19:20:31 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-05-21 07:35:27 +02:00
|
|
|
query = '-sender';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-21 07:35:27 +02:00
|
|
|
expected = [
|
|
|
|
"-sender",
|
|
|
|
"-sender:bob@zulip.com",
|
|
|
|
"-sender:",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-01-11 19:20:31 +01:00
|
|
|
query = 'from';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-01-11 19:20:31 +01:00
|
|
|
expected = [
|
|
|
|
"from",
|
|
|
|
"from:bob@zulip.com",
|
2017-06-15 09:07:12 +02:00
|
|
|
"from:",
|
2017-01-11 19:20:31 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-05-21 07:35:27 +02:00
|
|
|
query = '-from';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-21 07:35:27 +02:00
|
|
|
expected = [
|
|
|
|
"-from",
|
|
|
|
"-from:bob@zulip.com",
|
|
|
|
"-from:",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-01-11 19:20:31 +01:00
|
|
|
query = 'sender:bob@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-01-11 19:20:31 +01:00
|
|
|
expected = [
|
|
|
|
"sender:bob@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'from:bob@zulip.com';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-01-11 19:20:31 +01:00
|
|
|
expected = [
|
|
|
|
"from:bob@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'sent';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-01-11 19:20:31 +01:00
|
|
|
expected = [
|
|
|
|
"sent",
|
|
|
|
"sender:bob@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-06-03 05:33:02 +02:00
|
|
|
|
2018-05-21 07:35:27 +02:00
|
|
|
query = '-sent';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-21 07:35:27 +02:00
|
|
|
expected = [
|
|
|
|
"-sent",
|
|
|
|
"-sender:bob@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'sent';
|
2019-11-02 00:06:25 +01:00
|
|
|
let base_query = 'stream:Denmark topic:Denmark1';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 05:33:02 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"sent",
|
|
|
|
"sender:bob@zulip.com",
|
2017-06-03 05:33:02 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'sender:m';
|
|
|
|
base_query = 'is:starred';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 05:33:02 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"sender:m",
|
|
|
|
"sender:bob@zulip.com",
|
2017-06-03 05:33:02 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'sender:';
|
|
|
|
base_query = 'is:starred';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-03 05:33:02 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"sender:",
|
|
|
|
"sender:bob@zulip.com",
|
2017-06-03 05:33:02 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-01-11 19:20:31 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('topic_suggestions', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
let suggestions;
|
|
|
|
let expected;
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return ['office'];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2013-07-28 23:05:01 +02:00
|
|
|
return 'office';
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const devel_id = 44;
|
|
|
|
const office_id = 77;
|
2017-05-14 15:39:02 +02:00
|
|
|
|
|
|
|
global.stream_data.get_stream_id = function (stream_name) {
|
|
|
|
switch (stream_name) {
|
2018-05-07 03:30:13 +02:00
|
|
|
case 'office': return office_id;
|
|
|
|
case 'devel': return devel_id;
|
2017-05-14 15:39:02 +02:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', 'te');
|
2017-07-24 15:15:28 +02:00
|
|
|
expected = [
|
|
|
|
"te",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-05-14 15:39:02 +02:00
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.add_message({
|
|
|
|
stream_id: devel_id,
|
|
|
|
topic_name: 'REXX',
|
|
|
|
});
|
2017-05-14 15:39:02 +02:00
|
|
|
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const topic_name of ['team', 'ignore', 'test']) {
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.add_message({
|
|
|
|
stream_id: office_id,
|
|
|
|
topic_name: topic_name,
|
|
|
|
});
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', 'te');
|
2014-02-20 17:29:14 +01:00
|
|
|
expected = [
|
2013-07-28 23:05:01 +02:00
|
|
|
"te",
|
|
|
|
"stream:office topic:team",
|
2016-12-03 23:17:57 +01:00
|
|
|
"stream:office topic:test",
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2013-07-30 22:39:32 +02:00
|
|
|
|
|
|
|
function describe(q) {
|
2020-02-12 06:58:20 +01:00
|
|
|
return suggestions.lookup_table.get(q).description;
|
2013-07-30 22:39:32 +02:00
|
|
|
}
|
|
|
|
assert.equal(describe('te'), "Search for te");
|
2018-04-10 20:22:15 +02:00
|
|
|
assert.equal(describe('stream:office topic:team'), "Stream office > team");
|
2013-07-30 22:39:32 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('topic:staplers', 'stream:office');
|
2014-02-20 17:29:14 +01:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'stream:office',
|
2014-02-20 17:29:14 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('stream:devel', 'topic:');
|
2014-02-20 17:29:14 +01:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'topic:',
|
|
|
|
'topic:REXX',
|
2014-02-20 17:29:14 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2014-03-04 22:52:13 +01:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('stream:devel', '-topic:');
|
2014-03-04 22:52:13 +01:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'-topic:',
|
|
|
|
'-topic:REXX',
|
2014-03-04 22:52:13 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', '-topic:te');
|
2014-03-04 22:52:13 +01:00
|
|
|
expected = [
|
|
|
|
'-topic:te',
|
|
|
|
'stream:office -topic:team',
|
2016-12-03 23:17:57 +01:00
|
|
|
'stream:office -topic:test',
|
2014-03-04 22:52:13 +01:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2017-06-03 22:54:35 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('is:alerted stream:devel is:starred', 'topic:');
|
2017-06-03 22:54:35 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'topic:',
|
|
|
|
'topic:REXX',
|
2017-06-03 22:54:35 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('is:private stream:devel', 'topic:');
|
2017-06-03 22:54:35 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'topic:',
|
2017-06-03 22:54:35 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('topic:REXX stream:devel', 'topic:');
|
2017-06-03 22:54:35 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'topic:',
|
2017-06-03 22:54:35 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('whitespace_glitch', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const query = 'stream:office '; // note trailing space
|
2013-08-06 19:08:39 +02:00
|
|
|
|
2013-08-15 21:11:07 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2013-08-06 19:08:39 +02:00
|
|
|
return ['office'];
|
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2013-08-06 19:08:39 +02:00
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2013-08-06 19:08:39 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
const suggestions = get_suggestions('', query);
|
2013-08-06 19:08:39 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const expected = [
|
2016-12-03 23:17:57 +01:00
|
|
|
"stream:office",
|
2013-08-06 19:08:39 +02:00
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('stream_completion', () => {
|
2014-02-20 16:28:52 +01:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
2017-06-23 08:39:37 +02:00
|
|
|
return ['office', 'dev help'];
|
2014-02-20 16:28:52 +01:00
|
|
|
};
|
|
|
|
|
2017-04-25 15:25:31 +02:00
|
|
|
global.narrow_state.stream = function () {
|
2014-02-20 16:28:52 +01:00
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2014-02-20 16:28:52 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'stream:of';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('s', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2014-02-20 16:28:52 +01:00
|
|
|
"stream:of",
|
2016-12-03 23:17:57 +01:00
|
|
|
"stream:office",
|
2014-02-20 16:28:52 +01:00
|
|
|
];
|
2017-06-23 08:39:37 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-21 06:23:08 +02:00
|
|
|
|
|
|
|
query = '-stream:of';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2018-05-21 06:23:08 +02:00
|
|
|
expected = [
|
|
|
|
"-stream:of",
|
|
|
|
"-stream:office",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2014-02-20 16:28:52 +01:00
|
|
|
|
2017-06-23 08:39:37 +02:00
|
|
|
query = 'hel';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-06-23 08:39:37 +02:00
|
|
|
expected = [
|
|
|
|
"hel",
|
|
|
|
"stream:dev+help",
|
|
|
|
];
|
2014-02-20 16:28:52 +01:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2014-02-20 16:28:52 +01:00
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
function people_suggestion_setup() {
|
2020-02-08 01:27:04 +01:00
|
|
|
global.stream_data.subscribed_streams = () => [];
|
2019-04-23 18:02:06 +02:00
|
|
|
global.narrow_state.stream = noop;
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
const ted = {
|
2016-11-01 19:37:19 +01:00
|
|
|
email: 'ted@zulip.com',
|
2016-10-31 15:56:57 +01:00
|
|
|
user_id: 201,
|
2016-12-03 23:17:57 +01:00
|
|
|
full_name: 'Ted Smith',
|
2016-11-01 19:37:19 +01:00
|
|
|
};
|
2019-04-23 18:02:06 +02:00
|
|
|
people.add(ted);
|
2016-11-01 19:37:19 +01:00
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
const bob = {
|
2016-11-01 19:37:19 +01:00
|
|
|
email: 'bob@zulip.com',
|
2016-10-31 15:56:57 +01:00
|
|
|
user_id: 202,
|
2017-06-23 08:39:37 +02:00
|
|
|
full_name: 'Bob Térry',
|
2016-11-01 19:37:19 +01:00
|
|
|
};
|
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
people.add(bob);
|
|
|
|
const alice = {
|
2016-11-01 19:37:19 +01:00
|
|
|
email: 'alice@zulip.com',
|
2016-10-31 15:56:57 +01:00
|
|
|
user_id: 203,
|
2016-12-03 23:17:57 +01:00
|
|
|
full_name: 'Alice Ignore',
|
2016-11-01 19:37:19 +01:00
|
|
|
};
|
|
|
|
people.add(alice);
|
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2019-04-23 18:02:06 +02:00
|
|
|
}
|
2013-07-28 23:05:01 +02:00
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
run_test('people_suggestions', () => {
|
|
|
|
people_suggestion_setup();
|
|
|
|
let query = 'te';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-04-23 18:02:06 +02:00
|
|
|
let expected = [
|
2013-07-28 23:05:01 +02:00
|
|
|
"te",
|
2014-02-20 16:47:29 +01:00
|
|
|
"sender:bob@zulip.com",
|
2016-12-03 23:17:57 +01:00
|
|
|
"sender:ted@zulip.com",
|
2018-05-21 07:46:25 +02:00
|
|
|
"pm-with:bob@zulip.com", // bob térry
|
|
|
|
"pm-with:ted@zulip.com",
|
2017-06-04 01:51:53 +02:00
|
|
|
"group-pm-with:bob@zulip.com",
|
|
|
|
"group-pm-with:ted@zulip.com",
|
2013-07-28 23:05:01 +02:00
|
|
|
];
|
|
|
|
|
2013-07-30 19:41:23 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2019-04-23 18:02:06 +02:00
|
|
|
|
2020-02-12 06:58:20 +01:00
|
|
|
const describe = (q) => suggestions.lookup_table.get(q).description;
|
2019-04-23 18:02:06 +02:00
|
|
|
|
2013-07-30 22:39:32 +02:00
|
|
|
assert.equal(describe('pm-with:ted@zulip.com'),
|
2018-05-07 03:30:13 +02:00
|
|
|
"Private messages with <strong>Te</strong>d Smith <<strong>te</strong>d@zulip.com>");
|
2013-07-30 22:39:32 +02:00
|
|
|
assert.equal(describe('sender:ted@zulip.com'),
|
2018-05-07 03:30:13 +02:00
|
|
|
"Sent by <strong>Te</strong>d Smith <<strong>te</strong>d@zulip.com>");
|
2013-07-30 22:39:32 +02:00
|
|
|
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', 'Ted '); // note space
|
2013-08-07 15:40:47 +02:00
|
|
|
expected = [
|
|
|
|
"Ted",
|
2016-12-03 23:17:57 +01:00
|
|
|
"sender:ted@zulip.com",
|
2018-05-21 07:46:25 +02:00
|
|
|
"pm-with:ted@zulip.com",
|
2017-06-04 01:51:53 +02:00
|
|
|
"group-pm-with:ted@zulip.com",
|
2013-08-07 15:40:47 +02:00
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2016-11-01 19:37:19 +01:00
|
|
|
|
2018-05-25 17:03:13 +02:00
|
|
|
query = 'sender:ted sm';
|
2019-04-23 18:02:06 +02:00
|
|
|
let base_query = '';
|
2018-05-25 17:03:13 +02:00
|
|
|
expected = [
|
|
|
|
'sender:ted+sm',
|
|
|
|
'sender:ted@zulip.com',
|
|
|
|
];
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-05-25 17:03:13 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = 'new';
|
|
|
|
base_query = 'sender:ted@zulip.com';
|
2018-05-25 17:03:13 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'new',
|
2018-05-25 17:03:13 +02:00
|
|
|
];
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-05-25 17:03:13 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'sender:ted@tulip.com new';
|
2018-07-02 22:30:18 +02:00
|
|
|
base_query = '';
|
2018-05-25 17:03:13 +02:00
|
|
|
expected = [
|
|
|
|
'sender:ted@tulip.com+new',
|
|
|
|
];
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-07-02 22:30:18 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'new';
|
|
|
|
base_query = 'sender:ted@tulip.com';
|
|
|
|
expected = [
|
|
|
|
'new',
|
|
|
|
];
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-05-25 17:03:13 +02:00
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-05 09:54:56 +02:00
|
|
|
|
2019-04-23 18:02:06 +02:00
|
|
|
run_test('people_suggestion (Admin only email visibility)', () => {
|
|
|
|
/* Suggestions when realm_email_address_visibility is set to admin
|
|
|
|
only */
|
|
|
|
people_suggestion_setup();
|
|
|
|
const query = 'te';
|
2020-02-25 12:46:14 +01:00
|
|
|
page_params.is_admin = false;
|
2019-12-24 00:17:39 +01:00
|
|
|
const suggestions = get_suggestions('', query);
|
2019-04-23 18:02:06 +02:00
|
|
|
const expected = [
|
|
|
|
"te",
|
|
|
|
"sender:bob@zulip.com",
|
|
|
|
"sender:ted@zulip.com",
|
|
|
|
"pm-with:bob@zulip.com", // bob térry
|
|
|
|
"pm-with:ted@zulip.com",
|
|
|
|
"group-pm-with:bob@zulip.com",
|
|
|
|
"group-pm-with:ted@zulip.com",
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2020-02-12 06:58:20 +01:00
|
|
|
const describe = (q) => suggestions.lookup_table.get(q).description;
|
2019-04-23 18:02:06 +02:00
|
|
|
|
|
|
|
assert.equal(describe('pm-with:ted@zulip.com'),
|
|
|
|
'Private messages with <strong>Te</strong>d Smith');
|
|
|
|
assert.equal(describe('sender:ted@zulip.com'),
|
|
|
|
'Sent by <strong>Te</strong>d Smith');
|
|
|
|
});
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('operator_suggestions', () => {
|
2017-06-15 09:07:12 +02:00
|
|
|
// Completed operator should return nothing
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'stream:';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2017-06-15 09:07:12 +02:00
|
|
|
'stream:',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'st';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-06-15 09:07:12 +02:00
|
|
|
expected = [
|
|
|
|
'st',
|
2019-08-13 20:20:36 +02:00
|
|
|
'streams:public',
|
2017-06-15 09:07:12 +02:00
|
|
|
'is:starred',
|
|
|
|
'stream:',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-09-24 18:02:56 +02:00
|
|
|
query = 'group-';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-09-24 18:02:56 +02:00
|
|
|
expected = [
|
|
|
|
'group-',
|
|
|
|
'group-pm-with:',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2017-06-15 09:07:12 +02:00
|
|
|
query = '-s';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-06-15 09:07:12 +02:00
|
|
|
expected = [
|
|
|
|
'-s',
|
2019-08-13 20:20:36 +02:00
|
|
|
'-streams:public',
|
2018-05-21 07:35:27 +02:00
|
|
|
'-sender:bob@zulip.com',
|
2017-06-15 09:07:12 +02:00
|
|
|
'-stream:',
|
|
|
|
'-sender:',
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
2018-07-02 22:30:18 +02:00
|
|
|
query = '-f';
|
2019-11-02 00:06:25 +01:00
|
|
|
const base_query = 'stream:Denmark is:alerted';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2017-06-15 09:07:12 +02:00
|
|
|
expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
'-f',
|
|
|
|
'-from:bob@zulip.com',
|
|
|
|
'-from:',
|
2017-06-15 09:07:12 +02:00
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-07-12 08:44:41 +02:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('queries_with_spaces', () => {
|
2017-07-12 08:44:41 +02:00
|
|
|
global.stream_data.subscribed_streams = function () {
|
|
|
|
return ['office', 'dev help'];
|
|
|
|
};
|
|
|
|
|
|
|
|
global.narrow_state.stream = function () {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
|
2017-07-24 22:16:13 +02:00
|
|
|
topic_data.reset();
|
2017-07-12 08:44:41 +02:00
|
|
|
|
|
|
|
// test allowing spaces with quotes surrounding operand
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'stream:"dev he"';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions('', query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2017-07-12 08:44:41 +02:00
|
|
|
"stream:dev+he",
|
|
|
|
"stream:dev+help",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// test mismatched quote
|
|
|
|
query = 'stream:"dev h';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-12 08:44:41 +02:00
|
|
|
expected = [
|
|
|
|
"stream:dev+h",
|
|
|
|
"stream:dev+help",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
// test extra space after operator still works
|
|
|
|
query = 'stream: offi';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions('', query);
|
2017-07-12 08:44:41 +02:00
|
|
|
expected = [
|
|
|
|
"stream:offi",
|
|
|
|
"stream:office",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-07-02 22:30:18 +02:00
|
|
|
|
|
|
|
// When input search query contains multiple operators
|
|
|
|
// and a pill hasn't been formed from those operators.
|
|
|
|
run_test('multiple_operators_without_pills', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
let query = 'is:private al';
|
|
|
|
let base_query = '';
|
2019-12-24 00:17:39 +01:00
|
|
|
let suggestions = get_suggestions(base_query, query);
|
2019-11-02 00:06:25 +01:00
|
|
|
let expected = [
|
2018-07-02 22:30:18 +02:00
|
|
|
"is:private al",
|
|
|
|
"is:private is:alerted",
|
|
|
|
"is:private sender:alice@zulip.com",
|
|
|
|
"is:private pm-with:alice@zulip.com",
|
|
|
|
"is:private group-pm-with:alice@zulip.com",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
|
|
|
|
query = 'abc is:alerted sender:ted@zulip.com';
|
|
|
|
base_query = '';
|
2019-12-24 00:17:39 +01:00
|
|
|
suggestions = get_suggestions(base_query, query);
|
2018-07-02 22:30:18 +02:00
|
|
|
expected = [
|
|
|
|
"is:alerted sender:ted@zulip.com abc",
|
|
|
|
];
|
|
|
|
assert.deepEqual(suggestions.strings, expected);
|
|
|
|
});
|