Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/me_message.hbs

21 lines
613 B
Handlebars
Raw Normal View History

refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
<span class="message_sender no-select">
bug fix: Fix hovers for /me messages. This fixes several bugs with /me messages: * We no longer hover name if you're over the message. * We now launch the user popup if you click on the name. * Even if you click on the avatar, we launch the user popup to the right of the name. (I think this is odd, but it's consistent with how we do it for normal messages.) The underlying problem here is that you have two possible organizations. From a logical standpoint, the image and name go together (and both launch the user menu): img Alice | says hi From a physical perspective, the main message is "Alice says hi" and it's aligned differently from the image: img | Alice says hi Our HTML reflects the latter. HTML doesn't allow overlapping diffs, of course, so you have to pick your poison.
2019-03-08 19:14:15 +01:00
<span class="sender_info_hover">
{{partial "message_avatar"}}
</span>
refactor: Extract me_message template. This is for: /me goes to lunch Which renders to something like: <b>Steve Howell</b> goes to lunch [EDITED]
2019-02-23 16:36:03 +01:00
refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
<span class="sender-status">
bug fix: Fix hovers for /me messages. This fixes several bugs with /me messages: * We no longer hover name if you're over the message. * We now launch the user popup if you click on the name. * Even if you click on the avatar, we launch the user popup to the right of the name. (I think this is odd, but it's consistent with how we do it for normal messages.) The underlying problem here is that you have two possible organizations. From a logical standpoint, the image and name go together (and both launch the user menu): img Alice | says hi From a physical perspective, the main message is "Alice says hi" and it's aligned differently from the image: img | Alice says hi Our HTML reflects the latter. HTML doesn't allow overlapping diffs, of course, so you have to pick your poison.
2019-03-08 19:14:15 +01:00
<span class="sender_info_hover sender_name-in-status auto-select" role="button" tabindex="0">{{msg/sender_full_name}}</span>
refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
{{#if sender_is_bot}}
<i class="zulip-icon bot" aria-label="{{t 'Bot' }}"></i>
{{/if}}
<span class="status-message auto-select">
{{{ status_message }}}
</span>
refactor: Extract me_message template. This is for: /me goes to lunch Which renders to something like: <b>Steve Howell</b> goes to lunch [EDITED]
2019-02-23 16:36:03 +01:00
message_list_view: Move edited position conditionals to JS. This adds three bools to message_container object which calculate bools where the "(EDITED)" label should appear: * `edited_in_left_col` -- when label appears in left column. * `edited_alongside_sender` -- when label appears alongside sender info. * `edited_status_msg` -- when label appears for a "/me" message. We use the new bools and remove the complicated if else statements from the templates for the "(EDITED)" label. This also allows us to add a unit test to verify the logic.
2019-03-15 19:42:24 +01:00
{{#if edited_status_msg}}
refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
{{partial "edited_notice"}}
message_list_view: Move edited position conditionals to JS. This adds three bools to message_container object which calculate bools where the "(EDITED)" label should appear: * `edited_in_left_col` -- when label appears in left column. * `edited_alongside_sender` -- when label appears alongside sender info. * `edited_status_msg` -- when label appears for a "/me" message. We use the new bools and remove the complicated if else statements from the templates for the "(EDITED)" label. This also allows us to add a unit test to verify the logic.
2019-03-15 19:42:24 +01:00
{{/if}}
refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
</span>
refactor: Extract me_message template. This is for: /me goes to lunch Which renders to something like: <b>Steve Howell</b> goes to lunch [EDITED]
2019-02-23 16:36:03 +01:00
</span>