2014-01-31 18:53:33 +01:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
from django.conf import settings
|
|
|
|
from django.core.exceptions import ValidationError
|
2016-06-04 20:14:05 +02:00
|
|
|
from django.http import HttpResponse
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-11-06 00:29:55 +01:00
|
|
|
from zerver.forms import email_is_not_mit_mailing_list
|
2014-01-31 18:53:33 +01:00
|
|
|
|
|
|
|
from zerver.lib.rate_limiter import (
|
|
|
|
add_ratelimit_rule,
|
2017-07-31 07:03:52 +02:00
|
|
|
clear_history,
|
2014-01-31 18:53:33 +01:00
|
|
|
remove_ratelimit_rule,
|
2017-07-31 07:03:52 +02:00
|
|
|
RateLimitedUser,
|
2019-03-16 15:46:50 +01:00
|
|
|
RateLimiterLockingException,
|
2014-01-31 18:53:33 +01:00
|
|
|
)
|
2018-08-11 16:26:46 +02:00
|
|
|
from zerver.lib.zephyr import compute_mit_user_fullname
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-11-10 19:30:09 +01:00
|
|
|
from zerver.lib.test_classes import (
|
|
|
|
ZulipTestCase,
|
|
|
|
)
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-04-28 07:17:10 +02:00
|
|
|
import DNS
|
|
|
|
import mock
|
2014-01-31 18:53:33 +01:00
|
|
|
import time
|
|
|
|
|
2017-05-23 02:33:04 +02:00
|
|
|
class MITNameTest(ZulipTestCase):
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_valid_hesiod(self) -> None:
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', return_value=[['starnine:*:84233:101:Athena Consulting Exchange User,,,:/mit/starnine:/bin/bash']]):
|
2017-05-24 21:21:35 +02:00
|
|
|
self.assertEqual(compute_mit_user_fullname(self.mit_email("starnine")), "Athena Consulting Exchange User")
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', return_value=[['sipbexch:*:87824:101:Exch Sipb,,,:/mit/sipbexch:/bin/athena/bash']]):
|
2016-12-16 02:01:34 +01:00
|
|
|
self.assertEqual(compute_mit_user_fullname("sipbexch@mit.edu"), "Exch Sipb")
|
2016-04-28 07:17:10 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_invalid_hesiod(self) -> None:
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', side_effect=DNS.Base.ServerError('DNS query status: NXDOMAIN', 3)):
|
2016-12-16 02:01:34 +01:00
|
|
|
self.assertEqual(compute_mit_user_fullname("1234567890@mit.edu"), "1234567890@mit.edu")
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', side_effect=DNS.Base.ServerError('DNS query status: NXDOMAIN', 3)):
|
2016-12-16 02:01:34 +01:00
|
|
|
self.assertEqual(compute_mit_user_fullname("ec-discuss@mit.edu"), "ec-discuss@mit.edu")
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_mailinglist(self) -> None:
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', side_effect=DNS.Base.ServerError('DNS query status: NXDOMAIN', 3)):
|
2016-11-06 00:29:55 +01:00
|
|
|
self.assertRaises(ValidationError, email_is_not_mit_mailing_list, "1234567890@mit.edu")
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', side_effect=DNS.Base.ServerError('DNS query status: NXDOMAIN', 3)):
|
2016-11-06 00:29:55 +01:00
|
|
|
self.assertRaises(ValidationError, email_is_not_mit_mailing_list, "ec-discuss@mit.edu")
|
2016-11-29 07:22:02 +01:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_notmailinglist(self) -> None:
|
2016-04-28 07:17:10 +02:00
|
|
|
with mock.patch('DNS.dnslookup', return_value=[['POP IMAP.EXCHANGE.MIT.EDU starnine']]):
|
2016-11-06 00:29:55 +01:00
|
|
|
email_is_not_mit_mailing_list("sipbexch@mit.edu")
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-08-23 02:08:42 +02:00
|
|
|
class RateLimitTests(ZulipTestCase):
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2014-01-31 18:53:33 +01:00
|
|
|
settings.RATE_LIMITING = True
|
|
|
|
add_ratelimit_rule(1, 5)
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def tearDown(self) -> None:
|
2014-01-31 18:53:33 +01:00
|
|
|
settings.RATE_LIMITING = False
|
|
|
|
remove_ratelimit_rule(1, 5)
|
|
|
|
|
2019-10-18 16:11:48 +02:00
|
|
|
super().tearDown()
|
|
|
|
|
2018-05-11 01:39:38 +02:00
|
|
|
def send_api_message(self, email: str, content: str) -> HttpResponse:
|
2017-12-14 19:02:31 +01:00
|
|
|
return self.api_post(email, "/api/v1/messages", {"type": "stream",
|
|
|
|
"to": "Verona",
|
|
|
|
"client": "test suite",
|
|
|
|
"content": content,
|
2018-11-10 16:31:08 +01:00
|
|
|
"topic": "whatever"})
|
2016-09-27 21:41:42 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_headers(self) -> None:
|
2017-05-07 19:39:30 +02:00
|
|
|
user = self.example_user('hamlet')
|
|
|
|
email = user.email
|
2017-07-31 07:03:52 +02:00
|
|
|
clear_history(RateLimitedUser(user))
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-09-27 23:27:36 +02:00
|
|
|
result = self.send_api_message(email, "some stuff")
|
2014-01-31 18:53:33 +01:00
|
|
|
self.assertTrue('X-RateLimit-Remaining' in result)
|
|
|
|
self.assertTrue('X-RateLimit-Limit' in result)
|
|
|
|
self.assertTrue('X-RateLimit-Reset' in result)
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_ratelimit_decrease(self) -> None:
|
2017-05-07 19:39:30 +02:00
|
|
|
user = self.example_user('hamlet')
|
|
|
|
email = user.email
|
2017-07-31 07:03:52 +02:00
|
|
|
clear_history(RateLimitedUser(user))
|
2016-09-27 23:27:36 +02:00
|
|
|
result = self.send_api_message(email, "some stuff")
|
2014-01-31 18:53:33 +01:00
|
|
|
limit = int(result['X-RateLimit-Remaining'])
|
|
|
|
|
2016-09-27 23:27:36 +02:00
|
|
|
result = self.send_api_message(email, "some stuff 2")
|
2014-01-31 18:53:33 +01:00
|
|
|
newlimit = int(result['X-RateLimit-Remaining'])
|
|
|
|
self.assertEqual(limit, newlimit + 1)
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_hit_ratelimits(self) -> None:
|
2017-05-07 19:39:30 +02:00
|
|
|
user = self.example_user('cordelia')
|
|
|
|
email = user.email
|
2017-07-31 07:03:52 +02:00
|
|
|
clear_history(RateLimitedUser(user))
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2017-05-06 13:56:02 +02:00
|
|
|
start_time = time.time()
|
2014-01-31 18:53:33 +01:00
|
|
|
for i in range(6):
|
2017-05-06 13:56:02 +02:00
|
|
|
with mock.patch('time.time', return_value=(start_time + i * 0.1)):
|
|
|
|
result = self.send_api_message(email, "some stuff %s" % (i,))
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2014-03-07 16:47:30 +01:00
|
|
|
self.assertEqual(result.status_code, 429)
|
2017-08-17 08:40:19 +02:00
|
|
|
json = result.json()
|
2014-01-31 18:53:33 +01:00
|
|
|
self.assertEqual(json.get("result"), "error")
|
2017-05-22 20:12:59 +02:00
|
|
|
self.assertIn("API usage exceeded rate limit", json.get("msg"))
|
|
|
|
self.assertEqual(json.get('retry-after'), 0.5)
|
2014-03-07 16:47:30 +01:00
|
|
|
self.assertTrue('Retry-After' in result)
|
2017-05-06 13:56:02 +02:00
|
|
|
self.assertEqual(result['Retry-After'], '0.5')
|
2014-01-31 18:53:33 +01:00
|
|
|
|
|
|
|
# We actually wait a second here, rather than force-clearing our history,
|
|
|
|
# to make sure the rate-limiting code automatically forgives a user
|
|
|
|
# after some time has passed.
|
2017-05-06 13:56:02 +02:00
|
|
|
with mock.patch('time.time', return_value=(start_time + 1.0)):
|
2016-12-08 23:08:39 +01:00
|
|
|
result = self.send_api_message(email, "Good message")
|
2014-01-31 18:53:33 +01:00
|
|
|
|
2016-12-08 23:08:39 +01:00
|
|
|
self.assert_json_success(result)
|
2019-03-16 15:46:50 +01:00
|
|
|
|
2019-03-23 18:33:37 +01:00
|
|
|
@mock.patch('zerver.lib.rate_limiter.logger.warning')
|
|
|
|
def test_hit_ratelimiterlockingexception(self, mock_warn: mock.MagicMock) -> None:
|
2019-03-16 15:46:50 +01:00
|
|
|
user = self.example_user('cordelia')
|
|
|
|
email = user.email
|
|
|
|
clear_history(RateLimitedUser(user))
|
|
|
|
|
2019-03-23 18:33:37 +01:00
|
|
|
with mock.patch('zerver.lib.rate_limiter.incr_ratelimit',
|
2019-03-16 15:46:50 +01:00
|
|
|
side_effect=RateLimiterLockingException):
|
|
|
|
result = self.send_api_message(email, "some stuff")
|
|
|
|
self.assertEqual(result.status_code, 429)
|
2019-03-23 18:33:37 +01:00
|
|
|
mock_warn.assert_called_with("Deadlock trying to incr_ratelimit for RateLimitedUser:Id: %s"
|
|
|
|
% (user.id,))
|