Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/night_mode.js

14 lines
386 B
JavaScript
Raw Normal View History

cleanup: Remove unnecessary 'magic' style for night mode. This was introduced in e0236646 For 1.5 years we did not find a case that needed it (besides the `a` tag hover state, that is not obvious if it was needed or it was used as an example) It is not obvious if this solution was a good idea. The concern was that `body.night-mode` is more specific than `body` and some styles might override others less specific in cases we might not want that. Of course, we want that in the majority of cases, and css-specificity rules are not simple to comprehend. Good further reading: http://cssspecificity.com/ https://specificity.keegan.st/ The added complexity of the resulting styles and the added code that might not serve any practical purpose seem to not be worth it.
2019-03-07 18:09:20 +01:00
exports.enable = function () {
settings: Add automatic theme detection feature. With this implementation of the feature of the automatic theme detection, we make the following changes in the backend, frontend and documentation. This replaces the previous night_mode boolean with an enum, with the default value being to use the prefers-color-scheme feature of the operating system to determine which theme to use. Fixes: #14451. Co-authored-by: @kPerikou <44238834+kPerikou@users.noreply.github.com>
2020-05-16 13:13:59 +02:00
$("body").removeClass("color-scheme-automatic").addClass("night-mode");
cleanup: Remove unnecessary 'magic' style for night mode. This was introduced in e0236646 For 1.5 years we did not find a case that needed it (besides the `a` tag hover state, that is not obvious if it was needed or it was used as an example) It is not obvious if this solution was a good idea. The concern was that `body.night-mode` is more specific than `body` and some styles might override others less specific in cases we might not want that. Of course, we want that in the majority of cases, and css-specificity rules are not simple to comprehend. Good further reading: http://cssspecificity.com/ https://specificity.keegan.st/ The added complexity of the resulting styles and the added code that might not serve any practical purpose seem to not be worth it.
2019-03-07 18:09:20 +01:00
};
exports.disable = function () {
settings: Add automatic theme detection feature. With this implementation of the feature of the automatic theme detection, we make the following changes in the backend, frontend and documentation. This replaces the previous night_mode boolean with an enum, with the default value being to use the prefers-color-scheme feature of the operating system to determine which theme to use. Fixes: #14451. Co-authored-by: @kPerikou <44238834+kPerikou@users.noreply.github.com>
2020-05-16 13:13:59 +02:00
$("body").removeClass("color-scheme-automatic").removeClass("night-mode");
};
exports.default_preference_checker = function () {
$("body").removeClass("night-mode").addClass("color-scheme-automatic");
cleanup: Remove unnecessary 'magic' style for night mode. This was introduced in e0236646 For 1.5 years we did not find a case that needed it (besides the `a` tag hover state, that is not obvious if it was needed or it was used as an example) It is not obvious if this solution was a good idea. The concern was that `body.night-mode` is more specific than `body` and some styles might override others less specific in cases we might not want that. Of course, we want that in the majority of cases, and css-specificity rules are not simple to comprehend. Good further reading: http://cssspecificity.com/ https://specificity.keegan.st/ The added complexity of the resulting styles and the added code that might not serve any practical purpose seem to not be worth it.
2019-03-07 18:09:20 +01:00
};
js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-10-25 09:45:13 +02:00
window.night_mode = exports;