Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/settings_sections.js

85 lines
2.7 KiB
JavaScript
Raw Normal View History

dict: Replace with Map. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 09:39:58 +01:00
const load_func_dict = new Map(); // group -> function
settings_sections: Replace is_loaded Dict with loaded_groups Set. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-01 04:50:07 +01:00
const loaded_groups = new Set();
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
exports.get_group = function (section) {
// Sometimes several sections all share the same code.
switch (section) {
case 'organization-profile':
case 'organization-settings':
case 'organization-permissions':
case 'auth-methods':
return 'org_misc';
case 'bot-list-admin':
bot settings: Load bots independently. We no longer use `/json/users` in the codepath for bot settings (admin side). We also specifically don't load human users when we load bots, so you no longer have to pay for the server round trip as a side effect of loading bots. Instead, there is a dedicated `set_up_bots` entry point. We also get the bot ids directly from `bot_data` now. This commit, to some degree, builds on the prior commit that had us hydrate data from `people.js` instead of the payload from `/json/users`.
2020-05-09 20:06:14 +02:00
return 'org_bots';
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
case 'user-list-admin':
case 'deactivated-users-admin':
return 'org_users';
default:
return section;
}
};
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
exports.initialize = function () {
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
// personal
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
load_func_dict.set('your-account', settings_account.set_up);
load_func_dict.set('display-settings', settings_display.set_up);
load_func_dict.set('notifications', settings_notifications.set_up);
load_func_dict.set('your-bots', settings_bots.set_up);
load_func_dict.set('alert-words', alert_words_ui.set_up_alert_words);
load_func_dict.set('uploaded-files', attachments_ui.set_up_attachments);
load_func_dict.set('muted-topics', settings_muting.set_up);
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
// org
load_func_dict.set('org_misc', settings_org.set_up);
bot settings: Load bots independently. We no longer use `/json/users` in the codepath for bot settings (admin side). We also specifically don't load human users when we load bots, so you no longer have to pay for the server round trip as a side effect of loading bots. Instead, there is a dedicated `set_up_bots` entry point. We also get the bot ids directly from `bot_data` now. This commit, to some degree, builds on the prior commit that had us hydrate data from `people.js` instead of the payload from `/json/users`.
2020-05-09 20:06:14 +02:00
load_func_dict.set('org_bots', settings_users.set_up_bots);
load_func_dict.set('org_users', settings_users.set_up_humans);
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
load_func_dict.set('emoji-settings', settings_emoji.set_up);
load_func_dict.set('default-streams-list', settings_streams.set_up);
settings: Rename "settings_filters" to "settings_linkifiers". This makes the JS codebase match the UI for how to describe this feature. No user-facing effect.
2018-12-17 21:28:25 +01:00
load_func_dict.set('filter-settings', settings_linkifiers.set_up);
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
load_func_dict.set('invites-list-admin', settings_invites.set_up);
load_func_dict.set('user-groups-admin', settings_user_groups.set_up);
load_func_dict.set('profile-field-settings', settings_profile_fields.set_up);
data export: Add UI to trigger data export. This commit serves as the frontend piece for the "public export" webapp feature. Fixes: #11930
2019-04-09 21:49:07 +02:00
load_func_dict.set('data-exports-admin', settings_exports.set_up);
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
};
exports.load_settings_section = function (section) {
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const group = exports.get_group(section);
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
if (!load_func_dict.has(group)) {
admin/settings: Lazy-load Organization sections. We now wait to load Organization sections until you click on the section (or virtually click by using arrow keys). Some of the sections are coupled in terms of their setup, so some sections will already be loaded if you had clicked on a related section.
2017-04-17 16:51:27 +02:00
blueslip.error('Unknown section ' + section);
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
return;
}
settings_sections: Replace is_loaded Dict with loaded_groups Set. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-01 04:50:07 +01:00
if (loaded_groups.has(group)) {
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
// We only load groups once (unless somebody calls
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
// reset_sections).
return;
}
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const load_func = load_func_dict.get(group);
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
// Do the real work here!
load_func();
settings_sections: Replace is_loaded Dict with loaded_groups Set. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-01 04:50:07 +01:00
loaded_groups.add(group);
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
};
exports.reset_sections = function () {
settings_sections: Replace is_loaded Dict with loaded_groups Set. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-01 04:50:07 +01:00
loaded_groups.clear();
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
settings_emoji.reset();
data export: Add UI to trigger data export. This commit serves as the frontend piece for the "public export" webapp feature. Fixes: #11930
2019-04-09 21:49:07 +02:00
settings_exports.reset();
settings: Rename "settings_filters" to "settings_linkifiers". This makes the JS codebase match the UI for how to describe this feature. No user-facing effect.
2018-12-17 21:28:25 +01:00
settings_linkifiers.reset();
settings: Eliminate admin_sections module. We move all of its logic into settings_sections. Note that this is slightly more than a refactor. We are slightly more aggressive about resetting sections. For example, if you go into Settings, then exit the overlay, then go into Manage Organization, we will now reset sections for both groups.
2018-12-08 19:28:26 +01:00
settings_invites.reset();
settings_org.reset();
settings_profile_fields.reset();
settings_streams.reset();
settings_user_groups.reset();
muted_topics: Rerender list only if modal is opened and section is loaded. We should rernder the muted topics list in settings only if the settings modal is opened and the muted topics section is loaded.
2020-07-12 00:13:47 +02:00
settings_muting.reset();
user settings: Remove reset/meta.loaded logic. We don't really need to know whether we've loaded the user-related panels, since we only used `meta.loaded` for a tiny optimization to avoid a jQuery lookup. We rely mostly on the list widgets from `list_render`, and they are smart enough to repopulate themselves when they're called subsequent times.
2020-05-09 20:20:26 +02:00
// settings_users doesn't need a reset()
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
};
js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-10-25 09:45:13 +02:00
window.settings_sections = exports;