Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/.eslintrc.json

377 lines
11 KiB
JSON
Raw Normal View History

Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
{
"env": {
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
"node": true,
"es6": true
},
"parserOptions": {
"sourceType": "module"
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
},
"globals": {
"$": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"_": false,
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
"run_test": false,
Add a schema checking concept to the web app. This starts the concept of a schema checker, similar to zerver/lib/validator.py on the server. We can use this to validate incoming data. Our server should filter most of our incoming data, but it's useful to have client-side checking to defend against things like upgrade regressions (i.e. what if we change the name of the field on the server side without updating all client uses).
2018-05-22 21:50:24 +02:00
"schema": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"jQuery": false,
"Spinner": false,
"Handlebars": false,
"XDate": false,
"zxcvbn": false,
"SockJS": false,
"marked": false,
Calculate gravatar hashes on the webapp client. This change prepares us to have the server send avatar_url of None when somebody wants a gravatar avatar (as opposed to a user-uploaded one). Subsequent commits will change behavior on both the server and client to have this happen. So this commit has no-op code for now, but it will soon use the fallback-to-gravatar logic.
2017-11-03 17:25:47 +01:00
"md5": false,
Add moment.js third-party module via npm. This is needed for timezone manipulations. We may be able to replace XDate with it in the future as well.
2017-04-02 00:07:03 +02:00
"moment": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"i18n": false,
Add ability to pan and zoom lightbox images. This adds the ability to pan and zoom lightbox images because they are now converted to <canvas> elements.
2017-06-08 22:58:15 +02:00
"LightboxCanvas": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"bridge": false,
"page_params": false,
Add support for managing and deleting attachments. Modified substantially by tabbott to fix tons of issues. Fixes #454.
2016-12-28 14:46:42 +01:00
"attachments_ui": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"csrf_token": false,
page load: Make initializations more explicit. We now initialize most modules in ui_init.js, which isn't the perfect place to do it, but at least now we have a mostly consolidated entry point. All the new foo.initialize() methods introduced in this module run the same order relative to each other as before this commit. (I did some console logging with a hacked version of the program to get the order right.) They happen a bit later than before, though. A couple modules still have the `$(function() {` idiom for miscellaneous reasons: archive - is a different bundle common - used elsewhere list_render - non-standard code style scroll_bar - no exports setup - probably special? socket - $(function () is nested! transmit - coupled to socket translations - i18n is a bigger problem ui_init - this bootstraps everything
2018-05-15 22:03:14 +02:00
"copy_and_paste": false,
"click_handlers": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"typeahead_helper": false,
Add typeahead for syntax highlighting languages. Modified composebox_typeahead.js to recognize the triple backtick and tilde for code blocks, and added appropriate typeahead functions in that file and in typeahead_helper.js. Additionally, a new file pygments_data.js contains a dictionary of the supported languages, mapping to relative popularity rankings. These rankings determine the order of sort of the languages in the typeahead. This JavaScript file is actually in static/generated/pygments_data.js, as it is generated by a Python script, tools/build_pymgents_data.py. This is so that if Pygments adds support for new languages, the JavaScript file will be updated appropriately. This python script uses a set of popularity rankings defined in lang.json. Corresponding unit tests were also added. Fixes #4111.
2017-04-26 09:32:46 +02:00
"pygments_data": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"popovers": false,
"server_events": false,
Split out server_events_dispatch.js from server_events.js.
2017-05-31 08:53:09 +02:00
"server_events_dispatch": false,
Extract message_scroll.js. This mostly moves code from ui.js. We change the arguments to `message_fetch.load_more_messages()` to be `opts` with callbacks for `show_loading` and `hide_loading`. We also defer starting the scroll handler until `message_fetch.js` has been initialized.
2018-03-08 20:18:36 +01:00
"message_scroll": false,
Add keydown_util.js module. This is a pretty thin abstraction to prevent having to put magic numbers in code, doing the which/keyCode hack, and remembering to all preventDefault. Hopefully we'll expand it to handle things like shift/alt keys for components that want their own keyboard handlers (vs. going through hotkey.js).
2018-04-04 16:36:49 +02:00
"keydown_util": false,
Extract info_overlay.js. There are several ways we open help for keyboard shortcuts, markdown help, and search operators. - from the gear menu - from the compose box - from the search box - hitting ? for keyboard help - arrowing/clicking through the tabs This just moves the relevant code into a module and changes a bunch of one-line calls in various places.
2018-03-30 14:09:11 +02:00
"info_overlay": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"ui": false,
Add ui_report shim.
2017-03-18 21:17:41 +01:00
"ui_report": false,
night-mode: Add custom CSS through JS. This adds custom CSS through JavaScript for things that do not scope well and will override other inherited styles. This should ONLY be used for problematic CSS that has no obvious or easy CSS-only solution. (Specifically, we need this for the "default link" styling, which is hard to override because we don't want to start winning ties due to specificity that we would not have won in the light theme).
2017-11-30 02:31:21 +01:00
"night_mode": false,
Extract js/ui_util.js.
2017-03-18 21:35:35 +01:00
"ui_util": false,
js: Extract lightbox.js from ui.js.
2017-03-18 00:50:39 +01:00
"lightbox": false,
input-pill: Add "input_pill" class and documentation.
2017-10-24 20:15:35 +02:00
"input_pill": false,
pills: Streamline input pills (for user groups). The main point of this change is to streamline the core code for input pills, and we use also modify user groups. The main change to input_pill.js is that you now configure a function called `create_item_from_text`, and that can return an arbitrary object, and it just needs a field called `display_value`. Other changes: * You now call `input.create(opts)` to create the widget. * There is no longer a cache, because we can write smarter code in typeahead `source` functions that exclude ids up front. * There is no value/optinalKey complexity, because the calling code can supply arbitrary objects and do their own external data management on the pill items. * We eliminate `prependPill`. * We eliminate `data`, `keys`, and `values`, and just have `items`.
2018-03-06 15:03:20 +01:00
"user_pill": false,
compose: Add pills for typing in PM recipients. @brockwhittaker wrote the original prototype for having pills in the recipient box when users compose PMs (either 1:1 or huddle). The prototype was test deloyed on our main realm for several weeks. This commit includes all the original CSS and HTML from the prototype. After some things changed with the codebase after the initial test deployment, I made the following changes: * In prior commits I refactored out a module called `user_pill.js` that implemented some common functions against a more streamlined version of `input_pill.js`, and this commit largely integrates with that. * I made changes in a prior commit to handle Zephyr semantics (emails don't get validated) and tested this commit with zephyr. * I fixed a reload bug by extracting code out to `compose_pm_pill.js` and re-ordering some calls to `initialize`. There are still two flaws related to un-pill-ified text in the input: * We could be more aggressive about trying to pill-ify emails when you blur or tab away. * We only look at the pills when you send the message, instead of complaining about the un-pill-ified text. (Some folks may consider that a feature, but it's probably surprising to others.)
2018-03-06 15:07:55 +01:00
"compose_pm_pill": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"stream_color": false,
"people": false,
user-groups: Create static/js/user_groups.js.
2017-11-07 08:58:46 +01:00
"user_groups": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"navigate": false,
compose: Preserve links when pasting html. This uses the to-markdown.js library to do all the hard work of parsing HTML and turning it into markdown and not e.g. uploaded files. Tweaked by tabbott to better scope when it activates to just include pastes of HTML content. Fixes #5853.
2017-10-06 10:46:08 +02:00
"toMarkdown": false,
refactor: Extract settings_panel_menu.js.
2018-06-03 17:29:11 +02:00
"settings_panel_menu": false,
refactor: Extract settings_toggle.js. This mostly moves code, and we also abandon the lookup mechanism for finding our toggler.
2018-04-14 16:06:51 +02:00
"settings_toggle": false,
Extract settings_account.js. This code handles the settings pane for "Your account," which has email/name/password/avatar/etc.
2017-04-06 02:28:57 +02:00
"settings_account": false,
Extract settings_display.js
2017-04-06 15:34:42 +02:00
"settings_display": false,
Extract settings_notifications.js.
2017-04-06 16:01:07 +02:00
"settings_notifications": false,
Extract settings_muting.js.
2017-04-06 16:56:52 +02:00
"settings_muting": false,
Extract settings_bots.js.
2017-04-06 22:47:27 +02:00
"settings_bots": false,
settings: Lazy-load settings sections. For the settings UI, we now wait until a user goes to a particular settings section before calling the appropriate function to set up the section (which usually involves setting up click handlers and populating initial data).
2017-04-07 01:30:13 +02:00
"settings_sections": false,
Extract settings_emoji.js.
2017-04-08 17:24:07 +02:00
"settings_emoji": false,
Extract settings_org.js (and fix live updates). This is mostly moving code, but we do add short-circuit logic for some live-updating methods here. Note that this affects two different sections of the admin app: * Organization settings * Authentication methods We really want to move to one module per section, but there is some legacy coupling that makes this difficult for now.
2017-04-08 18:13:39 +02:00
"settings_org": false,
static/js: Add `settings_ui.js` file for common settings UI functions.
2018-03-03 06:16:55 +01:00
"settings_ui": false,
Extract settings_users.js. This affects three admin sections: * Users * Deactivated users * Bots
2017-04-08 20:08:35 +02:00
"settings_users": false,
Extract settings_streams.js.
2017-04-08 21:02:08 +02:00
"settings_streams": false,
Extract settings_filters.js.
2017-04-08 23:24:03 +02:00
"settings_filters": false,
Add UI for viewing and cancelling open Zulip invitations. Lets administrators view a list of open(unconfirmed) invitations and resend or revoke a chosen invitation. There are a few changes that we can expect for the future: * It is currently possible to invite an email that you have already invited, it might make sense to change this behavior. * Resend currently sends an invite reminder instead of resending the original invite, this is because 'custom_body' was not stored when the first invite was sent. Tweaked in various minor ways, primarily in the backend, by tabbott, mostly for style consistency with the rest of the codebase. Fixes: #1180.
2017-10-21 03:15:12 +02:00
"settings_invites": false,
org settings: Add framework for User groups page.
2017-11-13 05:20:42 +01:00
"settings_user_groups": false,
settings: Add support for adding/removing custom profile fields. Now that we have support for displaying custom profile fields, this adds administrator-level support for creating them. Tweaked by tabbott to fix a few small bugs and clean up the commit message. Fixes #1760.
2017-12-14 05:51:45 +01:00
"settings_profile_fields": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"settings": false,
"resize": false,
"loading": false,
Add typing notifications front end. Send typing notification events when user types in the compose box. Listen for these events and display a notification. Sending notifications: Notifications are throttled, so that start notifications are sent every 10 seconds of active typing, and stop notifications are sent 5 seconds after active typing stops or when the compose box is closed. Displaying notifications: When a typing notification is received, if the current narrow is private messages or is: pm-with and the user is not the sender, "Othello is typing..." is displayed underneath the last message. This notification is removed after 15 seconds. If another notification is received during this period, the expiration is extended. When a stop notification is received the notification is removed. Internally, a list of users currently typing is maintained for each conversation (in a dict). When an event is received the list (for the appropriate conversation) is updated and the notifications template is re-rendered based on the narrow information. This template is also re-rendered when the narrow changes. Significantly modified by tabbott for clarity. Fixes #150.
2016-10-12 20:57:59 +02:00
"typing": false,
Extract typing_events.js.
2017-03-22 15:11:41 +01:00
"typing_events": false,
Add typing_data.js, which can track users who are typing. (A subsequent commit will actually integrate this into the app.)
2017-03-21 17:45:10 +01:00
"typing_data": false,
Revamp state tracking for outbound typing indicators. This change moves most of the logic related to starting and stopping outbound typing indicators to a new module called typing_status.js that is heavily unit tested. While this was in some sense a rewrite, the logic was mostly inspired by the existing code. This change does fix one known bug, which is that when we were changing recipients before (while typing was active), we were not stopping and starting typing indicators. This was a fairly minor bug, since usually users leave the compose box to change recipients, and we would do stop/start under that scenario. Now we also handle the case where the user does not leave the compose box to change recipients.
2017-03-22 00:41:09 +01:00
"typing_status": false,
sending messages: Extract sent_messages.js. This commit extract send_messages.js to clean up code related to the following things: * sending data to /json/report_send_time * restarting the event loop if events don't arrive on time The code related to /json/report changes the following ways: * We track the state almost completely in the new send_messages.js module, with other modules just making one-line calls. * We no longer send "displayed" times to the servers, since we were kind of lying about them anyway. * We now explicitly track the state of each single sent message in its own object. * We now look up data related to the messages by local_id, instead of message_id. The problem with message_id was that is was mutable. Now we use local_id, and we extend the local_id concept to messages that don't get rendered client side. We no longer need to react to the 'message_id_changed' event to change our hash key. * The code used to live in many places: * various big chunks were scattered among compose.js, and those were all moved or reduced to one-line calls into the new module * echo.js continues to make basically one-line calls, but it no longer calls compose.report_as_received(), nor does it set the "start" time. * message_util.js used to report received events, but only when they finally got drawn in the home view; this code is gone now The code related to restarting the event loop if events don't arrive changes as follows: * The timer now gets set up from within send_messages.message_state.report_server_ack, where we can easily inspect the current state of the possibly-still-in-flight message. * The code to confirm that an event was received happens now in server_events.js, rather than later, so that we don't falsely blame the event loop for a downstream bug. (Plus it's easier to just do it one place.) This change removes a fair amount of code from our node tests. Some of the removal is good stuff related to us completing killing off unnecessary code. Other removals are more expediency-driven, and we should make another sweep at ramping up our coverage on compose.js, with possibly a little more mocking of the new `send_messages` code layer, since it's now abstracted better. There is also some minor cleanup to echo.resend_message() in this commit. See #5968 for a detailed breakdown of the changes.
2017-07-30 12:56:46 +02:00
"sent_messages": false,
refactor: Extract transmit.js from compose.js. We now isolate the code to transmit messages into transmit.js. It is stable code that most folks doing UI work in compose.js don't care about the details of, so it's just clutter there. Also, we may soon have other widgets than the compose box that send messages. This change mostly preserves test coverage, although in some cases we stub at a higher level for the compose path (this is a good thing). Extracting out transmit.js allows us to lock down 100% coverage on that file.
2018-02-20 13:08:50 +01:00
"transmit": false,
slash commands: Add /ping command (via zcommand). This adds a /ping command that will be useful for users to see what the round trip to the Zulip server is (including only a tiny bit of actual server time to basically give a 200). It also introduce the "/zcommand" endpoint and zcommand.js module.
2018-06-02 13:59:02 +02:00
"zcommand": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"compose": false,
Add compose_actions.start() shim.
2017-03-18 17:41:47 +01:00
"compose_actions": false,
Add compose_state.has_message_content() shim.
2017-03-18 18:10:37 +01:00
"compose_state": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"compose_fade": false,
ui-refactor: Rename modals.js to overlays.js. Fixed #4702.
2017-05-27 15:40:54 +02:00
"overlays": false,
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
"stream_create": false,
Extract stream_edit.js. This code makes the right pane work in "Manage Streams" when you are editing a stream subscription. It handles basic functionality (submitting forms, etc.), live updates, and showing the pane as needed. Most of the code here was simply moved from subs.js, but some functions were pulled out of larger functions: live update: add_me_to_member_list update_stream_name update_stream_description collapse/show: collapse show_sub We also now export subs.show_subs_pane. We eventually want stream_edit not to call into subs.js, and this should be fairly easy--we just need to move some shared methods to a new module.
2017-04-24 04:11:25 +02:00
"stream_edit": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"subs": false,
Extract stream_muting.js.
2017-03-19 16:00:35 +01:00
"stream_muting": false,
Extract stream_events.js
2017-03-19 16:03:07 +01:00
"stream_events": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"timerender": false,
Use stream id to live-update messages for name changes. When we change a stream name, we now use the stream id as the key to find messages we need to live update. This eliminates some possible race conditions from two users renaming a stream. This commit introduces message_live_update.js. The new call stack is this: subs.update_subscription_properties subs.update_stream_name message_live_update.update_stream_name message_list.update_stream_name
2017-01-05 17:34:27 +01:00
"message_live_update": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"message_edit": false,
"reload": false,
"composebox_typeahead": false,
"search": false,
"topic_list": false,
Add topic_generator.js to the app.
2017-04-21 20:42:10 +02:00
"topic_generator": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"gear_menu": false,
"hashchange": false,
Add hash_util.encodeHashComponent() shim.
2017-03-18 18:29:20 +01:00
"hash_util": false,
Add FetchStatus class. We will use this in subsequent commits to replace the `load_more_enabled` flag.
2018-03-09 22:04:07 +01:00
"FetchStatus": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"message_list": false,
"Filter": false,
datetimepicker: Add flatpickr lib as dependancy.
2018-01-12 23:15:17 +01:00
"flatpickr": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"pointer": false,
"util": false,
refactor: Extract MessageListData class. Most of this was straightforward. Most functions that were grabbed verbatim and whole from the original class still have one-line wrappers. Many functions are just-the-data versions of functions that remain in MessageList: see add, append, prepend, remove as examples. In a typical pattern the MessageList code becomes super simple: prepend: function MessageList_prepend(messages) { var viewable_messages = this.data.prepend(messages); this.view.prepend(viewable_messages); }, Two large functions had some minor surgery: triage_messages = top half of add_messages + API to pass three lists back change_message_id = original version + two simple callbacks to list For the function update_muting_and_rerender(), we continue to early-exit if this.muting_enabled is false, and we copied that same defensive check to the new function named update_items_for_muting(), even though it's technically hidden from that codepath by the caller.
2018-05-04 12:44:28 +02:00
"MessageListData": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"MessageListView": false,
"blueslip": false,
"rows": false,
"WinChan": false,
"muting_ui": false,
"Socket": false,
"channel": false,
eslint: Add components.js module to globals list.
2016-12-04 03:02:03 +01:00
"components": false,
refactor: Extract scroll_util.js. We now use scroll_element_into_container() in two different places, so it's worth extracting.
2018-04-24 14:09:16 +02:00
"scroll_util": false,
js: Rename viewport.js to message_viewport.js. This fixes the mobile web experience for Chrome on iOS. Apparently, Chrome-on-iOS silently has a `viewport` module that overrides and user-defined module by that name, causing all of our code that accesses the viewport module to not work on that platform. We fix this by renaming it.
2017-03-10 23:48:51 +01:00
"message_viewport": false,
realm-icon: Move upload widget to separate file. This makes it possible to use the upload widget in the realm icon organization settings on frontend.
2017-02-21 03:15:22 +01:00
"upload_widget": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"avatar": false,
realm-icon: Add realm icon feature. - Add realm icon fields to realm model. - Add migration for new realm model's field. - Add views for icon uploading and deleting. - Add routes for realm icons views. - Add JS widget for realm icon upload setting. - Add realm icon upload to administration organization setting. - Add tests for realm icons. Fixes #3660.
2017-02-21 03:41:20 +01:00
"realm_icon": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"feature_flags": false,
"search_suggestion": false,
"notifications": false,
"message_flags": false,
"bot_data": false,
Extract top_left_corner.js. Here are the functions in top_left_corner: get_global_filter_li: pure code move update_count_in_dom: simplifed copy of similar function in stream_list.js update_dom_with_unread_counts: pure code move, split out from function of same name in stream_list.js delselect_top_left_corner_items: pure code move handle_narrow_activated: pure code move + rename handle_narrow_deactivated: pure code move, split out from from function of smae name in stream_list.js
2017-08-12 17:26:12 +02:00
"top_left_corner": false,
Extract stream_sort.js.
2017-04-18 17:08:59 +02:00
"stream_sort": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"stream_list": false,
refactor: Extract stream_popover.js. This module handles the popovers in the stream list--one for stream actions and another for topic-specific actions. The extraction was mostly straightforward, but I did move some of the code related to the color picker to be more consistent with how I organized the other click handlers.
2017-03-05 17:28:40 +01:00
"stream_popover": false,
Extract narrow_state.js. Despite the length of this commit, it is a very straightforward moving of code from narrow.js -> narrow_state.js, and then everything else is just s/narrow.foo()/narrow_state.foo()/ (with a few tiny cleanups to remove some code duplication in certain callers). The only new functions are simple setter/getters that encapsulate the current_filter variable: narrow_state.reset_current_filter() narrow_state.set_current_filter() narrow_state.get_current_filter() We removed narrow.predicate() as part of this, since it was dead code. Also, we removed the shim for narrow_state.set_compose_defaults(), and since that was the last shim, we removed shim.js from the app.
2017-04-25 15:25:31 +02:00
"narrow_state": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"narrow": false,
admin/settings: Lazy-load Organization sections. We now wait to load Organization sections until you click on the section (or virtually click by using arrow keys). Some of the sections are coupled in terms of their setup, so some sections will already be loaded if you had clicked on a related section.
2017-04-17 16:51:27 +02:00
"admin_sections": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"admin": false,
"stream_data": false,
Extract topic_data.js. This new module tracks the recent topic names for any given stream. The code was pulled over almost verbatim from stream_data.js, with minor renames to the function names. We introduced a minor one-line function called stream_has_topics.
2017-07-24 18:22:37 +02:00
"topic_data": false,
Extract list_util.js for navigating lists. The code here used to live in hotkey.js. Its complicated calling protocol made it difficult to unit test. We are also trying to slim down hotkey.js. Our arrow navigation for things like `#stream_filters` has always been kind of awkward, since it's difficult to get the focus to their list items. This commit does nothing to fix that yet.
2017-04-04 18:14:27 +02:00
"list_util": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"muting": false,
"Dict": false,
"unread": false,
"alert_words_ui": false,
"message_store": false,
Extract message_util.js
2017-03-19 22:43:38 +01:00
"message_util": false,
Extract message_events.js.
2017-03-19 20:23:48 +01:00
"message_events": false,
Extract message_fetch.js.
2017-03-19 18:19:48 +01:00
"message_fetch": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"favicon": false,
"condense": false,
frontend: Implement list_render class. This implements a list_render closure class that allows for progressive, responsive rendering of long, scrollable lists, with filtering support. It isn't used, at present.
2017-03-16 21:00:56 +01:00
"list_render": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"floating_recipient_bar": false,
"tab_bar": false,
"emoji": false,
Extract presence.js to track presence info. Most of this code was simply moved from activity.js with some minor renaming of functions like set_presence_info -> set_info. Some functions were slightly nontrivial extractions: is_not_offline: came from activity.huddle_fraction_present get_status/get_mobile: simple getters set_user_status: partial extraction from activity.set_user_status last_active_date: pulled out of admin.js code We also fixed activity.filter_and_sort to take user_ids.
2017-03-30 20:04:01 +02:00
"presence": false,
buddy list: Extract user_search.js. This was a bit more than moving code. I extracted the following things: $widget (and three helper methods) $input text() empty() expand_column close_widget activity.clear_highlight There was a minor bug before this commit, where we were inconsistent about trimming spaces. The introduction of text() and empty() should prevent bugs where users type the space bar into search.
2018-04-19 17:47:41 +02:00
"user_search": false,
buddy list: Extract buddy_data.js.
2018-04-19 15:46:56 +02:00
"buddy_data": false,
buddy list: Extract buddy_list.js.
2018-04-19 14:17:22 +02:00
"buddy_list": false,
buddy list: Fix and simplify up/down navigation. This introduces a generic class called list_cursor to handle the main details of navigating the buddy list and wires it into activity.js. It replaces some fairly complicated code that was coupled to stream_list and used lots of jQuery. The new code interacts with the buddy_list API instead of jQuery directly. It also persists the key across redraws, so we don't lose our place when a focus ping happens or we type more characters. Note that we no longer cycle to the top when we hit the bottom, or vice versa. Cycling can be kind of an anti-feature when you want to just lay on the arrow keys until they hit the end. The changes to stream_list.js here do not affect the left sidebar; they only remove code that was used for the right sidebar.
2018-04-21 14:59:03 +02:00
"list_cursor": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"activity": false,
"invite": false,
"colorspace": false,
Add frontend support for emoji reactions. This commit replaces the placeholder "clipboard" button with a reaction button. This is done on any message that can't be edited. Also, on messages sent by the user the actions popover (toggled by the down chevron icon) contains an option to add a reaction. When clicked, a popover with a search bar and a list of emojis is displayed. If the right sidebar is collapsed (the viewport is small), the popover is placed to the left of the button. Focus is set to the search bar. Typing in the search bar filters emojis. Emojis with which the user has reacted to this message are highlighted. Clicking them sends an API request to remove that reaction. Clicking on non-highlighted emojis sends an API request to add a reaction. When the popover loses focus it is closed. The frontend listens for reaction events. When an add-reaction event is received, the emoji is displayed at the bottom of the message with a count initialized to 1. If there was an existing reaction to the message with the same emoji, the count is incremented. Old messages fetched from the server contain reactions. They are displayed (along with title and count) at the bottom of each message. When clicking the emoji reaction at the bottom of the message, if the user has already reacted with that emoji to this message, the reaction is removed and the count is decremented. Otherwise, a reaction is added and the count is incremented. Hovering over the emoji reaction at the bottom of the message displays a list of users who have reacted with this emoji along with the emoji name. Hovering over the emoji reactions at the bottom of the message displays a button to add a reaction. Fixes #541.
2016-12-02 13:23:23 +01:00
"reactions": false,
reminders: Refactor relevant code to live in a separate reminder.js.
2018-02-06 22:54:53 +01:00
"reminder": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"tutorial": false,
"templates": false,
"alert_words": false,
"fenced_code": false,
Split out markdown.js from echo.js. The new module handles markdown rendering. The code left behind in echo.js does local-echo kind of things like reifying message ids.
2017-05-09 18:01:43 +02:00
"markdown": false,
Extract local_message.js. We will eventually want these functions to support things other than local echo, such as ephemeral messages from chat bots.
2018-02-24 13:42:27 +01:00
"local_message": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"echo": false,
"localstorage": false,
Add a LocalStorage wrapper for Zulip. This is a wrapper that allows for versioning and migrations with localStorage along with safe storage of data that respects data types.
2016-12-28 02:14:31 +01:00
"localStorage": false,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"current_msg_list": true,
"home_msg_list": false,
"pm_list": false,
typeahead: Add pm_conversations module. In pm_conversations.js, added function to make a user a PM partner and another function to check if a user is a PM partner. A PM partner is someone with whom the user has been in a PM with.
2017-06-01 07:46:23 +02:00
"pm_conversations": false,
typeahead: Add recent_senders module. In recent_senders module, added a data structure to hold timestamps of users' latest message in a topic. Also added a function to compare 2 users based on above timestamp. Added a function to process messages for the data structure and a call in add_message_metadata. Also added node tests for insertion of data into recent_senders.senders.
2017-06-01 07:42:57 +02:00
"recent_senders": false,
Add /stats page with basic stats graph. Adds a new url route and a new json endpoint.
2016-12-20 02:30:08 +01:00
"unread_ui": false,
refactor: Extract unread_ops.js This module mostly contains the mark_* functions that update the server with info about unread counts.
2017-03-18 01:41:56 +01:00
"unread_ops": false,
refactor: Extract upload mechanics to new JS module. Tweaked by tabbott to move changes from the next commit that are required for this to pass tests into this commit. Note that this exports a few items that were not previously exported.
2017-11-23 15:00:05 +01:00
"upload": false,
Extract user_events.js. This moves people.update() to user_events.person(). We now also use user_id as the key for finding person objects in people.js (instead of email).
2017-01-21 16:49:27 +01:00
"user_events": false,
Add poll widget.
2018-02-23 15:54:07 +01:00
"voting_widget": false,
Add tictactoe widget. Thanks to @amanagr for a few refinements to my original version, which was really raw. (It's still raw.)
2018-02-23 15:45:25 +01:00
"tictactoe_widget": false,
Add "zform" functionality to the web client. A "zform" knows how to render data that follows our schema for widget messages with form elements like buttons and choices. This code won't be triggered until a subsequent server-side commit takes widget_content from API callers such as the trivial chat bot and creates submessages for us.
2018-02-23 15:37:19 +01:00
"zform": false,
Add basic widgets framework (JS side).
2018-02-23 16:20:33 +01:00
"widgetize": false,
Add client code for handling submessages. This commit lays the foundation to handle submessages for plugin widgets. Right now it just logs events, but subsequent commits will add widget functionality.
2018-02-12 15:12:40 +01:00
"submessage": false,
build_emoji: Generate emoji names and codepoints from emoji_map. Replaces the hardcoded list of emoji_names and unicode_emoji_names in static/js/emoji.js with a list generated from emoji_map.json, both to get the list out of version control and so we can start modifying it for our autocomplete. This does not change the contents of emoji_names. It sorts and removes duplicates from unicode_emoji_names (causes no change in behavior, since unicode_emoji_names is only used as if it were a set).
2017-01-26 00:41:53 +01:00
"Plotly": false,
Implement persistent drafts functionality * Created a drafts modal to display/restore/delete drafts * Created a Draft model to support storing draft data in localstorage * Removed existing restore-draft functionality * Added casper and node tests for drafts functionality Fixes #1717.
2017-02-22 02:34:05 +01:00
"emoji_codes": false,
markdown: Add TeX typesetting support. Co-authored-by: Reid Barton <rwbarton@gmail.com> Fixes #2056.
2017-03-20 16:56:39 +01:00
"drafts": false,
message_edit: Added copy to clipboard button. A copy-to-clipboard button is added over message-edit textarea. Closes #3239.
2017-01-17 20:51:30 +01:00
"katex": false,
clipboard: Update clipboard to v2.0.0 to avoid variable name conflict. It turns out, now we have a new standard way to access clipboard by `Clipboard` method and currently this conflict with the constructor exported by clipboard package. The new update v2.0.0 was released to address this issue. The new version just exports the constructor as `ClipboardJS`. Ref: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard Ref: https://github.com/zenorocha/clipboard.js/issues/468
2018-04-05 23:45:12 +02:00
"ClipboardJS": false,
emoji: Move all emoji picker logic/events into emoji_picker module. Added emoji_picker.js to static asset pipeline.
2017-04-27 07:27:25 +02:00
"emoji_picker": false,
Break compose.js and drafts.js dependency.
2017-04-23 08:51:26 +02:00
"hotspots": false,
common.js: Migrate `common.js` module to use IIFE module style. This module was exposing its functions as globals. This PR fixes it use the IIFE module style that we use in our other modules.
2017-06-22 22:08:43 +02:00
"compose_ui": false,
notifications: Prompt user to enable desktop notifications. This is a two-step notifications process that will ask a user to enable notifications and if they click exit give them three options: 1. Enable notifications. 2. Ask later. 3. Never ask on this computer again. The first two are self-explanatory (ask later = next session it asks again). The third is captured and stored in localStorage and a check is done on page load to see whether or not notifications should be displayed. Commit modified heavily by Brock Whittaker <brock@zulipchat.com>. Fixes #1189.
2017-09-23 11:27:18 +02:00
"common": false,
ui scrollbar: Update perfect-scrollbar to 1.3.0. Update perfect-scrollbar to fix stutter space-scrolling in #8544. Also reworked deprecated `element.perfectScrollbar` to `new PerfectScrollbar(element)`. Lastly, updated provision version and changed node module path to new path. This also refactors perfect-scrollbar in help.js to work with updated version of perfect-scrollbar. Because the update also changed perfect-scrollbar's css selectors for all scrollbars in zulip, we update those too. Fixes #8544.
2018-03-20 04:10:20 +01:00
"panels": false,
"PerfectScrollbar": false
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
},
lint: Replace 'return undefined;' with 'return;'. Also adds a custom rule to eslint. Since the recommended way of extending eslint is to create plugins as standalone npm packages, the separate rule is published as 'eslint-plugins-empty-returns'. Fixes #8669.
2018-03-13 13:04:16 +01:00
"plugins": [
"eslint-plugin-empty-returns"
],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"rules": {
eslint: change array-callback-return from warning to error.
2016-12-05 07:53:36 +01:00
"array-callback-return": "error",
eslint: Set array-bracket-spacing rule and clean project.
2017-10-06 21:43:12 +02:00
"array-bracket-spacing": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"arrow-spacing": [ "error", { "before": true, "after": true } ],
"block-scoped-var": 2,
"brace-style": [ "error", "1tbs", { "allowSingleLine": true } ],
"camelcase": 0,
"comma-dangle": [ "error",
{
"arrays": "always-multiline",
"objects": "always-multiline",
"imports": "always-multiline",
"exports": "always-multiline",
"functions": "never"
}
],
"complexity": [ 0, 4 ],
"curly": 2,
"dot-notation": [ "error", { "allowKeywords": true } ],
lint: Replace 'return undefined;' with 'return;'. Also adds a custom rule to eslint. Since the recommended way of extending eslint is to create plugins as standalone npm packages, the separate rule is published as 'eslint-plugins-empty-returns'. Fixes #8669.
2018-03-13 13:04:16 +01:00
"empty-returns/main": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"eol-last": [ "error", "always" ],
linter: Simplify '===' eslint rule configuration. We don't need the allow-null setting.
2017-09-28 19:47:08 +02:00
"eqeqeq": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"func-style": [ "off", "expression" ],
"guard-for-in": 2,
eslint: Add whitespace indentation configuration. This should help prevent problems with folks introducing new code that doesn't match our whitespace style. There's a couple things I don't like about this configuration: * How it handles multi-line JS lists (i.e. the [] syntax) * That we ended up having to turn off indentation on a half-dozen files that apparently don't use our standard IIFE indentation style. * That we have it completely turned off for the node tests; ideally, we'd just have slightly different rules around the IIFE identation story. But otherwise, this works pretty well, and should catch a pretty wide range of indentation regressions.
2018-04-06 20:43:18 +02:00
"indent": ["error", 4, {
"ArrayExpression": "first",
"outerIIFEBody": 0,
"ObjectExpression": "first",
"SwitchCase": 0,
"CallExpression": {"arguments": "first"},
"FunctionExpression": {"parameters": "first"},
"FunctionDeclaration": {"parameters": "first"}
}],
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"keyword-spacing": [ "error",
{
"before": true,
"after": true,
"overrides": {
"return": { "after": true },
"throw": { "after": true },
"case": { "after": true }
}
}
],
"max-depth": [ 0, 4 ],
"max-len": [ "error", 100, 2,
{
"ignoreUrls": true,
"ignoreComments": false,
"ignoreRegExpLiterals": true,
"ignoreStrings": true,
"ignoreTemplateLiterals": true
}
],
"max-params": [ 0, 3 ],
"max-statements": [ 0, 10 ],
"new-cap": [ "error",
{
"newIsCap": true,
"capIsNew": false
}
],
"new-parens": 2,
"newline-per-chained-call": 0,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-alert": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-array-constructor": "error",
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-bitwise": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-caller": 2,
"no-case-declarations": "error",
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-catch-shadow": 2,
Change all '1' (warn) flags to '0' in eslint. This changes all warn flags to no-warn because warn flags currently are not tracked nor monitored by the linter but do show up on a line-by-line basis in text editors using the eslint plugin which ends up causing a lot of noise.
2017-02-02 01:21:12 +01:00
"no-console": 0,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-const-assign": "error",
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-control-regex": 2,
"no-debugger": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-delete-var": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-div-regex": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-dupe-class-members": "error",
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-dupe-keys": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-duplicate-imports": "error",
eslint: change no-else-return to error and fix violations
2016-12-02 21:34:35 +01:00
"no-else-return": 2,
Switch no-empty eslint rule from warning to error (in .eslintrc)
2016-12-05 02:35:14 +01:00
"no-empty": 2,
.eslintrc: Replace spaces with tabs.
2016-11-29 17:59:32 +01:00
"no-empty-character-class": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-eq-null": 2,
"no-eval": 2,
"no-ex-assign": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-extra-parens": [ "error", "functions" ],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-extra-semi": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-fallthrough": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-floating-decimal": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-func-assign": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-implied-eval": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-iterator": "error",
"no-label-var": 2,
"no-labels": 2,
"no-loop-func": 2,
"no-mixed-requires": [ 0, false ],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-multi-str": 2,
"no-native-reassign": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-nested-ternary": 0,
"no-new-func": "error",
"no-new-object": 2,
"no-new-wrappers": 2,
"no-obj-calls": 2,
"no-octal": 2,
"no-octal-escape": 2,
"no-param-reassign": 0,
eslint: change no-plusplus from warning to 2 and fix violations.
2016-11-30 19:05:04 +01:00
"no-plusplus": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-proto": 2,
"no-redeclare": 2,
"no-regex-spaces": 2,
"no-restricted-syntax": 0,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-return-assign": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-script-url": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-self-compare": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-shadow": 0,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-sync": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-ternary": 0,
"no-undef": "error",
"no-undef-init": 2,
Change all '1' (warn) flags to '0' in eslint. This changes all warn flags to no-warn because warn flags currently are not tracked nor monitored by the linter but do show up on a line-by-line basis in text editors using the eslint plugin which ends up causing a lot of noise.
2017-02-02 01:21:12 +01:00
"no-underscore-dangle": 0,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-unneeded-ternary": [ "error", { "defaultAssignment": false } ],
"no-unreachable": 2,
"no-unused-expressions": 2,
"no-unused-vars": [ "error",
{
"vars": "local",
"args": "after-used",
"varsIgnorePattern": "print_elapsed_time|check_duplicate_ids"
}
],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"no-use-before-define": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-useless-constructor": "error",
// The Zulip codebase complies partially with the "no-useless-escape"
// rule; only regex expressions haven't been updated yet.
// Updated regex expressions are currently being tested in casper
// files and will decide about a potential future enforcement of this rule.
"no-useless-escape": 0,
eslint: Add and enable `space-unary-ops` rule. Info about rule at https://eslint.org/docs/rules/space-unary-ops.
2018-06-04 21:09:11 +02:00
"space-unary-ops": 2,
eslint: Enable "no-whitespace-before-property".
2018-05-31 08:55:18 +02:00
"no-whitespace-before-property": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-with": 2,
"one-var": [ "error", "never" ],
"padded-blocks": 0,
"prefer-const": [ "error",
{
"destructuring": "any",
"ignoreReadBeforeAssign": true
}
],
"quote-props": [ "error", "as-needed",
{
"keywords": false,
"unnecessary": true,
"numbers": false
}
],
"quotes": [ 0, "single" ],
Tighten eslint rules with zero errors to airbnb values. block-scoped-vars, guard-for-in, radix and valid-typeof are eslint rules that were set to warning in the eslintrc. Since there are no errors, they have been toggled to the appropriate values from the airbnb style guide.
2016-11-27 10:01:39 +01:00
"radix": 2,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"semi": 2,
eslint: change space-before-blocks from warning to error and fix violations
2016-12-02 23:45:20 +01:00
"space-before-blocks": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"space-before-function-paren": [ "error",
{
"anonymous": "always",
"named": "never",
"asyncArrow": "always"
}
],
eslint: Add and enforce space-in-parens lint rule.
2017-10-06 21:36:39 +02:00
"space-in-parens": 2,
eslint: Enable space-infix-ops rule. More about rule at https://eslint.org/docs/rules/space-infix-ops
2018-06-04 21:13:07 +02:00
"space-infix-ops": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"spaced-comment": 0,
Change all '1' (warn) flags to '0' in eslint. This changes all warn flags to no-warn because warn flags currently are not tracked nor monitored by the linter but do show up on a line-by-line basis in text editors using the eslint plugin which ends up causing a lot of noise.
2017-02-02 01:21:12 +01:00
"strict": 0,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"template-curly-spacing": "error",
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"unnecessary-strict": 0,
"use-isnan": 2,
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"valid-typeof": [ "error", { "requireStringLiterals": true } ],
"wrap-iife": [ "error", "outside", { "functionPrototypeMethods": false } ],
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"wrap-regex": 0,
Switch yoda eslint rule from warning to error (in .eslintrc)
2016-12-05 03:39:24 +01:00
"yoda": 2
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
}
}