Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/stream_settings/stream_settings.hbs

139 lines
7.2 KiB
Handlebars
Raw Normal View History

stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
<div class="stream_settings_header" data-stream-id="{{sub.stream_id}}">
<div class="tab-container"></div>
{{#with sub}}
<div class="button-group">
<div class="sub_unsub_button_wrapper inline-block">
tooltips: Add tippy tooltips in manage stream settings. Added tippy tooltips for create_stream_plus_button and preview-stream-button in manage stream settings by adding class `.tippy-zulip-delayed-tooltip` which add tooltips with LONG_HOVER_DELAY. Added data-tippy-placement="bottom" to match with 'Archive stream' tooltip. Created a new tooltip for sub_unsub_button in tippyjs with class .toggle-subscription-tooltip that has EXTRA_LONG_HOVER_DELAY, placement equals to bottom and appended to body. Fixes part of #24311.
2023-04-08 22:57:06 +02:00
<button class="button small rounded subscribe-button sub_unsub_button {{#if should_display_subscription_button}}toggle-subscription-tooltip{{/if}} {{#unless subscribed }}unsubscribed{{/unless}}" type="button" name="button" {{#if should_display_subscription_button}} data-tooltip-template-id="toggle-subscription-tooltip-template" {{else}}disabled="disabled"{{/if}}>
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
{{#if subscribed }}
templates: Replace unnecessary {{#tr}} blocks with {{t}} helper. `{{#tr}}` supports HTML and allows translators to accidentally introduce HTML, so it’s safer to use the `{{t}}` helper unless HTML is needed. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-03-15 23:51:27 +01:00
{{t "Unsubscribe" }}
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
{{else}}
templates: Replace unnecessary {{#tr}} blocks with {{t}} helper. `{{#tr}}` supports HTML and allows translators to accidentally introduce HTML, so it’s safer to use the `{{t}}` helper unless HTML is needed. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-03-15 23:51:27 +01:00
{{t "Subscribe" }}
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
{{/if}}
</button>
stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
</div>
tooltips: Add tippy tooltips in manage stream settings. Added tippy tooltips for create_stream_plus_button and preview-stream-button in manage stream settings by adding class `.tippy-zulip-delayed-tooltip` which add tooltips with LONG_HOVER_DELAY. Added data-tippy-placement="bottom" to match with 'Archive stream' tooltip. Created a new tooltip for sub_unsub_button in tippyjs with class .toggle-subscription-tooltip that has EXTRA_LONG_HOVER_DELAY, placement equals to bottom and appended to body. Fixes part of #24311.
2023-04-08 22:57:06 +02:00
<a href="{{preview_url}}" class="button small rounded tippy-zulip-delayed-tooltip" id="preview-stream-button" role="button" data-tooltip-template-id="view-stream-tooltip-template" data-tippy-placement="bottom" {{#unless should_display_preview_button }}style="display: none"{{/unless}}><i class="fa fa-eye"></i></a>
stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
{{#if is_realm_admin}}
stream settings: Use tippy-zulip-delayed-tooltip more. This fixes an issue where the "Change stream info" button would display a tooltip immediately upon closing the modal to edit the stream name and description.
2023-05-02 01:31:42 +02:00
<button class="button small rounded btn-danger deactivate tippy-zulip-delayed-tooltip" type="button" name="delete_button" data-tippy-content="{{t 'Archive stream'}}"> <i class="fa fa-trash-o" aria-hidden="true"></i></button>
stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
{{/if}}
</div>
{{/with}}
</div>
stream settings: Deduplicate template rendering.
2019-06-14 14:42:48 +02:00
<div class="subscription_settings" data-stream-id="{{sub.stream_id}}">
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
<div class="inner-box">
stream settings: Move the "Saving" widget to "Personal settings" block. Rather than showing the "Saving" widget beside stream name, it's more intuitive to have it in personal settings section because it's the only section which uses `settings_ui.do_settings_change` function and we follow having a separate "Saving" widget for each section everywhere.
2020-05-24 14:24:23 +02:00
stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
<div class="general_settings stream_section">
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
{{#with sub}}
stream_settings: Remove pencil icon from 'General' tab in stream settings. For user who is not an administrator. Also implemented a banner that notifies the user if they can edit the following settings (name/description and stream permission). Also increased padding-top of stream header by 10px. This change is done to increase vertical spacing between the banner and the stream header. Fixes #20001.
2021-10-20 06:26:53 +02:00
<div class="stream-settings-tip-container">
{{> stream_settings_tip}}
</div>
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
<div class="stream-header">
stream settings: Move subscription_settings.hbs to stream_settings. This commmit does following two changes to subscription_settings.hbs: * Rename subscription_settings to stream_settings to have a uniform naming pattern for stream settings. * Move it to stream_settings folder.
2021-07-18 13:49:31 +02:00
{{> stream_privacy_icon
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
invite_only=invite_only
is_web_public=is_web_public }}
<div class="stream-name">
<span class="sub-stream-name" title="{{name}}">{{name}}</span>
</div>
<div class="stream_change_property_info alert-notification"></div>
stream_settings: Remove pencil icon from 'General' tab in stream settings. For user who is not an administrator. Also implemented a banner that notifies the user if they can edit the following settings (name/description and stream permission). Also increased padding-top of stream header by 10px. This change is done to increase vertical spacing between the banner and the stream header. Fixes #20001.
2021-10-20 06:26:53 +02:00
<div class="button-group" {{#unless can_change_name_description}}style="display:none"{{/unless}}>
stream settings: Improve label for stream edit modal. "Change stream info" was very ambigious about what types of information can be changed in the modal in question.
2023-05-02 01:33:13 +02:00
<button id="open_stream_info_modal" class="button rounded small btn-warning tippy-zulip-delayed-tooltip" data-tippy-content="{{t 'Edit stream name and description' }}">
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
<i class="fa fa-pencil" aria-hidden="true"></i>
</button>
streams: Disable sub-btn with explanation if user not allowed to subscribe.
2019-05-06 14:35:57 +02:00
</div>
streams: Make stream settings inputs responsive to narrow screens. This makes the inputs and buttons responsive to narrow screens by gracefully resizing and falling in place. Fixes: #7712.
2017-12-13 21:37:40 +01:00
</div>
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
<div class="stream-description">
stream settings: Move subscription_settings.hbs to stream_settings. This commmit does following two changes to subscription_settings.hbs: * Rename subscription_settings to stream_settings to have a uniform naming pattern for stream settings. * Move it to stream_settings folder.
2021-07-18 13:49:31 +02:00
{{> stream_description
stream settings: Improve message for no description streams.
2021-07-08 23:21:47 +02:00
rendered_description=rendered_description
}}
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
</div>
stream settings: Always show stream settings. We now show the stream permission settings - stream privacy, stream post policy and stream message retentions setting, always in the "General" section of stream settings instead of showing it in the modal. The setting elements are disabled for users who cannot change them. Some important changes are - - Add proper classes and IDs to the elements such that code in settings_org.js can be used to set and change these settings. - Code in "settings_org.js" is updated to be able to set stream message retention setting while rendering the page. - Added enable_or_disable_permission_settings_in_edit_panel function in stream_ui_updates.js (since that will also be used in live updating code) to disable the setting elements if required. - We also update update_web_public_stream_privacy_option_state function such that we can correctly enable/disable web-public option in stream edit panel based on permissions. - Added code for save-discard widget in stream_settings.hbs in this commit but code to implement the correct behavior of it will be added in further commits. Fixes part of #19519.
2022-10-18 11:03:09 +02:00
<div class="stream-permissions settings-subsection-parent" id="stream_permission_settings">
<div class="subsection-header">
<h3 class="stream_setting_subsection_title">{{t "Stream permissions" }}
</h3>
{{> ../settings/settings_save_discard_widget section_name="stream-permissions" }}
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
</div>
stream settings: Always show stream settings. We now show the stream permission settings - stream privacy, stream post policy and stream message retentions setting, always in the "General" section of stream settings instead of showing it in the modal. The setting elements are disabled for users who cannot change them. Some important changes are - - Add proper classes and IDs to the elements such that code in settings_org.js can be used to set and change these settings. - Code in "settings_org.js" is updated to be able to set stream message retention setting while rendering the page. - Added enable_or_disable_permission_settings_in_edit_panel function in stream_ui_updates.js (since that will also be used in live updating code) to disable the setting elements if required. - We also update update_web_public_stream_privacy_option_state function such that we can correctly enable/disable web-public option in stream edit panel based on permissions. - Added code for save-discard widget in stream_settings.hbs in this commit but code to implement the correct behavior of it will be added in further commits. Fixes part of #19519.
2022-10-18 11:03:09 +02:00
{{> stream_types
stream_post_policy_values=../stream_post_policy_values
stream_privacy_policy_values=../stream_privacy_policy_values
stream_privacy_policy=../stream_privacy_policy
zulip_plan_is_not_limited=../zulip_plan_is_not_limited
upgrade_text_for_wide_organization_logo=../upgrade_text_for_wide_organization_logo
stream_settings: Fix upgrade text in stream edit panel. The upgrade text shown for message retention setting for realms on limited plans should mention about sponsorship only for non-business orgs. In the stream edit panel, the sponsorship text was present even for non-business orgs because the is_business_type_org parameter was not being passed to the template, so this commit fixes the code to pass the is_busines_type_org parameter correctly to the template.
2023-01-06 08:46:50 +01:00
is_business_type_org=../is_business_type_org
stream settings: Always show stream settings. We now show the stream permission settings - stream privacy, stream post policy and stream message retentions setting, always in the "General" section of stream settings instead of showing it in the modal. The setting elements are disabled for users who cannot change them. Some important changes are - - Add proper classes and IDs to the elements such that code in settings_org.js can be used to set and change these settings. - Code in "settings_org.js" is updated to be able to set stream message retention setting while rendering the page. - Added enable_or_disable_permission_settings_in_edit_panel function in stream_ui_updates.js (since that will also be used in live updating code) to disable the setting elements if required. - We also update update_web_public_stream_privacy_option_state function such that we can correctly enable/disable web-public option in stream edit panel based on permissions. - Added code for save-discard widget in stream_settings.hbs in this commit but code to implement the correct behavior of it will be added in further commits. Fixes part of #19519.
2022-10-18 11:03:09 +02:00
org_level_message_retention_setting=../org_level_message_retention_setting
stream: Add UI to set can_remove_subscribers_group when creating stream. This commit adds dropdown-list-widget element in create stream UI to set can_remove_subscribers_group setting when creating stream. For now only role-based system groups are shown as options.
2022-12-30 10:55:10 +01:00
is_stream_edit=true
can_remove_subscribers_setting_widget_name="can_remove_subscribers_group_id" }}
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
</div>
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
{{/with}}
stream settings: Move stream email to General settings tab.
2021-07-04 19:39:24 +02:00
<div class="stream-email-box" {{#unless sub.email_address}}style="display: none;"{{/unless}}>
minor: Improve heading for different stream setting subsections.
2021-07-08 22:54:57 +02:00
<h3 class="stream_setting_subsection_title">
stream settings: Move stream email to General settings tab.
2021-07-04 19:39:24 +02:00
{{t "Email address" }}
stream settings: Move subscription_settings.hbs to stream_settings. This commmit does following two changes to subscription_settings.hbs: * Rename subscription_settings to stream_settings to have a uniform naming pattern for stream settings. * Move it to stream_settings folder.
2021-07-18 13:49:31 +02:00
{{> ../help_link_widget link="/help/message-a-stream-by-email" }}
minor: Improve heading for different stream setting subsections.
2021-07-08 22:54:57 +02:00
</h3>
stream settings: Add copy email address modal. This moves the stream email address to a modal and adds a copy button. Fixes part of #19519.
2022-03-04 11:07:16 +01:00
<p>
{{t "You can use email to send messages to Zulip streams."}}
</p>
<p>
<button class="button rounded copy_email_button" type="button" name="button">
templates: Replace unnecessary {{#tr}} blocks with {{t}} helper. `{{#tr}}` supports HTML and allows translators to accidentally introduce HTML, so it’s safer to use the `{{t}}` helper unless HTML is needed. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-03-15 23:51:27 +01:00
<span class="copy_button">{{t "Generate email address" }}</span>
stream settings: Add copy email address modal. This moves the stream email address to a modal and adds a copy button. Fixes part of #19519.
2022-03-04 11:07:16 +01:00
</button>
</p>
stream settings: Move stream email to General settings tab.
2021-07-04 19:39:24 +02:00
</div>
stream settings: Always show stream type, regardless of subscribed or not.
2018-01-06 12:29:55 +01:00
</div>
stream settings: Move the "Saving" widget to "Personal settings" block. Rather than showing the "Saving" widget beside stream name, it's more intuitive to have it in personal settings section because it's the only section which uses `settings_ui.do_settings_change` function and we follow having a separate "Saving" widget for each section everywhere.
2020-05-24 14:24:23 +02:00
stream settings: Remove Bootstrap collapse class. This class was leftover from a very old version of this design, and had the side effect of settings `overflow: hidden` on the panel. This, in turn, resulted in the focus outlines for clicking on checkboxes looking broken.
2022-03-11 00:49:18 +01:00
<div id="personal-stream-settings" class="personal_settings stream_section">
minor: Improve heading for different stream setting subsections.
2021-07-08 22:54:57 +02:00
<div class="subsection-header">
<h3 class="stream_setting_subsection_title inline-block">{{t "Personal settings" }}</h3>
<div id="stream_change_property_status{{sub.stream_id}}" class="stream_change_property_status alert-notification"></div>
stream settings: Move the "Saving" widget to "Personal settings" block. Rather than showing the "Saving" widget beside stream name, it's more intuitive to have it in personal settings section because it's the only section which uses `settings_ui.do_settings_change` function and we follow having a separate "Saving" widget for each section everywhere.
2020-05-24 14:24:23 +02:00
</div>
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
<div class="subscription-config">
stream_settings: Replace ul, li tags with div tags for checkboxes. Due to reasons similar to 5de115a9646a330a778360525b289448a944ba73, we switch from using `ul`/`li`s to using `div`s here.
2021-11-22 18:00:02 +01:00
<div class="subsection-parent">
stream settings: Remove further differences from settings.css. This fixes various visual glitches that resulted from reusing components and overriding key elements of them. The specific logical changes are as follows: * Delete custom checkbox positioning for stream settings; we now just use the common app_components.css code. * Remove custom subscription-control-label styling; just use settings defaults. * Copy the h3/h4 styling from settings.css. Ideally we'll deduplicate this in further cleanup. * Add the inline property to stream_settings_checkbox elements, to reduce variable with settings_checkbox.hbs. * Place every individual input inside an input-group, so that we can use the standard settings.css styling.
2021-11-23 23:41:57 +01:00
{{#each other_settings}}
templates: Always indent "each" blocks.
2021-12-04 15:39:38 +01:00
<div class="input-group">
{{> stream_settings_checkbox
setting_name=name
is_checked=is_checked
is_muted=(lookup ../sub "is_muted")
stream_id=(lookup ../sub "stream_id")
notification_setting=false
disabled_realm_setting=disabled_realm_setting
is_disabled=is_disabled
label=label}}
</div>
stream settings: Remove further differences from settings.css. This fixes various visual glitches that resulted from reusing components and overriding key elements of them. The specific logical changes are as follows: * Delete custom checkbox positioning for stream settings; we now just use the common app_components.css code. * Remove custom subscription-control-label styling; just use settings defaults. * Copy the h3/h4 styling from settings.css. Ideally we'll deduplicate this in further cleanup. * Add the inline property to stream_settings_checkbox elements, to reduce variable with settings_checkbox.hbs. * Place every individual input inside an input-group, so that we can use the standard settings.css styling.
2021-11-23 23:41:57 +01:00
{{/each}}
stream_settings: Replace ul, li tags with div tags for checkboxes. Due to reasons similar to 5de115a9646a330a778360525b289448a944ba73, we switch from using `ul`/`li`s to using `div`s here.
2021-11-22 18:00:02 +01:00
<div class="input-group">
css: Delete now unused subscription-control-label class. We're now styling these widgets identically to settings, and don't see a special class.
2021-11-23 23:49:32 +01:00
<label for="streamcolor">{{t "Stream color" }}</label>
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
<span class="sub_setting_control">
stream settings: Deduplicate template rendering.
2019-06-14 14:42:48 +02:00
<input stream_id="{{sub.stream_id}}" class="colorpicker" id="streamcolor" type="text" value="{{sub.color}}" tabindex="-1" />
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
</span>
stream_settings: Replace ul, li tags with div tags for checkboxes. Due to reasons similar to 5de115a9646a330a778360525b289448a944ba73, we switch from using `ul`/`li`s to using `div`s here.
2021-11-22 18:00:02 +01:00
</div>
</div>
stream settings: Remove further differences from settings.css. This fixes various visual glitches that resulted from reusing components and overriding key elements of them. The specific logical changes are as follows: * Delete custom checkbox positioning for stream settings; we now just use the common app_components.css code. * Remove custom subscription-control-label styling; just use settings defaults. * Copy the h3/h4 styling from settings.css. Ideally we'll deduplicate this in further cleanup. * Add the inline property to stream_settings_checkbox elements, to reduce variable with settings_checkbox.hbs. * Place every individual input inside an input-group, so that we can use the standard settings.css styling.
2021-11-23 23:41:57 +01:00
<h4 class="stream_setting_subsection_title">{{t "Notification settings" }}</h4>
stream_settings: Replace ul, li tags with div tags for checkboxes. Due to reasons similar to 5de115a9646a330a778360525b289448a944ba73, we switch from using `ul`/`li`s to using `div`s here.
2021-11-22 18:00:02 +01:00
<div class="subsection-parent">
stream settings: Remove further differences from settings.css. This fixes various visual glitches that resulted from reusing components and overriding key elements of them. The specific logical changes are as follows: * Delete custom checkbox positioning for stream settings; we now just use the common app_components.css code. * Remove custom subscription-control-label styling; just use settings defaults. * Copy the h3/h4 styling from settings.css. Ideally we'll deduplicate this in further cleanup. * Add the inline property to stream_settings_checkbox elements, to reduce variable with settings_checkbox.hbs. * Place every individual input inside an input-group, so that we can use the standard settings.css styling.
2021-11-23 23:41:57 +01:00
{{#each notification_settings}}
templates: Always indent "each" blocks.
2021-12-04 15:39:38 +01:00
<div class="input-group">
{{> stream_settings_checkbox
setting_name=name
is_checked=is_checked
is_muted=(lookup ../sub "is_muted")
stream_id=(lookup ../sub "stream_id")
notification_setting=true
disabled_realm_setting=disabled_realm_setting
is_disabled=is_disabled
label=label}}
</div>
stream settings: Remove further differences from settings.css. This fixes various visual glitches that resulted from reusing components and overriding key elements of them. The specific logical changes are as follows: * Delete custom checkbox positioning for stream settings; we now just use the common app_components.css code. * Remove custom subscription-control-label styling; just use settings defaults. * Copy the h3/h4 styling from settings.css. Ideally we'll deduplicate this in further cleanup. * Add the inline property to stream_settings_checkbox elements, to reduce variable with settings_checkbox.hbs. * Place every individual input inside an input-group, so that we can use the standard settings.css styling.
2021-11-23 23:41:57 +01:00
{{/each}}
stream_settings: Replace ul, li tags with div tags for checkboxes. Due to reasons similar to 5de115a9646a330a778360525b289448a944ba73, we switch from using `ul`/`li`s to using `div`s here.
2021-11-22 18:00:02 +01:00
</div>
Clean subscription_settings.handlebars to use 4 space indents.
2017-04-15 04:20:32 +02:00
</div>
stream settings: Move stream-email-box from regular_subscription_settings. `stream-email-box` doesn't fit into `regular_subscription_settings` div, therefore moved `stream-email-box` out of it.
2020-05-16 17:53:50 +02:00
</div>
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
stream settings: Re-design stream settings page using tab-switchers. We move away from a single scrollable page to have a tabs settings structure instead. This commit consists of the minimal changes required to set up toggler component. And the subsequent commits would include all the UI UX changes required for updating the layouts. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-06-26 15:28:24 +02:00
<div class="subscriber_settings stream_section">
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
{{#with sub}}
stream edit: Tighten up selectors for handlers. Even though we intend to shortly share lots of code for editing stream subscribers with the create-stream UI, we don't want to confuse click handlers and containers too much.
2021-12-21 17:39:05 +01:00
<div class="edit_subscribers_for_stream">
settings: Remove unused show_email parameter. We show "Email" column heading always in users list and subscriber list irrespective of the email-address visibility setting after 46660e5, so we do need to pass show_email parameter to render_admin_tab and render_stream_settings.
2021-11-09 18:59:22 +01:00
{{> stream_members}}
templates: Wrap subscription settings into 3 respective sections. We wrap the general stream name, description and type properties in a "general_settings" div. The "regular_subscription_settings" div was already present, so the only change made was renaming this to "personal_settings". We also wrap the email and adding of members settings in a new "subscriber_settings" div. This is a prep commit which will be helpful when we want to display only one section and hide the other two. Co-authored-by: Ryan Rehman <ryanrehman99@gmail.com>
2021-07-01 11:34:18 +02:00
</div>
{{/with}}
subs: Extract subscription_settings.handlebars. This is an early step towards being able to decouple the subscription settings section from the slideout behavior.
2016-10-28 06:52:17 +02:00
</div>
</div>
</div>