From 4815a946c2861408475a15986d021d694908f728 Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Mon, 21 Feb 2022 13:59:00 -0500 Subject: [PATCH] extruder_stepper: Do not default to synching with "extruder" at startup With recent changes, the extruder_stepper may be used for new purposes, and synchronizing to the "extruder" motion queue at startup may become a confusing default. Signed-off-by: Kevin O'Connor --- docs/Config_Changes.md | 6 ++++++ docs/Config_Reference.md | 4 ++-- klippy/extras/extruder_stepper.py | 2 +- test/klippy/extruders.cfg | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/docs/Config_Changes.md b/docs/Config_Changes.md index 45d19acb..5cbe1eae 100644 --- a/docs/Config_Changes.md +++ b/docs/Config_Changes.md @@ -8,6 +8,12 @@ All dates in this document are approximate. ## Changes +20220304: There is no longer a default for the `extruder` parameter of +[extruder_stepper](Config_Reference.md#extruder_stepper) config +sections. If desired, specify `extruder: extruder` explicitly to +associate the stepper motor with the "extruder" motion queue at +startup. + 20220210: The `SYNC_STEPPER_TO_EXTRUDER` command is deprecated; the `SET_EXTRUDER_STEP_DISTANCE` command is deprecated; the [extruder](Config_Reference.md#extruder) `shared_heater` config option diff --git a/docs/Config_Reference.md b/docs/Config_Reference.md index bc66b86a..743c3a64 100644 --- a/docs/Config_Reference.md +++ b/docs/Config_Reference.md @@ -1829,10 +1829,10 @@ See the [command reference](G-Codes.md#extruder) for more information. ``` [extruder_stepper my_extra_stepper] -#extruder: extruder +extruder: # The extruder this stepper is synchronized to. If this is set to an # empty string then the stepper will not be synchronized to an -# extruder. The default is "extruder". +# extruder. This parameter must be provided. #step_pin: #dir_pin: #enable_pin: diff --git a/klippy/extras/extruder_stepper.py b/klippy/extras/extruder_stepper.py index 40b394ce..16647679 100644 --- a/klippy/extras/extruder_stepper.py +++ b/klippy/extras/extruder_stepper.py @@ -10,7 +10,7 @@ class PrinterExtruderStepper: def __init__(self, config): self.printer = config.get_printer() self.extruder_stepper = extruder.ExtruderStepper(config) - self.extruder_name = config.get('extruder', 'extruder') + self.extruder_name = config.get('extruder') self.printer.register_event_handler("klippy:connect", self.handle_connect) def handle_connect(self): diff --git a/test/klippy/extruders.cfg b/test/klippy/extruders.cfg index 2892df54..d7123d08 100644 --- a/test/klippy/extruders.cfg +++ b/test/klippy/extruders.cfg @@ -50,6 +50,7 @@ min_temp: 0 max_temp: 210 [extruder_stepper my_extra_stepper] +extruder: extruder step_pin: PH5 dir_pin: PH6 enable_pin: !PB5