From 12e6aaf316ec9b3e9af84df160f1a1ae69cf052a Mon Sep 17 00:00:00 2001
From: Kevin O'Connor <kevin@koconnor.net>
Date: Wed, 1 May 2019 14:48:37 -0400
Subject: [PATCH] config: Updates to kit-zav3d-2019.cfg

Minor updates to the kit-zav3d-2019.cfg to make it look more like
other config files: specify the micro-controller type, use the
klipper3d.org site for documentation links, avoid using SAVE_CONFIG
sections in the example configs, add config to printers.test.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
---
 config/kit-zav3d-2019.cfg | 61 ++++++++++++---------------------------
 test/klippy/printers.test |  1 +
 2 files changed, 20 insertions(+), 42 deletions(-)

diff --git a/config/kit-zav3d-2019.cfg b/config/kit-zav3d-2019.cfg
index a6e60c05..502d0645 100644
--- a/config/kit-zav3d-2019.cfg
+++ b/config/kit-zav3d-2019.cfg
@@ -1,7 +1,9 @@
-# ZAV3D MAX config
+# ZAV3D MAX config. To use this config, the firmware should be
+# compiled for the AVR atmega2560.
 
-# This is a base printer.cfg file for the ZAV3D Max printer and matches the manual/build guide exactly
-# for controllers used (MKS MINI-B V1.0) and pin layout for all connected components.
+# This is a base printer.cfg file for the ZAV3D Max printer and
+# matches the manual/build guide exactly for controllers used (MKS
+# MINI-B V1.0) and pin layout for all connected components.
 # Created by "Nurmukhamed Artykaly"
 
 # This file is only an example - be sure to review and update it
@@ -9,7 +11,7 @@
 # example-extras.cfg files for a description of available Klipper parameters.
 
 # AND PLEASE READ THROUGH THE KLIPPER DOCUMENTATION FIRST!
-# https://github.com/KevinOConnor/klipper/tree/master/docs
+# https://www.klipper3d.org/Overview.html
 
 # *** THINGS TO CHANGE/CHECK: ***
 # Arduino paths                         [mcu] section
@@ -58,7 +60,7 @@ homing_speed: 50
 #homing_positive_dir: true
 
 ## Configuration for Bltouch probe tool.
-## Read more about BLTOUCH here https://github.com/KevinOConnor/klipper/blob/master/docs/BLTouch.md
+## Read more about BLTOUCH here https://www.klipper3d.org/BLTouch.html
 [stepper_z]
 step_pin: ar46
 dir_pin: ar48
@@ -69,7 +71,7 @@ position_max: 230
 endstop_pin: probe:z_virtual_endstop
 
 ## Configuration with PID Calibration.
-## Read more here https://github.com/KevinOConnor/klipper/blob/master/docs/Config_checks.md
+## Read more here https://www.klipper3d.org/Config_checks.html
 [extruder]
 step_pin: ar26
 dir_pin: !ar28
@@ -82,15 +84,23 @@ sensor_type: EPCOS 100K B57560G104F
 sensor_pin: analog13
 min_temp: 0
 max_temp: 250
+control: pid
+pid_kp: 26.596
+pid_ki: 1.166
+pid_kd: 151.598
 
 ## Configuration with PID Calibration.
-## Read more here https://github.com/KevinOConnor/klipper/blob/master/docs/Config_checks.md
+## Read more here https://www.klipper3d.org/Config_checks.html
 [heater_bed]
 heater_pin: ar8
 sensor_type: EPCOS 100K B57560G104F
 sensor_pin: analog14
 min_temp: 0
 max_temp: 130
+control: pid
+pid_kp: 73.517
+pid_ki: 1.822
+pid_kd: 741.600
 
 [fan]
 pin: ar9
@@ -101,7 +111,6 @@ pin_map: arduino
 
 [printer]
 kinematics: corexy
-#   This option must be "corexy" for corexy printers.
 max_velocity: 300
 max_accel: 3000
 max_z_velocity: 25
@@ -125,7 +134,7 @@ max_point: 150,150
 probe_count: 3,3
 
 [homing_override]
-set_position_z:6
+set_position_z: 6
 axes: z
 gcode:
         G90
@@ -134,41 +143,9 @@ gcode:
         G1 X100 Y100 F6000
         G28 Z0
         G1 X100 Y100 Z10a
+
 [gcode_macro G29]
 gcode:
         G28
         G1 Z10 F600
         BED_MESH_CALIBRATE
-
-#*# <---------------------- SAVE_CONFIG ---------------------->
-#*# DO NOT EDIT THIS BLOCK OR BELOW. The contents are auto-generated.
-#*#
-#*# [bed_mesh default]
-#*# points =
-#*#       0.522500, 0.010000, -0.533750
-#*#       0.662500, 0.115000, -0.406250
-#*#       0.645000, -2.923750, -0.357500
-#*# x_count = 3
-#*# y_count = 3
-#*# min_x = 30.0
-#*# max_x = 150.0
-#*# min_y = 30.0
-#*# max_y = 150.0
-#*# x_offset = 39.0
-#*# y_offset = 11.0
-#*# mesh_x_pps = 2
-#*# mesh_y_pps = 2
-#*# algo = lagrange
-#*# tension = 0.2
-#*#
-#*# [extruder]
-#*# control = pid
-#*# pid_kp = 26.596
-#*# pid_ki = 1.166
-#*# pid_kd = 151.598
-#*#
-#*# [heater_bed]
-#*# control = pid
-#*# pid_kp = 73.517
-#*# pid_ki = 1.822
-#*# pid_kd = 741.600
diff --git a/test/klippy/printers.test b/test/klippy/printers.test
index 84e26bb0..eb175b29 100644
--- a/test/klippy/printers.test
+++ b/test/klippy/printers.test
@@ -17,6 +17,7 @@ CONFIG ../../config/generic-mini-rambo.cfg
 CONFIG ../../config/generic-rambo.cfg
 CONFIG ../../config/generic-ramps.cfg
 CONFIG ../../config/generic-rumba.cfg
+CONFIG ../../config/kit-zav3d-2019.cfg
 CONFIG ../../config/printer-adimlab-2018.cfg
 CONFIG ../../config/printer-anycubic-4max-2018.cfg
 CONFIG ../../config/printer-anycubic-i3-mega-2017.cfg